* [Buildroot] [PATCH 1/2] package/quickjs: disable on microblaze
@ 2023-06-25 17:57 Bernd Kuhls
2023-06-25 17:57 ` [Buildroot] [PATCH 2/2] package/quickjs: disable on sh* Bernd Kuhls
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Bernd Kuhls @ 2023-06-25 17:57 UTC (permalink / raw)
To: buildroot
quickjs unconditionally uses FE_{DOWN,UP}WARD and so fails to build on
microblaze since its addition in commit
5d50793659acb95050c110d5fc05399df20ce30b
Fixes:
http://autobuild.buildroot.net/results/3b1/3b1b1f91998bfdec65f3e6fb8931df9c8871b953/
Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
---
package/quickjs/Config.in | 2 ++
1 file changed, 2 insertions(+)
diff --git a/package/quickjs/Config.in b/package/quickjs/Config.in
index dc466241ba..292dba86d0 100644
--- a/package/quickjs/Config.in
+++ b/package/quickjs/Config.in
@@ -1,5 +1,6 @@
config BR2_PACKAGE_QUICKJS
bool "quickjs"
+ depends on !BR2_microblaze # fenv.h lacks FE_{DOWN,UP}WARD
depends on !BR2_nios2 # fenv.h lacks FE_{DOWN,UP}WARD on nios2
depends on !BR2_STATIC_LIBS
# No way to check for fenv support.
@@ -15,6 +16,7 @@ config BR2_PACKAGE_QUICKJS
https://bellard.org/quickjs/
comment "quickjs needs a glibc or musl toolchain w/ gcc >= 4.9, host gcc >= 4.9, dynamic library"
+ depends on !BR2_microblaze
depends on !BR2_nios2
depends on BR2_USE_MMU
depends on BR2_STATIC_LIBS || BR2_TOOLCHAIN_USES_UCLIBC || \
--
2.39.2
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 5+ messages in thread* [Buildroot] [PATCH 2/2] package/quickjs: disable on sh*
2023-06-25 17:57 [Buildroot] [PATCH 1/2] package/quickjs: disable on microblaze Bernd Kuhls
@ 2023-06-25 17:57 ` Bernd Kuhls
2023-07-16 6:09 ` Peter Korsgaard
2023-06-25 19:39 ` [Buildroot] [PATCH 1/2] package/quickjs: disable on microblaze Arnout Vandecappelle via buildroot
2023-07-16 6:09 ` Peter Korsgaard
2 siblings, 1 reply; 5+ messages in thread
From: Bernd Kuhls @ 2023-06-25 17:57 UTC (permalink / raw)
To: buildroot
quickjs unconditionally uses FE_{DOWN,UP}WARD and so fails to build on
sh* since its addition in commit
5d50793659acb95050c110d5fc05399df20ce30b
Fixes:
sh4: http://autobuild.buildroot.net/results/46d/46d7da58a857939ee3a33f60ab64ad278157c3bd/
sh4a: http://autobuild.buildroot.net/results/b1d/b1db05e79e5505c6606524e54e159224b633eac2/
sh4aeb: http://autobuild.buildroot.net/results/c30/c307a1b67142405f81c9276056b28bea366f2ccf/
sh4eb: http://autobuild.buildroot.net/results/945/945b508385ba5aa25f982f8a8493628fa828e472/
Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
---
package/quickjs/Config.in | 2 ++
1 file changed, 2 insertions(+)
diff --git a/package/quickjs/Config.in b/package/quickjs/Config.in
index 292dba86d0..fd174bc657 100644
--- a/package/quickjs/Config.in
+++ b/package/quickjs/Config.in
@@ -2,6 +2,7 @@ config BR2_PACKAGE_QUICKJS
bool "quickjs"
depends on !BR2_microblaze # fenv.h lacks FE_{DOWN,UP}WARD
depends on !BR2_nios2 # fenv.h lacks FE_{DOWN,UP}WARD on nios2
+ depends on !BR2_sh # fenv.h lacks FE_{DOWN,UP}WARD
depends on !BR2_STATIC_LIBS
# No way to check for fenv support.
depends on !BR2_TOOLCHAIN_USES_UCLIBC
@@ -18,6 +19,7 @@ config BR2_PACKAGE_QUICKJS
comment "quickjs needs a glibc or musl toolchain w/ gcc >= 4.9, host gcc >= 4.9, dynamic library"
depends on !BR2_microblaze
depends on !BR2_nios2
+ depends on !BR2_sh
depends on BR2_USE_MMU
depends on BR2_STATIC_LIBS || BR2_TOOLCHAIN_USES_UCLIBC || \
!BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 || !BR2_HOST_GCC_AT_LEAST_4_9
--
2.39.2
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [Buildroot] [PATCH 1/2] package/quickjs: disable on microblaze
2023-06-25 17:57 [Buildroot] [PATCH 1/2] package/quickjs: disable on microblaze Bernd Kuhls
2023-06-25 17:57 ` [Buildroot] [PATCH 2/2] package/quickjs: disable on sh* Bernd Kuhls
@ 2023-06-25 19:39 ` Arnout Vandecappelle via buildroot
2023-07-16 6:09 ` Peter Korsgaard
2 siblings, 0 replies; 5+ messages in thread
From: Arnout Vandecappelle via buildroot @ 2023-06-25 19:39 UTC (permalink / raw)
To: Bernd Kuhls, buildroot
On 25/06/2023 19:57, Bernd Kuhls wrote:
> quickjs unconditionally uses FE_{DOWN,UP}WARD and so fails to build on
> microblaze since its addition in commit
> 5d50793659acb95050c110d5fc05399df20ce30b
>
> Fixes:
> http://autobuild.buildroot.net/results/3b1/3b1b1f91998bfdec65f3e6fb8931df9c8871b953/
>
> Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
Applied both to master, thanks.
Regards,
Arnout
> ---
> package/quickjs/Config.in | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/package/quickjs/Config.in b/package/quickjs/Config.in
> index dc466241ba..292dba86d0 100644
> --- a/package/quickjs/Config.in
> +++ b/package/quickjs/Config.in
> @@ -1,5 +1,6 @@
> config BR2_PACKAGE_QUICKJS
> bool "quickjs"
> + depends on !BR2_microblaze # fenv.h lacks FE_{DOWN,UP}WARD
> depends on !BR2_nios2 # fenv.h lacks FE_{DOWN,UP}WARD on nios2
> depends on !BR2_STATIC_LIBS
> # No way to check for fenv support.
> @@ -15,6 +16,7 @@ config BR2_PACKAGE_QUICKJS
> https://bellard.org/quickjs/
>
> comment "quickjs needs a glibc or musl toolchain w/ gcc >= 4.9, host gcc >= 4.9, dynamic library"
> + depends on !BR2_microblaze
> depends on !BR2_nios2
> depends on BR2_USE_MMU
> depends on BR2_STATIC_LIBS || BR2_TOOLCHAIN_USES_UCLIBC || \
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [Buildroot] [PATCH 1/2] package/quickjs: disable on microblaze
2023-06-25 17:57 [Buildroot] [PATCH 1/2] package/quickjs: disable on microblaze Bernd Kuhls
2023-06-25 17:57 ` [Buildroot] [PATCH 2/2] package/quickjs: disable on sh* Bernd Kuhls
2023-06-25 19:39 ` [Buildroot] [PATCH 1/2] package/quickjs: disable on microblaze Arnout Vandecappelle via buildroot
@ 2023-07-16 6:09 ` Peter Korsgaard
2 siblings, 0 replies; 5+ messages in thread
From: Peter Korsgaard @ 2023-07-16 6:09 UTC (permalink / raw)
To: Bernd Kuhls; +Cc: buildroot
>>>>> "Bernd" == Bernd Kuhls <bernd@kuhls.net> writes:
> quickjs unconditionally uses FE_{DOWN,UP}WARD and so fails to build on
> microblaze since its addition in commit
> 5d50793659acb95050c110d5fc05399df20ce30b
> Fixes:
> http://autobuild.buildroot.net/results/3b1/3b1b1f91998bfdec65f3e6fb8931df9c8871b953/
> Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
Committed to 2023.02.x and 2023.05.x, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-07-16 6:09 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-06-25 17:57 [Buildroot] [PATCH 1/2] package/quickjs: disable on microblaze Bernd Kuhls
2023-06-25 17:57 ` [Buildroot] [PATCH 2/2] package/quickjs: disable on sh* Bernd Kuhls
2023-07-16 6:09 ` Peter Korsgaard
2023-06-25 19:39 ` [Buildroot] [PATCH 1/2] package/quickjs: disable on microblaze Arnout Vandecappelle via buildroot
2023-07-16 6:09 ` Peter Korsgaard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox