Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] znc: fix build without openssl
@ 2018-06-10 19:09 Baruch Siach
  2018-06-11 20:01 ` Peter Korsgaard
  2018-08-23 19:39 ` Peter Korsgaard
  0 siblings, 2 replies; 3+ messages in thread
From: Baruch Siach @ 2018-06-10 19:09 UTC (permalink / raw)
  To: buildroot

Add a patch to include <memory> unconditionally.

Fixes:
http://autobuild.buildroot.net/results/4c3/4c3d9f6f5214052b7eda4c7bbfabe5b463080b12/
http://autobuild.buildroot.net/results/d06/d06176f00109ad0707032b0d76fe94f1d414106c/

Cc: Bernd Kuhls <bernd.kuhls@t-online.de>
Signed-off-by: Baruch Siach <baruch@tkos.co.il>
---
 .../0001-Fix-build-without-SSL-support.patch  | 37 +++++++++++++++++++
 1 file changed, 37 insertions(+)
 create mode 100644 package/znc/0001-Fix-build-without-SSL-support.patch

diff --git a/package/znc/0001-Fix-build-without-SSL-support.patch b/package/znc/0001-Fix-build-without-SSL-support.patch
new file mode 100644
index 000000000000..23b78ed4beea
--- /dev/null
+++ b/package/znc/0001-Fix-build-without-SSL-support.patch
@@ -0,0 +1,37 @@
+From a263157165c411552d73a211ac9c7647285abdc5 Mon Sep 17 00:00:00 2001
+From: Baruch Siach <baruch@tkos.co.il>
+Date: Sun, 10 Jun 2018 22:01:47 +0300
+Subject: [PATCH] Fix build without SSL support
+
+The <memory> headers is needed for unique_ptr even when SSL is not
+enabled. This fixes the following build failure:
+
+src/Utils.cpp: In static member function 'static bool CUtils::CheckCIDR(const CString&, const CString&)':
+src/Utils.cpp:674:5: error: 'unique_ptr' is not a member of 'std'
+     std::unique_ptr<addrinfo, decltype(deleter)> aiHost(aiHostC, deleter);
+     ^
+
+Signed-off-by: Baruch Siach <baruch@tkos.co.il>
+---
+Upstream status: https://github.com/znc/znc/pull/1554
+
+ src/Utils.cpp | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/src/Utils.cpp b/src/Utils.cpp
+index 9c3b2549b791..cced5683d78a 100644
+--- a/src/Utils.cpp
++++ b/src/Utils.cpp
+@@ -27,8 +27,8 @@
+ #include <znc/Message.h>
+ #ifdef HAVE_LIBSSL
+ #include <openssl/ssl.h>
+-#include <memory>
+ #endif /* HAVE_LIBSSL */
++#include <memory>
+ #include <unistd.h>
+ #include <time.h>
+ 
+-- 
+2.17.1
+
-- 
2.17.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH] znc: fix build without openssl
  2018-06-10 19:09 [Buildroot] [PATCH] znc: fix build without openssl Baruch Siach
@ 2018-06-11 20:01 ` Peter Korsgaard
  2018-08-23 19:39 ` Peter Korsgaard
  1 sibling, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2018-06-11 20:01 UTC (permalink / raw)
  To: buildroot

>>>>> "Baruch" == Baruch Siach <baruch@tkos.co.il> writes:

 > Add a patch to include <memory> unconditionally.
 > Fixes:
 > http://autobuild.buildroot.net/results/4c3/4c3d9f6f5214052b7eda4c7bbfabe5b463080b12/
 > http://autobuild.buildroot.net/results/d06/d06176f00109ad0707032b0d76fe94f1d414106c/

 > Cc: Bernd Kuhls <bernd.kuhls@t-online.de>
 > Signed-off-by: Baruch Siach <baruch@tkos.co.il>

Committed, thanks.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH] znc: fix build without openssl
  2018-06-10 19:09 [Buildroot] [PATCH] znc: fix build without openssl Baruch Siach
  2018-06-11 20:01 ` Peter Korsgaard
@ 2018-08-23 19:39 ` Peter Korsgaard
  1 sibling, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2018-08-23 19:39 UTC (permalink / raw)
  To: buildroot

>>>>> "Baruch" == Baruch Siach <baruch@tkos.co.il> writes:

 > Add a patch to include <memory> unconditionally.
 > Fixes:
 > http://autobuild.buildroot.net/results/4c3/4c3d9f6f5214052b7eda4c7bbfabe5b463080b12/
 > http://autobuild.buildroot.net/results/d06/d06176f00109ad0707032b0d76fe94f1d414106c/

 > Cc: Bernd Kuhls <bernd.kuhls@t-online.de>
 > Signed-off-by: Baruch Siach <baruch@tkos.co.il>

Committed to 2018.02.x and 2018.05.x, thanks.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-08-23 19:39 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-06-10 19:09 [Buildroot] [PATCH] znc: fix build without openssl Baruch Siach
2018-06-11 20:01 ` Peter Korsgaard
2018-08-23 19:39 ` Peter Korsgaard

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox