Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v10 1/2] genimage.sh: fix calling from BR2_ROOTFS_POST_IMAGE_SCRIPT
Date: Thu, 27 Apr 2017 23:36:01 +0200	[thread overview]
Message-ID: <874lx9jzy6.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20170424052445.7637-1-abhimanyu.v@gmail.com> (Abhimanyu Vishwakarma's message of "Mon, 24 Apr 2017 10:54:45 +0530")

>>>>> "Abhimanyu" == Abhimanyu Vishwakarma <abhimanyu.v@gmail.com> writes:

 > From: Abhimanyu Vishwakarma <Abhimanyu.V@gmail.com>
 > When called from BR2_ROOTFS_POST_IMAGE_SCRIPT, this script
 > ends up with following error:

 > Error: Missing argument

 > This is because, an extra positional argument is also passed
 > along with BR2_ROOTFS_POST_SCRIPT_ARGS. genimage.sh didn't
 > have support to parse positional and optional arguments
 > together.

 > Signed-off-by: Abhimanyu Vishwakarma <Abhimanyu.V@gmail.com>
 > Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
 > Tested-by: Rahul Bedarkar <rahulbedarkar89@gmail.com>

 > ---
 >  Changes v7->v8
 >    - New file
 >  Changes v8->v9
 >    - Fix indentation
 >    - Use bash basename as script name instead hardcoding (by arnout)
 >  Changes v9->v10 (Suggested by Arnout)
 >    - Remove tab indentation (use existing 2 space indent)
 >    - Fix commit message grammer
 >    - add reviewed-by tag
 >    - keep tested-by tag as no code change just indentation

 >  support/scripts/genimage.sh | 19 ++++++++++++++-----
 >  1 file changed, 14 insertions(+), 5 deletions(-)

Committed, thanks.

-- 
Bye, Peter Korsgaard

      reply	other threads:[~2017-04-27 21:36 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-24  5:24 [Buildroot] [PATCH v10 1/2] genimage.sh: fix calling from BR2_ROOTFS_POST_IMAGE_SCRIPT Abhimanyu Vishwakarma
2017-04-27 21:36 ` Peter Korsgaard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874lx9jzy6.fsf@dell.be.48ers.dk \
    --to=peter@korsgaard.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox