Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 2/3] package/cal3d: new package
Date: Sun, 20 Dec 2015 22:52:20 +0100	[thread overview]
Message-ID: <874mfchjor.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20151219142509.GA3394@free.fr> (Yann E. MORIN's message of "Sat,  19 Dec 2015 15:25:09 +0100")

>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:

Hi,

 > I really don't know what to do with git-submodules.

 > But in this precise case, I would:
 >   - dump the cal3d package
 >   - add a post-download hook (or an extra-download URL) to vsxu to also
 >     download cal3d
 >   - add a post-extract hook to vsxu to also extract cal3d in the correct
 >     location.

 > Then, when/if cal3d is later used by other packages, we can revisit the
 > situation.

Yes, I think that makes sense as well.


 > Otherwise, for proper git-submodule handling, we would have to do
 > (roughly):

 >     git clone blabla pkg-version
 >     cd pkg-version
 >     git checkout pkg-version
 >     git submodule update --init --recursive
 >     find . -name .git -exec rm -rf {} +
 >     cd ..
 >     tar czf DL_DIR/pkg-version.tar.gz pkg-version/

 > This is not very complex, but is stil la significant change from our
 > current git wrapper.

Yes, I would prefer if we wouldn't have to do that.

 > And then, what about svn externals? About Hg subrepos? Does bzr also
 > have such a thing?

For svn we create the tarball ourselves, so I believe externals should
work.

I'm not really familiar with hg, but I guess it behaves like git.


 > Note that I would not really mind doing such a change. But is it worth
 > it, given that we currently have only one package that needs submodules?
 > Or do we have others for which we had to "deal with it" in a crude way?

I had a local package at work that originally used git submodules, and
the gstreamer packages use a submodule for "common stuff", so we would
have the issue if we ever moved to getting these from git.

So I think there is a potential use case for it, but it is really quite
a pity that they aren't handled natively by git archive.

Perhaps we should bring it up with the git developers?

-- 
Venlig hilsen,
Peter Korsgaard 

  parent reply	other threads:[~2015-12-20 21:52 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-07 16:50 [Buildroot] [PATCH v2 0/3] New packages libglfw/cal3d/vsxu Bernd Kuhls
2015-11-07 16:50 ` [Buildroot] [PATCH v2 1/3] package/libglfw: new package Bernd Kuhls
2015-12-19 13:59   ` Thomas Petazzoni
2015-11-07 16:50 ` [Buildroot] [PATCH v2 2/3] package/cal3d: " Bernd Kuhls
2015-12-19 14:00   ` Thomas Petazzoni
2015-12-19 14:25     ` Yann E. MORIN
2015-12-19 14:35       ` Thomas Petazzoni
2015-12-19 14:47       ` Arnout Vandecappelle
2015-12-20 21:52       ` Peter Korsgaard [this message]
2015-12-19 14:35     ` Arnout Vandecappelle
2015-12-19 14:39   ` Arnout Vandecappelle
2015-11-07 16:50 ` [Buildroot] [PATCH v2 3/3] package/vsxu: " Bernd Kuhls
2015-12-19 14:43   ` Arnout Vandecappelle
2015-12-19 15:14   ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874mfchjor.fsf@dell.be.48ers.dk \
    --to=peter@korsgaard.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox