Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/skeleton: add a startup script to wait for slow network interfaces
Date: Sat, 03 Oct 2015 15:59:11 +0200	[thread overview]
Message-ID: <874mi86ok0.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <1443879105-3036-1-git-send-email-yann.morin.1998@free.fr> (Yann E. MORIN's message of "Sat, 3 Oct 2015 14:31:45 +0100")

>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:

 > On some machines, the network interface is slow to appear. For example,
 > on the Raspberry Pi, the network interface eth0 is an ethernet-over-USB,
 > and our standard boot process is too fast, so our network startup script
 > is called before the USB bus is compeltely enumerated, thus it can't
 > configure eth0.

 > If Buildroot is configured to do a DHCP on an interface, install a
 > startup script, just before S40network, that waits for that interface.

 > Since Buildroot can only be configured to run DHCP on a single interface,
 > we do not need a script that waits for more than one interface.

 > Closes #8116.

A more generic solution for dynamic changes to network interfaces is to
NOT mark them as auto and instead use ifplugd -M <interface>.

 > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
 > ---
 >  package/skeleton/S39wait-for-network-if | 43 +++++++++++++++++++++++++++++++++
 >  package/skeleton/skeleton.mk            |  2 ++
 >  2 files changed, 45 insertions(+)
 >  create mode 100644 package/skeleton/S39wait-for-network-if

 > diff --git a/package/skeleton/S39wait-for-network-if b/package/skeleton/S39wait-for-network-if
 > new file mode 100644
 > index 0000000..010026e
 > --- /dev/null
 > +++ b/package/skeleton/S39wait-for-network-if
 > @@ -0,0 +1,43 @@
 > +#!/bin/sh
 > +
 > +# In case we have a slow-to-appear interface (e.g. eth-over-USB),
 > +# and we need to configure it, wait until it appears. But not too
 > +# long either. WAIT_DELAY is in seconds.
 > +WAIT_DELAY=15
 > +
 > +wait_for_IF() {
 > +    IF="$(sed -r -e '/^auto lo/d;' \
 > +                 -e '/^auto (.+)$/!d;' \
 > +                 -e 's//\1/;' \
 > +                 /etc/network/interfaces
 > +         )"

This assumes we have at most 1 interface to wait for.

Perhaps we could instead do something like (untested):

IFACES=$(awk '/^auto/ { print $2 }' /tmp/interfaces)

for i in $(seq $WAIT_DELAY); do
    for IFACE in $IFACES; do
        if [ ! -e "/tmp/$IFACE" ]; then
           sleep 1
           continue 2
        fi
    done

    echo "ok"; exit 0
done

echo "timeout"; exit 1

-- 
Bye, Peter Korsgaard

  parent reply	other threads:[~2015-10-03 13:59 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-03 13:31 [Buildroot] [PATCH] package/skeleton: add a startup script to wait for slow network interfaces Yann E. MORIN
2015-10-03 13:51 ` Arnout Vandecappelle
2015-10-03 13:59 ` Peter Korsgaard [this message]
2015-10-03 14:01   ` Peter Korsgaard
2015-10-16  9:42   ` Peter Korsgaard
2015-10-03 15:47 ` Thomas Petazzoni
2015-10-03 18:29   ` Maxime Hadjinlian
2015-10-03 18:43     ` Arnout Vandecappelle
2015-10-03 18:46       ` Maxime Hadjinlian
2015-10-04  8:23   ` Peter Korsgaard
2015-10-19  8:47 ` Jérôme Pouiller
2015-10-19 10:15   ` Peter Korsgaard
2015-10-19 10:22     ` Jérôme Pouiller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874mi86ok0.fsf@dell.be.48ers.dk \
    --to=peter@korsgaard.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox