Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/skeleton: add a startup script to wait for slow network interfaces
Date: Mon, 19 Oct 2015 12:15:40 +0200	[thread overview]
Message-ID: <87a8rf88qb.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <4678408.ifdbXGka0U@sagittea> ("Jérôme Pouiller"'s message of "Mon, 19 Oct 2015 10:47:10 +0200")

>>>>> "J?r?me" == J?r?me Pouiller <jezz@sysmic.org> writes:

Hi,

> I am a bit late to do the review, but why not add a script in 
 > /etc/network/if-pre-up.d ? For example (notice $IFACE and $IF_MAXWAIT 
 > are set by ifupdown):

 > #! /bin/sh
 > if [ "${IF_MAXWAIT}" ]; then
 >     printf "Waiting for interface %s to appear" "${IFACE}"
 >     while [ ${IF_MAXWAIT} -gt 0 ]; do
 >         if [ -e "/sys/class/net/${IFACE}" ]; then
 >             printf " yes\n"
 >             exit 0
 >         fi
 >         sleep 1
 >         printf "."
 >         : $((wait--))
 >     done
 >     printf " no.\n"
 >     exit 1
 > fi

That's certainly also an option. Care to send a patch reworking the
logic in S40network to a pre-up.d hook?

 > Next, interface would use "maxwait" property in /etc/network/interface:

 > auto eth0
 > iface eth0 inet dhcp
 >     maxwait 15

Then our BR2_SYSTEM_DHCP logic should probably also be adapted to add
'maxwait 15' by default.

Thanks!

-- 
Bye, Peter Korsgaard

  reply	other threads:[~2015-10-19 10:15 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-03 13:31 [Buildroot] [PATCH] package/skeleton: add a startup script to wait for slow network interfaces Yann E. MORIN
2015-10-03 13:51 ` Arnout Vandecappelle
2015-10-03 13:59 ` Peter Korsgaard
2015-10-03 14:01   ` Peter Korsgaard
2015-10-16  9:42   ` Peter Korsgaard
2015-10-03 15:47 ` Thomas Petazzoni
2015-10-03 18:29   ` Maxime Hadjinlian
2015-10-03 18:43     ` Arnout Vandecappelle
2015-10-03 18:46       ` Maxime Hadjinlian
2015-10-04  8:23   ` Peter Korsgaard
2015-10-19  8:47 ` Jérôme Pouiller
2015-10-19 10:15   ` Peter Korsgaard [this message]
2015-10-19 10:22     ` Jérôme Pouiller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a8rf88qb.fsf@dell.be.48ers.dk \
    --to=peter@korsgaard.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox