[Buildroot] [PATCH 1/1] linux:linux.mk: Add "firmware-imx" dependency if needed

[Buildroot] [PATCH 1/1] linux:linux.mk: Add "firmware-imx" dependency if needed

[Leger Charlie]

Since SDMA firmwares for imx[6,7,8] are now provided only by firmware-imx package and not linux-firmware package [1].
Linux build can failed if depending on firmware imx, so add firmware-imx dependency on linux if package is checked.

[1] http://lists.busybox.net/pipermail/buildroot/2021-January/603807.html

Signed-off-by: Leger Charlie <c.leger@borea-dental.com>
---
 linux/linux.mk | 1 +
 1 file changed, 1 insertion(+)

diff --git a/linux/linux.mk b/linux/linux.mk
index 7ff7b05042..e40672ceca 100644
--- a/linux/linux.mk
+++ b/linux/linux.mk
@@ -73,6 +73,7 @@ LINUX_INSTALL_IMAGES = YES
 LINUX_DEPENDENCIES = host-kmod \
 	$(if $(BR2_PACKAGE_INTEL_MICROCODE),intel-microcode) \
 	$(if $(BR2_PACKAGE_LINUX_FIRMWARE),linux-firmware) \
+	$(if $(BR2_PACKAGE_FREESCALE_IMX),firmware-imx) \
 	$(if $(BR2_PACKAGE_WIRELESS_REGDB),wireless-regdb)
 
 # Starting with 4.16, the generated kconfig paser code is no longer
-- 
2.32.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] linux:linux.mk: Add "firmware-imx" dependency if needed

[Baruch Siach via buildroot]

Hi Leger,

On Wed, May 04 2022, Leger Charlie wrote:
> Since SDMA firmwares for imx[6,7,8] are now provided only by firmware-imx package and not linux-firmware package [1].
> Linux build can failed if depending on firmware imx, so add firmware-imx dependency on linux if package is checked.

What build failure do you see when firmware-imx does not install before
kernel build? As far as I can see firmware files are only used at
run-time.

baruch

> [1] http://lists.busybox.net/pipermail/buildroot/2021-January/603807.html
>
> Signed-off-by: Leger Charlie <c.leger@borea-dental.com>
> ---
>  linux/linux.mk | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/linux/linux.mk b/linux/linux.mk
> index 7ff7b05042..e40672ceca 100644
> --- a/linux/linux.mk
> +++ b/linux/linux.mk
> @@ -73,6 +73,7 @@ LINUX_INSTALL_IMAGES = YES
>  LINUX_DEPENDENCIES = host-kmod \
>  	$(if $(BR2_PACKAGE_INTEL_MICROCODE),intel-microcode) \
>  	$(if $(BR2_PACKAGE_LINUX_FIRMWARE),linux-firmware) \
> +	$(if $(BR2_PACKAGE_FREESCALE_IMX),firmware-imx) \
>  	$(if $(BR2_PACKAGE_WIRELESS_REGDB),wireless-regdb)
>  
>  # Starting with 4.16, the generated kconfig paser code is no longer

-- 
                                                     ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] linux:linux.mk: Add "firmware-imx" dependency if needed

[Charlie Leger]

[-- Attachment #1.1: Type: text/plain, Size: 2161 bytes --]

Hi Baruch,

Thank you for your review

Le 04/05/2022 à 11:43, Baruch Siach a écrit :
> Hi Leger,
>
> On Wed, May 04 2022, Leger Charlie wrote:
>> Since SDMA firmwares for imx[6,7,8] are now provided only by firmware-imx package and not linux-firmware package [1].
>> Linux build can failed if depending on firmware imx, so add firmware-imx dependency on linux if package is checked.
> What build failure do you see when firmware-imx does not install before
> kernel build? As far as I can see firmware files are only used at
> run-time.
Failure will happens only for specific kernel configuration which used 
"CONFIG_EXTRA_FIRMWARE" option [1], which allow to built-in firmware.
If firmware needed belongs to "firmware-imx" package, linux build will 
failed.

Charlie,

https://cateee.net/lkddb/web-lkddb/EXTRA_FIRMWARE.html
>
> baruch
>
>> [1]http://lists.busybox.net/pipermail/buildroot/2021-January/603807.html
>>
>> Signed-off-by: Leger Charlie<c.leger@borea-dental.com>
>> ---
>>   linux/linux.mk | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/linux/linux.mk b/linux/linux.mk
>> index 7ff7b05042..e40672ceca 100644
>> --- a/linux/linux.mk
>> +++ b/linux/linux.mk
>> @@ -73,6 +73,7 @@ LINUX_INSTALL_IMAGES = YES
>>   LINUX_DEPENDENCIES = host-kmod \
>>   	$(if $(BR2_PACKAGE_INTEL_MICROCODE),intel-microcode) \
>>   	$(if $(BR2_PACKAGE_LINUX_FIRMWARE),linux-firmware) \
>> +	$(if $(BR2_PACKAGE_FREESCALE_IMX),firmware-imx) \
>>   	$(if $(BR2_PACKAGE_WIRELESS_REGDB),wireless-regdb)
>>   
>>   # Starting with 4.16, the generated kconfig paser code is no longer

-- 

Charlie LEGER

Embedded Software Technician

Technicien Logiciel Embarqué

	Logo Borea
------------------------------------------------------------------------

6 allée Duke Ellington, Ester Technopole - 87100 Limoges - France

Téléphone +33(0)9 83 71 71 61 Mobile +33(0)6 98 30 25 64

Facebook <https://www.facebook.com/borea.dental> 	Linkedin 
<https://www.linkedin.com/company/borea-sas/> 	Instagram 
<https://www.instagram.com/borea_dental/> 	YouTube 
<https://www.youtube.com/channel/UCWFQZnXjcyDNcwObpPsXt6w/> 
www.borea-dental.com <https://www.borea-dental.com>

[-- Attachment #1.2.1: Type: text/html, Size: 6782 bytes --]

[-- Attachment #1.2.2: 4zyn20n1LDRugeUg.png --]
[-- Type: image/png, Size: 3273 bytes --]

[-- Attachment #1.2.3: t9Da00w1e1uMDg0w.png --]
[-- Type: image/png, Size: 5259 bytes --]

[-- Attachment #1.2.4: a8FlAhR0c9mqQXi0.png --]
[-- Type: image/png, Size: 5234 bytes --]

[-- Attachment #1.2.5: 94G3bnWNuuePjrf0.png --]
[-- Type: image/png, Size: 384 bytes --]

[-- Attachment #1.2.6: 0O1dTZaBG06S0ngx.png --]
[-- Type: image/png, Size: 398 bytes --]

[-- Attachment #1.2.7: v9G2aeM1DWM0E5Ft.png --]
[-- Type: image/png, Size: 1510 bytes --]

[-- Attachment #1.2.8: bR0Opzk6afXL0J0u.png --]
[-- Type: image/png, Size: 1358 bytes --]

[-- Attachment #2: Type: text/plain, Size: 150 bytes --]

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] linux:linux.mk: Add "firmware-imx" dependency if needed

[Baruch Siach via buildroot]

Hi Charlie,

On Wed, May 04 2022, Charlie Leger wrote:
> Thank you for your review
>
> Le 04/05/2022 à 11:43, Baruch Siach a écrit :
> On Wed, May 04 2022, Leger Charlie wrote:
>
>  Since SDMA firmwares for imx[6,7,8] are now provided only by firmware-imx package and not linux-firmware
>  package [1].
> Linux build can failed if depending on firmware imx, so add firmware-imx dependency on linux if package is checked.
>
>
> What build failure do you see when firmware-imx does not install before
> kernel build? As far as I can see firmware files are only used at
> run-time.
>
> Failure will happens only for specific kernel configuration which used "CONFIG_EXTRA_FIRMWARE" option [1], which allow to built-in firmware.
> If firmware needed belongs to "firmware-imx" package, linux build will failed.

Thanks for the clarification. The commit log should mention that
firmware-imx is needed at build time for CONFIG_EXTRA_FIRMWARE.

baruch

> Charlie,
>
> https://cateee.net/lkddb/web-lkddb/EXTRA_FIRMWARE.html
>
> baruch
>
>  [1] http://lists.busybox.net/pipermail/buildroot/2021-January/603807.html
>
> Signed-off-by: Leger Charlie <c.leger@borea-dental.com>
> ---
>  linux/linux.mk | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/linux/linux.mk b/linux/linux.mk
> index 7ff7b05042..e40672ceca 100644
> --- a/linux/linux.mk
> +++ b/linux/linux.mk
> @@ -73,6 +73,7 @@ LINUX_INSTALL_IMAGES = YES
>  LINUX_DEPENDENCIES = host-kmod \
>  	$(if $(BR2_PACKAGE_INTEL_MICROCODE),intel-microcode) \
>  	$(if $(BR2_PACKAGE_LINUX_FIRMWARE),linux-firmware) \
> +	$(if $(BR2_PACKAGE_FREESCALE_IMX),firmware-imx) \
>  	$(if $(BR2_PACKAGE_WIRELESS_REGDB),wireless-regdb)
>  
>  # Starting with 4.16, the generated kconfig paser code is no longer


-- 
                                                     ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] linux:linux.mk: Add "firmware-imx" dependency if needed

[Charlie Leger]

[-- Attachment #1.1: Type: text/plain, Size: 2527 bytes --]

Hi Baruch,

Le 04/05/2022 à 12:06, Baruch Siach a écrit :
> Hi Charlie,
>
> On Wed, May 04 2022, Charlie Leger wrote:
>> Thank you for your review
>>
>> Le 04/05/2022 à 11:43, Baruch Siach a écrit :
>> On Wed, May 04 2022, Leger Charlie wrote:
>>
>>   Since SDMA firmwares for imx[6,7,8] are now provided only by firmware-imx package and not linux-firmware
>>   package [1].
>> Linux build can failed if depending on firmware imx, so add firmware-imx dependency on linux if package is checked.
>>
>>
>> What build failure do you see when firmware-imx does not install before
>> kernel build? As far as I can see firmware files are only used at
>> run-time.
>>
>> Failure will happens only for specific kernel configuration which used "CONFIG_EXTRA_FIRMWARE" option [1], which allow to built-in firmware.
>> If firmware needed belongs to "firmware-imx" package, linux build will failed.
> Thanks for the clarification. The commit log should mention that
> firmware-imx is needed at build time for CONFIG_EXTRA_FIRMWARE.

I'm sorry for the dummy question... do I need to provide a v2 patch for it ?

> baruch
>
>> Charlie,
>>
>> https://cateee.net/lkddb/web-lkddb/EXTRA_FIRMWARE.html
>>
>> baruch
>>
>>   [1]http://lists.busybox.net/pipermail/buildroot/2021-January/603807.html
>>
>> Signed-off-by: Leger Charlie<c.leger@borea-dental.com>
>> ---
>>   linux/linux.mk | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/linux/linux.mk b/linux/linux.mk
>> index 7ff7b05042..e40672ceca 100644
>> --- a/linux/linux.mk
>> +++ b/linux/linux.mk
>> @@ -73,6 +73,7 @@ LINUX_INSTALL_IMAGES = YES
>>   LINUX_DEPENDENCIES = host-kmod \
>>   	$(if $(BR2_PACKAGE_INTEL_MICROCODE),intel-microcode) \
>>   	$(if $(BR2_PACKAGE_LINUX_FIRMWARE),linux-firmware) \
>> +	$(if $(BR2_PACKAGE_FREESCALE_IMX),firmware-imx) \
>>   	$(if $(BR2_PACKAGE_WIRELESS_REGDB),wireless-regdb)
>>   
>>   # Starting with 4.16, the generated kconfig paser code is no longer
>

-- 

Charlie LEGER

Embedded Software Technician

Technicien Logiciel Embarqué

	Logo Borea
------------------------------------------------------------------------

6 allée Duke Ellington, Ester Technopole - 87100 Limoges - France

Téléphone +33(0)9 83 71 71 61 Mobile +33(0)6 98 30 25 64

Facebook <https://www.facebook.com/borea.dental> 	Linkedin 
<https://www.linkedin.com/company/borea-sas/> 	Instagram 
<https://www.instagram.com/borea_dental/> 	YouTube 
<https://www.youtube.com/channel/UCWFQZnXjcyDNcwObpPsXt6w/> 
www.borea-dental.com <https://www.borea-dental.com>

[-- Attachment #1.2.1: Type: text/html, Size: 7050 bytes --]

[-- Attachment #1.2.2: wAuHlpVKCUAm7WpZ.png --]
[-- Type: image/png, Size: 3273 bytes --]

[-- Attachment #1.2.3: 8UoD0EgSaB7lSQ5G.png --]
[-- Type: image/png, Size: 5259 bytes --]

[-- Attachment #1.2.4: Es2ikL52T7BzAIlF.png --]
[-- Type: image/png, Size: 5234 bytes --]

[-- Attachment #1.2.5: ox0WjIXTWDkoYLuw.png --]
[-- Type: image/png, Size: 384 bytes --]

[-- Attachment #1.2.6: 1Spxztag3QdzDk7B.png --]
[-- Type: image/png, Size: 398 bytes --]

[-- Attachment #1.2.7: 3c0Q618S000Yk6co.png --]
[-- Type: image/png, Size: 1510 bytes --]

[-- Attachment #1.2.8: ZJNrsmQElMBDi373.png --]
[-- Type: image/png, Size: 1358 bytes --]

[-- Attachment #2: Type: text/plain, Size: 150 bytes --]

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] linux:linux.mk: Add "firmware-imx" dependency if needed

[Baruch Siach via buildroot]

Hi Charlie,

On Wed, May 04 2022, Charlie Leger wrote:
> Le 04/05/2022 à 12:06, Baruch Siach a écrit :
> On Wed, May 04 2022, Charlie Leger wrote:
>
>  Thank you for your review
>
> Le 04/05/2022 à 11:43, Baruch Siach a écrit :
> On Wed, May 04 2022, Leger Charlie wrote:
>
>  Since SDMA firmwares for imx[6,7,8] are now provided only by firmware-imx package and not linux-firmware
>  package [1].
> Linux build can failed if depending on firmware imx, so add firmware-imx dependency on linux if package is checked.
>
>
> What build failure do you see when firmware-imx does not install before
> kernel build? As far as I can see firmware files are only used at
> run-time.
>
> Failure will happens only for specific kernel configuration which used "CONFIG_EXTRA_FIRMWARE" option [1], which allow to built-in firmware.
> If firmware needed belongs to "firmware-imx" package, linux build will failed.
>
> Thanks for the clarification. The commit log should mention that
> firmware-imx is needed at build time for CONFIG_EXTRA_FIRMWARE.
>
> I'm sorry for the dummy question... do I need to provide a v2 patch for it ?

I think that a v2 patch would be nice in this case. You might want to
wait a day or two before sending v2 to let others add their comment on
v1.

When sending v2 make sure that commit log lines length is 72 characters
or less.

Thanks,
baruch

-- 
                                                     ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] linux:linux.mk: Add "firmware-imx" dependency if needed

[Arnout Vandecappelle]

On 04/05/2022 11:40, Leger Charlie wrote:
> Since SDMA firmwares for imx[6,7,8] are now provided only by firmware-imx package and not linux-firmware package [1].
> Linux build can failed if depending on firmware imx, so add firmware-imx dependency on linux if package is checked.
> 
> [1] http://lists.busybox.net/pipermail/buildroot/2021-January/603807.html
> 
> Signed-off-by: Leger Charlie <c.leger@borea-dental.com>

  Applied to master, thanks, after adding a note about CONFIG_EXTRA_FIRMWARE and 
wrapping at 72 columns.

  Regards,
  Arnout

> ---
>   linux/linux.mk | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/linux/linux.mk b/linux/linux.mk
> index 7ff7b05042..e40672ceca 100644
> --- a/linux/linux.mk
> +++ b/linux/linux.mk
> @@ -73,6 +73,7 @@ LINUX_INSTALL_IMAGES = YES
>   LINUX_DEPENDENCIES = host-kmod \
>   	$(if $(BR2_PACKAGE_INTEL_MICROCODE),intel-microcode) \
>   	$(if $(BR2_PACKAGE_LINUX_FIRMWARE),linux-firmware) \
> +	$(if $(BR2_PACKAGE_FREESCALE_IMX),firmware-imx) \
>   	$(if $(BR2_PACKAGE_WIRELESS_REGDB),wireless-regdb)
>   
>   # Starting with 4.16, the generated kconfig paser code is no longer
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] linux:linux.mk: Add "firmware-imx" dependency if needed

[Peter Korsgaard]

>>>>> "Leger" == Leger Charlie <c.leger@borea-dental.com> writes:

 > Since SDMA firmwares for imx[6,7,8] are now provided only by firmware-imx package and not linux-firmware package [1].
 > Linux build can failed if depending on firmware imx, so add firmware-imx dependency on linux if package is checked.

 > [1] http://lists.busybox.net/pipermail/buildroot/2021-January/603807.html

 > Signed-off-by: Leger Charlie <c.leger@borea-dental.com>

Committed to 2022.02.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot