* [Buildroot] [PATCH] pulseaudio: remove the ConsoleKit module
@ 2017-12-19 15:12 Baruch Siach
2017-12-19 20:46 ` Peter Korsgaard
2017-12-27 22:29 ` Peter Korsgaard
0 siblings, 2 replies; 3+ messages in thread
From: Baruch Siach @ 2017-12-19 15:12 UTC (permalink / raw)
To: buildroot
The ConsoleKit module is loaded by default from the default.pa
configuration file, but its initialization fails because Buildroot has
no ConsoleKit package yet. This breaks per-user pulseaudio daemon.
The default.pa configuration load module-console-kit only when it
exists. Remove module-console-kit to fix pulseaudio per-user startup.
Signed-off-by: Baruch Siach <baruch@tkos.co.il>
---
package/pulseaudio/pulseaudio.mk | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/package/pulseaudio/pulseaudio.mk b/package/pulseaudio/pulseaudio.mk
index b021fc93a4dd..a30d5401bae2 100644
--- a/package/pulseaudio/pulseaudio.mk
+++ b/package/pulseaudio/pulseaudio.mk
@@ -140,11 +140,17 @@ else
PULSEAUDIO_CONF_OPTS += --disable-x11
endif
+# ConsoleKit module init failure breaks user daemon startup
+define PULSEAUDIO_REMOVE_CONSOLE_KIT
+ rm -f $(TARGET_DIR)/usr/lib/pulse-$(PULSEAUDIO_VERSION)/modules/module-console-kit.so
+endef
+
define PULSEAUDIO_REMOVE_VALA
rm -rf $(TARGET_DIR)/usr/share/vala
endef
-PULSEAUDIO_POST_INSTALL_TARGET_HOOKS += PULSEAUDIO_REMOVE_VALA
+PULSEAUDIO_POST_INSTALL_TARGET_HOOKS += PULSEAUDIO_REMOVE_VALA \
+ PULSEAUDIO_REMOVE_CONSOLE_KIT
ifeq ($(BR2_PACKAGE_PULSEAUDIO_DAEMON),y)
define PULSEAUDIO_USERS
--
2.15.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH] pulseaudio: remove the ConsoleKit module
2017-12-19 15:12 [Buildroot] [PATCH] pulseaudio: remove the ConsoleKit module Baruch Siach
@ 2017-12-19 20:46 ` Peter Korsgaard
2017-12-27 22:29 ` Peter Korsgaard
1 sibling, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2017-12-19 20:46 UTC (permalink / raw)
To: buildroot
>>>>> "Baruch" == Baruch Siach <baruch@tkos.co.il> writes:
> The ConsoleKit module is loaded by default from the default.pa
> configuration file, but its initialization fails because Buildroot has
> no ConsoleKit package yet. This breaks per-user pulseaudio daemon.
> The default.pa configuration load module-console-kit only when it
> exists. Remove module-console-kit to fix pulseaudio per-user startup.
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
Committed, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH] pulseaudio: remove the ConsoleKit module
2017-12-19 15:12 [Buildroot] [PATCH] pulseaudio: remove the ConsoleKit module Baruch Siach
2017-12-19 20:46 ` Peter Korsgaard
@ 2017-12-27 22:29 ` Peter Korsgaard
1 sibling, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2017-12-27 22:29 UTC (permalink / raw)
To: buildroot
>>>>> "Baruch" == Baruch Siach <baruch@tkos.co.il> writes:
> The ConsoleKit module is loaded by default from the default.pa
> configuration file, but its initialization fails because Buildroot has
> no ConsoleKit package yet. This breaks per-user pulseaudio daemon.
> The default.pa configuration load module-console-kit only when it
> exists. Remove module-console-kit to fix pulseaudio per-user startup.
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
Committed to 2017.11.x, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-12-27 22:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-12-19 15:12 [Buildroot] [PATCH] pulseaudio: remove the ConsoleKit module Baruch Siach
2017-12-19 20:46 ` Peter Korsgaard
2017-12-27 22:29 ` Peter Korsgaard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox