Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] manual: correct error in github tarball information
Date: Fri, 07 Jun 2013 10:50:23 +0200	[thread overview]
Message-ID: <8761xqe240.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <CAHXCMMJvKUMmoXRet-Zo+D1fbzSrwpk0gswE45nnCenJEGxHNw@mail.gmail.com> (Samuel Martin's message of "Fri, 7 Jun 2013 10:25:29 +0200")

>>>>> "Samuel" == Samuel Martin <s.martin49@gmail.com> writes:

 >> ------------------------
 >> FOO_VERSION = 1234567
 >> -FOO_SITE = http://github.com/<user>/<package>/tarball/<branch>
 >> +FOO_SITE = http://github.com/<user>/<package>/tarball/$(FOO_VERSION)
 >> ------------------------

 Samuel> I'd have slightly reword the whole section, since there is no
 Samuel> difference between FOO_VERSION being a tag or a commit id,
 Samuel> something like this:

 Samuel> ---
 Samuel> ------------------------
 Samuel> FOO_VERSION = v1.0 # tag or commit ID
 Samuel> FOO_SITE = http://github.com/<user>/<package>/tarball/$(FOO_VERSION)
 Samuel> ------------------------

 Samuel> .Notes
 Samuel> - The FOO_VERSION can either be a tag or a commit ID.
 Samuel> - The tarball name generated by github matches the default one from
 Samuel> Buildroot (e.g.: +foo-1234567.tar.gz+),
 Samuel> so it is not necessary to specify it in the +.mk+ file.
 Samuel> - When using a commit ID as version, usually the first 7 characters of
 Samuel> the SHA1 are enough.

Agreed. I've fixed this in git now, thanks.

-- 
Bye, Peter Korsgaard

  reply	other threads:[~2013-06-07  8:50 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-06  1:40 [Buildroot] [Bug 6302] New: Versions of packages retrieved from github.com are wrong bugzilla at busybox.net
2013-06-06 16:47 ` [Buildroot] [PATCH 01/14] jsmin: fix github tarball to use commit id Spenser Gilliland
2013-06-06 16:47   ` [Buildroot] [PATCH 02/14] libcofi: " Spenser Gilliland
2013-06-06 16:47   ` [Buildroot] [PATCH 03/14] linenoise: " Spenser Gilliland
2013-06-06 16:47   ` [Buildroot] [PATCH 04/14] lua-msgpack-native: " Spenser Gilliland
2013-06-06 17:42     ` Yann E. MORIN
2013-06-06 18:12       ` Spenser Gilliland
2013-06-06 16:47   ` [Buildroot] [PATCH 05/14] mtdev2tuio: " Spenser Gilliland
2013-06-06 16:47   ` [Buildroot] [PATCH 06/14] ne10: " Spenser Gilliland
2013-06-06 16:47   ` [Buildroot] [PATCH 07/14] omap-u-boot-utils: " Spenser Gilliland
2013-06-06 16:47   ` [Buildroot] [PATCH 08/14] rpi-firmware: " Spenser Gilliland
2013-06-06 16:47   ` [Buildroot] [PATCH 09/14] rpi-userland: " Spenser Gilliland
2013-06-06 16:47   ` [Buildroot] [PATCH 10/14] socketcand: " Spenser Gilliland
2013-06-06 16:47   ` [Buildroot] [PATCH 11/14] sunxi-boards: " Spenser Gilliland
2013-06-06 16:47   ` [Buildroot] [PATCH 12/14] sunxi-tools: " Spenser Gilliland
2013-06-06 16:47   ` [Buildroot] [PATCH 13/14] ti-utils: " Spenser Gilliland
2013-06-06 16:47   ` [Buildroot] [PATCH 14/14] tslib: " Spenser Gilliland
2013-06-06 18:56   ` [Buildroot] [PATCH 01/14] jsmin: " Samuel Martin
2013-06-06 21:09   ` Peter Korsgaard
2013-06-06 16:51 ` [Buildroot] [Bug 6302] New: Versions of packages retrieved from github.com are wrong Spenser Gilliland
2013-06-06 21:14 ` [Buildroot] [Bug 6302] " bugzilla at busybox.net
2013-06-06 23:44 ` bugzilla at busybox.net
2013-06-07  0:03   ` [Buildroot] [PATCH 1/1] manual: correct error in github tarball information Spenser Gilliland
2013-06-07  8:25     ` Samuel Martin
2013-06-07  8:50       ` Peter Korsgaard [this message]
2013-06-07  8:50     ` Peter Korsgaard
2013-06-07  8:54 ` [Buildroot] [Bug 6302] Versions of packages retrieved from github.com are wrong bugzilla at busybox.net
2013-06-07 10:58 ` bugzilla at busybox.net
2013-06-10  3:46 ` bugzilla at busybox.net

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8761xqe240.fsf@dell.be.48ers.dk \
    --to=jacmet@uclibc.org \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox