[Buildroot] error building alsa-utils

[Buildroot] error building alsa-utils

[Will Wagner]

Hi All,

I have just checked out the trunk and am doing an ARM build with alsa-utils.

Have run into a couple of problems. The first is that it does not compile with 
SUSV3_LEGACY disabled due to the use of index & rindex. Have a patch that fixes that.

The second problem I have is it appears to be trying to install the manual pages and is 
failing when trying to use xmlto command. I want to configure it to not build/install the 
man pages but I can't spot a configure option to do so. Am I missing something obvious? If 
not how do you suggest fixing this?

Thanks,

Will.
-- 
------------------------------------------------------------------------
Will Wagner                                     will_wagner at carallon.com
Development Manager                      Office Tel: +44 (0)20 7371 2032
Carallon Ltd, Studio G20, Shepherds Building, Rockley Rd, London W14 0DA
------------------------------------------------------------------------

[Buildroot] error building alsa-utils

[Peter Korsgaard]

>>>>> "Will" == Will Wagner <will_wagner@carallon.com> writes:

 Will> Hi All,

 Will> I have just checked out the trunk and am doing an ARM build
 Will> with alsa-utils.

 Will> Have run into a couple of problems. The first is that it does
 Will> not compile with SUSV3_LEGACY disabled due to the use of index
 Will> & rindex. Have a patch that fixes that.

Ah yes, thats fairly common. Please send the patch to the list and
I'll apply it - Also don't forget to send it to the alsa people!

 Will> The second problem I have is it appears to be trying to install
 Will> the manual pages and is failing when trying to use xmlto
 Will> command. I want to configure it to not build/install the man
 Will> pages but I can't spot a configure option to do so. Am I
 Will> missing something obvious? If not how do you suggest fixing
 Will> this?

Well, if everything else fails, you can always patch the
Makefile.in's.

-- 
Bye, Peter Korsgaard

[Buildroot] error building alsa-utils

[Will Wagner]

> 
> Ah yes, thats fairly common. Please send the patch to the list and
> I'll apply it - Also don't forget to send it to the alsa people!

Attached is patch, have also mailed alsa-devel

> 
>  Will> The second problem I have is it appears to be trying to install
>  Will> the manual pages and is failing when trying to use xmlto
>  Will> command. I want to configure it to not build/install the man
>  Will> pages but I can't spot a configure option to do so. Am I
>  Will> missing something obvious? If not how do you suggest fixing
>  Will> this?
> 
> Well, if everything else fails, you can always patch the
> Makefile.in's.

Have fixed by patching Makefile.in. I also realise that if I had xmlto on my build machine 
it would not be a problem.

Will.


-- 
------------------------------------------------------------------------
Will Wagner                                     will_wagner at carallon.com
Development Manager                      Office Tel: +44 (0)20 7371 2032
Carallon Ltd, Studio G20, Shepherds Building, Rockley Rd, London W14 0DA
------------------------------------------------------------------------
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: alsa-utils-1.0.18-fix_sysv_legacy.patch
Url: http://lists.busybox.net/pipermail/buildroot/attachments/20090115/4bd77251/attachment.diff 
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: alsa-utils-1.0.18-remove_man.patch
Url: http://lists.busybox.net/pipermail/buildroot/attachments/20090115/4bd77251/attachment-0001.diff 

[Buildroot] error building alsa-utils

[Ulf Samuelsson]

tor 2009-01-15 klockan 11:13 +0000 skrev Will Wagner:
> > 
> > Ah yes, thats fairly common. Please send the patch to the list and
> > I'll apply it - Also don't forget to send it to the alsa people!
> 
> Attached is patch, have also mailed alsa-devel
> 
Alsa-utils fails for me when I run buildall.sh so 
I will put the stuff in the alsa-utils directory and rerun.


BR
Ulf Samuelsson

> > 
> >  Will> The second problem I have is it appears to be trying to install
> >  Will> the manual pages and is failing when trying to use xmlto
> >  Will> command. I want to configure it to not build/install the man
> >  Will> pages but I can't spot a configure option to do so. Am I
> >  Will> missing something obvious? If not how do you suggest fixing
> >  Will> this?
> > 
> > Well, if everything else fails, you can always patch the
> > Makefile.in's.
> 
> Have fixed by patching Makefile.in. I also realise that if I had xmlto on my build machine 
> it would not be a problem.
> 
> Will.
> 
> 
> vanligt textdokument-bilaga (alsa-utils-1.0.18-fix_sysv_legacy.patch)
> --- a/alsactl/init_parse.c	2009-01-15 10:44:48.000000000 +0000
> +++ b/alsactl/init_parse.c	2009-01-15 10:46:41.000000000 +0000
> @@ -381,7 +381,7 @@ static int set_ctl_value(struct space *s
>  				snd_ctl_elem_value_set_integer(space->ctl_value, idx, val);
>  			} else if (items > 2 && value[items-2] == 'd' && value[items-1] == 'B') {
>  				val = strtol(value, NULL, 0) * 100;
> -				if ((pos2 = index(value, '.')) != NULL) {
> +				if ((pos2 = strchr(value, '.')) != NULL) {
>  					if (isdigit(*(pos2-1)) && isdigit(*(pos2-2))) {
>  						if (val < 0)
>  							val -= strtol(pos2 + 1, NULL, 0);
> @@ -1253,7 +1253,7 @@ static char *new_root_dir(const char *fi
>  
>  	res = strdup(filename);
>  	if (res) {
> -		tmp = rindex(res, '/');
> +		tmp = strrchr(res, '/');
>  		if (tmp)
>  			*tmp = '\0';
>  	}
> vanligt textdokument-bilaga (alsa-utils-1.0.18-remove_man.patch)
> --- a/alsactl/Makefile.in	2009-01-15 10:59:38.000000000 +0000
> +++ b/alsactl/Makefile.in	2009-01-15 10:59:34.000000000 +0000
> @@ -204,7 +204,7 @@ sharedstatedir = @sharedstatedir@
>  sysconfdir = @sysconfdir@
>  target_alias = @target_alias@
>  SUBDIRS = init
> -man_MANS = alsactl.1 alsactl_init.7
> +man_MANS = alsactl.1
>  EXTRA_DIST = alsactl.1 alsactl_init.xml
>  alsactl_SOURCES = alsactl.c state.c utils.c init_parse.c
>  noinst_HEADERS = alsactl.h list.h init_sysdeps.c init_utils_string.c init_utils_run.c init_sysfs.c
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

[Buildroot] error building alsa-utils

[Ulf Samuelsson]

tor 2009-01-15 klockan 21:33 +0100 skrev Ulf Samuelsson:
> tor 2009-01-15 klockan 11:13 +0000 skrev Will Wagner:
> > > 
> > > Ah yes, thats fairly common. Please send the patch to the list and
> > > I'll apply it - Also don't forget to send it to the alsa people!
> > 
> > Attached is patch, have also mailed alsa-devel
> > 
> Alsa-utils fails for me when I run buildall.sh so 
> I will put the stuff in the alsa-utils directory and rerun.
> 

OK so alsa-utils now compiles OK for ARM, 
It did not do so before the patch.

BR
Ulf Samuelsson

> 
> BR
> Ulf Samuelsson
> 
> > > 
> > >  Will> The second problem I have is it appears to be trying to install
> > >  Will> the manual pages and is failing when trying to use xmlto
> > >  Will> command. I want to configure it to not build/install the man
> > >  Will> pages but I can't spot a configure option to do so. Am I
> > >  Will> missing something obvious? If not how do you suggest fixing
> > >  Will> this?
> > > 
> > > Well, if everything else fails, you can always patch the
> > > Makefile.in's.
> > 
> > Have fixed by patching Makefile.in. I also realise that if I had xmlto on my build machine 
> > it would not be a problem.
> > 
> > Will.
> > 
> > 
> > vanligt textdokument-bilaga (alsa-utils-1.0.18-fix_sysv_legacy.patch)
> > --- a/alsactl/init_parse.c	2009-01-15 10:44:48.000000000 +0000
> > +++ b/alsactl/init_parse.c	2009-01-15 10:46:41.000000000 +0000
> > @@ -381,7 +381,7 @@ static int set_ctl_value(struct space *s
> >  				snd_ctl_elem_value_set_integer(space->ctl_value, idx, val);
> >  			} else if (items > 2 && value[items-2] == 'd' && value[items-1] == 'B') {
> >  				val = strtol(value, NULL, 0) * 100;
> > -				if ((pos2 = index(value, '.')) != NULL) {
> > +				if ((pos2 = strchr(value, '.')) != NULL) {
> >  					if (isdigit(*(pos2-1)) && isdigit(*(pos2-2))) {
> >  						if (val < 0)
> >  							val -= strtol(pos2 + 1, NULL, 0);
> > @@ -1253,7 +1253,7 @@ static char *new_root_dir(const char *fi
> >  
> >  	res = strdup(filename);
> >  	if (res) {
> > -		tmp = rindex(res, '/');
> > +		tmp = strrchr(res, '/');
> >  		if (tmp)
> >  			*tmp = '\0';
> >  	}
> > vanligt textdokument-bilaga (alsa-utils-1.0.18-remove_man.patch)
> > --- a/alsactl/Makefile.in	2009-01-15 10:59:38.000000000 +0000
> > +++ b/alsactl/Makefile.in	2009-01-15 10:59:34.000000000 +0000
> > @@ -204,7 +204,7 @@ sharedstatedir = @sharedstatedir@
> >  sysconfdir = @sysconfdir@
> >  target_alias = @target_alias@
> >  SUBDIRS = init
> > -man_MANS = alsactl.1 alsactl_init.7
> > +man_MANS = alsactl.1
> >  EXTRA_DIST = alsactl.1 alsactl_init.xml
> >  alsactl_SOURCES = alsactl.c state.c utils.c init_parse.c
> >  noinst_HEADERS = alsactl.h list.h init_sysdeps.c init_utils_string.c init_utils_run.c init_sysfs.c
> > _______________________________________________
> > buildroot mailing list
> > buildroot at busybox.net
> > http://lists.busybox.net/mailman/listinfo/buildroot
-- 
Best Regards,
Ulf Samuelsson          mail:   ulf at atmel.com
Atmel Nordic AB
Box 2033, 174 52 Sundbyberg
Kavalleriv?gen 24, 174 58 Sundbyberg
Sweden
Tel:    +46 8 441 54 22 GSM:    +46 706 224457

[Buildroot] error building alsa-utils

[Peter Korsgaard]

>>>>> "Ulf" == Ulf Samuelsson <ulf@atmel.com> writes:

Hi,

 >> Alsa-utils fails for me when I run buildall.sh so 
 >> I will put the stuff in the alsa-utils directory and rerun.
 >> 

 Ulf> OK so alsa-utils now compiles OK for ARM, 
 Ulf> It did not do so before the patch.

Please commit the patch then.

-- 
Bye, Peter Korsgaard

[Buildroot] error building alsa-utils

[Ulf Samuelsson]

tor 2009-01-15 klockan 22:51 +0100 skrev Peter Korsgaard:
> >>>>> "Ulf" == Ulf Samuelsson <ulf@atmel.com> writes:
> 
> Hi,
> 
>  >> Alsa-utils fails for me when I run buildall.sh so 
>  >> I will put the stuff in the alsa-utils directory and rerun.
>  >> 
> 
>  Ulf> OK so alsa-utils now compiles OK for ARM, 
>  Ulf> It did not do so before the patch.



> 
> Please commit the patch then.
> 

Plan to rebuild from scratch again, and will commit this
and other things like the requested libpython change,
but I do not expect problems.


-- 
Best Regards,
Ulf Samuelsson

[Buildroot] error building alsa-utils

[Sven Neumann]

Hi,

On Thu, 2009-01-15 at 21:33 +0100, Ulf Samuelsson wrote:
> tor 2009-01-15 klockan 11:13 +0000 skrev Will Wagner:
> > > 
> > > Ah yes, thats fairly common. Please send the patch to the list and
> > > I'll apply it - Also don't forget to send it to the alsa people!
> > 
> > Attached is patch, have also mailed alsa-devel
> > 
> Alsa-utils fails for me when I run buildall.sh so 
> I will put the stuff in the alsa-utils directory and rerun.

We have tested the patch that Will sent to the list. It seems to work
fine and we are now able to build without the legacy functions and
macros in uclibc. I suggest that the patch is included in buildroot.


Sven