Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/1] package/strace: add optional dependency to ncurses
@ 2026-11-15 17:46 Bernd Kuhls
  2026-11-15 18:50 ` Baruch Siach via buildroot
       [not found] ` <877biedj40.fsf__35447.6860187546$1794768661$gmane$org@tarshish>
  0 siblings, 2 replies; 3+ messages in thread
From: Bernd Kuhls @ 2026-11-15 17:46 UTC (permalink / raw)
  To: buildroot

Buildroot commit aa5e3eec6384cb73d902a4de3fffc279683ea5a5 bumped the
package to 7.0 which includes upstream commit
https://github.com/strace/strace/commit/19642150d613312dc4bed27695a83320dcd5133e
that adds optional support for ncurses.

There is no configure option to disable ncurses support so we need to
use ac_cv_search_tgetnum=no.

Configure during runtime test finds ncurses:
checking for termcap.h... yes
checking for library containing tgetnum... -lncurses

Configure log with this patch:
checking for termcap.h... yes
checking for library containing tgetnum... (cached) no

Fixes:
https://gitlab.com/buildroot.org/buildroot/-/jobs/18033158691

[BRTEST# strace --version
strace: error while loading shared libraries: libncurses.so.6: cannot
 open shared object file: No such file or directory

Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
---
 package/strace/strace.mk | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/package/strace/strace.mk b/package/strace/strace.mk
index 8eadb7eba4..97f2ddb6e5 100644
--- a/package/strace/strace.mk
+++ b/package/strace/strace.mk
@@ -19,6 +19,12 @@ else
 STRACE_CONF_OPTS += --without-libunwind
 endif
 
+ifeq ($(BR2_PACKAGE_NCURSES),y)
+STRACE_DEPENDENCIES += ncurses
+else
+STRACE_CONF_OPTS += ac_cv_search_tgetnum=no
+endif
+
 # Demangling symbols in stack trace needs libunwind and libiberty.
 ifeq ($(BR2_PACKAGE_BINUTILS)$(BR2_PACKAGE_LIBUNWIND),yy)
 STRACE_DEPENDENCIES += binutils
-- 
2.47.3

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [Buildroot] [PATCH 1/1] package/strace: add optional dependency to ncurses
  2026-11-15 17:46 [Buildroot] [PATCH 1/1] package/strace: add optional dependency to ncurses Bernd Kuhls
@ 2026-11-15 18:50 ` Baruch Siach via buildroot
       [not found] ` <877biedj40.fsf__35447.6860187546$1794768661$gmane$org@tarshish>
  1 sibling, 0 replies; 3+ messages in thread
From: Baruch Siach via buildroot @ 2026-11-15 18:50 UTC (permalink / raw)
  To: Bernd Kuhls; +Cc: buildroot

Hi Bernd,

Thanks for the patch.

One question below.

On Sun, Nov 15 2026, Bernd Kuhls wrote:
> Buildroot commit aa5e3eec6384cb73d902a4de3fffc279683ea5a5 bumped the
> package to 7.0 which includes upstream commit
> https://github.com/strace/strace/commit/19642150d613312dc4bed27695a83320dcd5133e
> that adds optional support for ncurses.
>
> There is no configure option to disable ncurses support so we need to
> use ac_cv_search_tgetnum=no.
>
> Configure during runtime test finds ncurses:
> checking for termcap.h... yes
> checking for library containing tgetnum... -lncurses

Do you have an idea how this symbol test found ncurses in CI test?

baruch

> Configure log with this patch:
> checking for termcap.h... yes
> checking for library containing tgetnum... (cached) no
>
> Fixes:
> https://gitlab.com/buildroot.org/buildroot/-/jobs/18033158691
>
> [BRTEST# strace --version
> strace: error while loading shared libraries: libncurses.so.6: cannot
>  open shared object file: No such file or directory
>
> Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
> ---
>  package/strace/strace.mk | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/package/strace/strace.mk b/package/strace/strace.mk
> index 8eadb7eba4..97f2ddb6e5 100644
> --- a/package/strace/strace.mk
> +++ b/package/strace/strace.mk
> @@ -19,6 +19,12 @@ else
>  STRACE_CONF_OPTS += --without-libunwind
>  endif
>  
> +ifeq ($(BR2_PACKAGE_NCURSES),y)
> +STRACE_DEPENDENCIES += ncurses
> +else
> +STRACE_CONF_OPTS += ac_cv_search_tgetnum=no
> +endif
> +
>  # Demangling symbols in stack trace needs libunwind and libiberty.
>  ifeq ($(BR2_PACKAGE_BINUTILS)$(BR2_PACKAGE_LIBUNWIND),yy)
>  STRACE_DEPENDENCIES += binutils

-- 
                                                     ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [Buildroot] [PATCH 1/1] package/strace: add optional dependency to ncurses
       [not found] ` <877biedj40.fsf__35447.6860187546$1794768661$gmane$org@tarshish>
@ 2026-11-15 19:31   ` Bernd Kuhls
  0 siblings, 0 replies; 3+ messages in thread
From: Bernd Kuhls @ 2026-11-15 19:31 UTC (permalink / raw)
  To: buildroot

Am Sun, 15 Nov 2026 20:50:39 +0200 schrieb Baruch Siach via buildroot:

> Do you have an idea how this symbol test found ncurses in CI test?

Hi Baruch,

yes, the docker image contains the necessary files:

$ find  output_folder/ -type f | grep "libncurses\|termcap"
output_folder/TestStrace/host/arm-buildroot-linux-gnueabi/sysroot/usr/lib/
libncurses.so.6.6
output_folder/TestStrace/host/arm-buildroot-linux-gnueabi/sysroot/usr/
include/termcap.h
output_folder/TestStrace/host/opt/ext-toolchain/lib/libncursesw.so.6.6
output_folder/TestStrace/host/opt/ext-toolchain/arm-buildroot-linux-
gnueabi/sysroot/usr/lib/libncurses.so.6.6
output_folder/TestStrace/host/opt/ext-toolchain/arm-buildroot-linux-
gnueabi/sysroot/usr/include/termcap.h

Regards, Bernd

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-11-15 19:32 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-15 17:46 [Buildroot] [PATCH 1/1] package/strace: add optional dependency to ncurses Bernd Kuhls
2026-11-15 18:50 ` Baruch Siach via buildroot
     [not found] ` <877biedj40.fsf__35447.6860187546$1794768661$gmane$org@tarshish>
2026-11-15 19:31   ` Bernd Kuhls

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox