* [Buildroot] [PATCH v2] configs/amarula_vyasa_rk3288_defconfig: bump to Linux version 6.1.91
@ 2024-05-22 19:46 Giulio Benetti
2024-05-24 21:15 ` Peter Korsgaard
0 siblings, 1 reply; 3+ messages in thread
From: Giulio Benetti @ 2024-05-22 19:46 UTC (permalink / raw)
To: buildroot; +Cc: Giulio Benetti, Jagan Teki
Build fails with gcc 13 with:
drivers/ata/libahci.c: In function 'ahci_led_store':
././include/linux/compiler_types.h:357:45: error: call to
'__compiletime_assert_302' declared with attribute error: BUILD_BUG_ON failed:
sizeof(_s) > sizeof(long)
357 | _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
As explained in Linux commit[0] that fixes the build, sizeof() of enum
like '(1<<31)' translate to a 64-bit type, but we expect a 32-bit type.
So commit[0] makes sure the data type to be 32-bits wide by using BIT()
macro.
Fixes:
https://gitlab.com/buildroot.org/buildroot/-/jobs/6865596548
[0]:
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=97e28deab8bfe70d5687650f94484f8f9101e566
Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
V1->V2:
* improve commit log as requested by Romain Naour
---
configs/amarula_vyasa_rk3288_defconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configs/amarula_vyasa_rk3288_defconfig b/configs/amarula_vyasa_rk3288_defconfig
index 7976537225..0dd47f498f 100644
--- a/configs/amarula_vyasa_rk3288_defconfig
+++ b/configs/amarula_vyasa_rk3288_defconfig
@@ -23,7 +23,7 @@ BR2_TARGET_UBOOT_SPL_NAME="spl/u-boot-spl-dtb.bin tpl/u-boot-tpl.bin"
# Kernel
BR2_LINUX_KERNEL=y
BR2_LINUX_KERNEL_CUSTOM_VERSION=y
-BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="6.1.2"
+BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="6.1.91"
BR2_LINUX_KERNEL_DEFCONFIG="multi_v7"
BR2_LINUX_KERNEL_UIMAGE=y
BR2_LINUX_KERNEL_UIMAGE_LOADADDR="0x02000000"
--
2.34.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Buildroot] [PATCH v2] configs/amarula_vyasa_rk3288_defconfig: bump to Linux version 6.1.91
2024-05-22 19:46 [Buildroot] [PATCH v2] configs/amarula_vyasa_rk3288_defconfig: bump to Linux version 6.1.91 Giulio Benetti
@ 2024-05-24 21:15 ` Peter Korsgaard
2024-05-24 22:15 ` Giulio Benetti
0 siblings, 1 reply; 3+ messages in thread
From: Peter Korsgaard @ 2024-05-24 21:15 UTC (permalink / raw)
To: Giulio Benetti; +Cc: Jagan Teki, buildroot
>>>>> "Giulio" == Giulio Benetti <giulio.benetti@benettiengineering.com> writes:
> Build fails with gcc 13 with:
> drivers/ata/libahci.c: In function 'ahci_led_store':
> ././include/linux/compiler_types.h:357:45: error: call to
> '__compiletime_assert_302' declared with attribute error: BUILD_BUG_ON failed:
> sizeof(_s) > sizeof(long)
> 357 | _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
> As explained in Linux commit[0] that fixes the build, sizeof() of enum
> like '(1<<31)' translate to a 64-bit type, but we expect a 32-bit type.
> So commit[0] makes sure the data type to be 32-bits wide by using BIT()
> macro.
> Fixes:
> https://gitlab.com/buildroot.org/buildroot/-/jobs/6865596548
> [0]:
> https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=97e28deab8bfe70d5687650f94484f8f9101e566
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> ---
> V1-> V2:
> * improve commit log as requested by Romain Naour
Committed, thanks.
Could you also send a patch adding download hashes for the defconfig
(see utils/add-custom-hashes)?
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Buildroot] [PATCH v2] configs/amarula_vyasa_rk3288_defconfig: bump to Linux version 6.1.91
2024-05-24 21:15 ` Peter Korsgaard
@ 2024-05-24 22:15 ` Giulio Benetti
0 siblings, 0 replies; 3+ messages in thread
From: Giulio Benetti @ 2024-05-24 22:15 UTC (permalink / raw)
To: Peter Korsgaard; +Cc: Jagan Teki, buildroot
On 24/05/24 23:15, Peter Korsgaard wrote:
>>>>>> "Giulio" == Giulio Benetti <giulio.benetti@benettiengineering.com> writes:
>
> > Build fails with gcc 13 with:
> > drivers/ata/libahci.c: In function 'ahci_led_store':
> > ././include/linux/compiler_types.h:357:45: error: call to
> > '__compiletime_assert_302' declared with attribute error: BUILD_BUG_ON failed:
> > sizeof(_s) > sizeof(long)
> > 357 | _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
>
> > As explained in Linux commit[0] that fixes the build, sizeof() of enum
> > like '(1<<31)' translate to a 64-bit type, but we expect a 32-bit type.
> > So commit[0] makes sure the data type to be 32-bits wide by using BIT()
> > macro.
>
> > Fixes:
> > https://gitlab.com/buildroot.org/buildroot/-/jobs/6865596548
>
> > [0]:
> > https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=97e28deab8bfe70d5687650f94484f8f9101e566
>
> > Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> > ---
> > V1-> V2:
> > * improve commit log as requested by Romain Naour
>
> Committed, thanks.
>
> Could you also send a patch adding download hashes for the defconfig
> (see utils/add-custom-hashes)?
>
Sure, here is the patch:
https://patchwork.ozlabs.org/project/buildroot/patch/20240524220421.710392-1-giulio.benetti@benettiengineering.com/
Best regards
--
Giulio Benetti
CEO&CTO@Benetti Engineering
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-05-24 22:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-05-22 19:46 [Buildroot] [PATCH v2] configs/amarula_vyasa_rk3288_defconfig: bump to Linux version 6.1.91 Giulio Benetti
2024-05-24 21:15 ` Peter Korsgaard
2024-05-24 22:15 ` Giulio Benetti
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox