* [Buildroot] [PATCH] package/pipewire: fix webrtc-audio-processing condition
@ 2024-01-10 20:51 Thomas Petazzoni via buildroot
2024-01-13 21:08 ` Peter Korsgaard
2024-01-14 16:39 ` Peter Korsgaard
0 siblings, 2 replies; 3+ messages in thread
From: Thomas Petazzoni via buildroot @ 2024-01-10 20:51 UTC (permalink / raw)
To: Buildroot List; +Cc: James Hilliard, Fabrice Fontaine, Thomas Petazzoni
The condition checking whether the webrtc-audio-processing package is
enabled, added in commit
3ccd3b4c384e98703841b12f7309362957f8f17d ("package/pipewire: bump to
version 0.3.32") is obviously incorrect, and can never be true.
Fix the condition to use the correct variable instead.
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
---
package/pipewire/pipewire.mk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/package/pipewire/pipewire.mk b/package/pipewire/pipewire.mk
index 628c69ff8a..f0f3cd847c 100644
--- a/package/pipewire/pipewire.mk
+++ b/package/pipewire/pipewire.mk
@@ -225,7 +225,7 @@ else
PIPEWIRE_CONF_OPTS += -Dcompress-offload=disabled
endif
-ifeq ($(WEBRTC_AUDIO_PROCESSING),y)
+ifeq ($(BR2_PACKAGE_WEBRTC_AUDIO_PROCESSING),y)
PIPEWIRE_CONF_OPTS += -Decho-cancel-webrtc=enabled
PIPEWIRE_DEPENDENCIES += webrtc-audio-processing
else
--
2.43.0
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Buildroot] [PATCH] package/pipewire: fix webrtc-audio-processing condition
2024-01-10 20:51 [Buildroot] [PATCH] package/pipewire: fix webrtc-audio-processing condition Thomas Petazzoni via buildroot
@ 2024-01-13 21:08 ` Peter Korsgaard
2024-01-14 16:39 ` Peter Korsgaard
1 sibling, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2024-01-13 21:08 UTC (permalink / raw)
To: Thomas Petazzoni via buildroot
Cc: James Hilliard, Fabrice Fontaine, Thomas Petazzoni
>>>>> "Thomas" == Thomas Petazzoni via buildroot <buildroot@buildroot.org> writes:
> The condition checking whether the webrtc-audio-processing package is
> enabled, added in commit
> 3ccd3b4c384e98703841b12f7309362957f8f17d ("package/pipewire: bump to
> version 0.3.32") is obviously incorrect, and can never be true.
> Fix the condition to use the correct variable instead.
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Committed, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Buildroot] [PATCH] package/pipewire: fix webrtc-audio-processing condition
2024-01-10 20:51 [Buildroot] [PATCH] package/pipewire: fix webrtc-audio-processing condition Thomas Petazzoni via buildroot
2024-01-13 21:08 ` Peter Korsgaard
@ 2024-01-14 16:39 ` Peter Korsgaard
1 sibling, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2024-01-14 16:39 UTC (permalink / raw)
To: Thomas Petazzoni via buildroot
Cc: James Hilliard, Fabrice Fontaine, Thomas Petazzoni
>>>>> "Thomas" == Thomas Petazzoni via buildroot <buildroot@buildroot.org> writes:
> The condition checking whether the webrtc-audio-processing package is
> enabled, added in commit
> 3ccd3b4c384e98703841b12f7309362957f8f17d ("package/pipewire: bump to
> version 0.3.32") is obviously incorrect, and can never be true.
> Fix the condition to use the correct variable instead.
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Committed to 2023.02.x and 2023.11.x, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-01-14 16:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-01-10 20:51 [Buildroot] [PATCH] package/pipewire: fix webrtc-audio-processing condition Thomas Petazzoni via buildroot
2024-01-13 21:08 ` Peter Korsgaard
2024-01-14 16:39 ` Peter Korsgaard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox