Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/1] package/zabbix: add missing BR2_OPTIMIZE_FAST
@ 2023-10-15 21:22 Fabrice Fontaine
  2023-11-02 18:05 ` Thomas Petazzoni via buildroot
  2023-11-08 13:41 ` Peter Korsgaard
  0 siblings, 2 replies; 3+ messages in thread
From: Fabrice Fontaine @ 2023-10-15 21:22 UTC (permalink / raw)
  To: buildroot; +Cc: Alexey Lukyanchuk, Fabrice Fontaine

Add missing BR2_OPTIMIZE_FAST dependency to BR2_PACKAGE_ZABBIX_SERVER
to avoid the following build failure raised since commit
e702a05d8998a1f2416225eb62b43b6585738fe9:

checking for Zabbix server/proxy database selection... error
configure: error: No database selected for Zabbix server/proxy. Use --with-mysql or --with-oracle or --with-postgresql or --with-sqlite3.

Fixes:
 - http://autobuild.buildroot.org/results/ab403b45761c82f49a9380564bf10d3e7ae935f2

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/zabbix/Config.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/zabbix/Config.in b/package/zabbix/Config.in
index 377c0ff692..af677f782e 100644
--- a/package/zabbix/Config.in
+++ b/package/zabbix/Config.in
@@ -26,7 +26,7 @@ config BR2_PACKAGE_ZABBIX_SERVER
 	depends on BR2_USE_MMU # mysql, postgresql
 	depends on \
 		(BR2_INSTALL_LIBSTDCPP && BR2_TOOLCHAIN_HAS_THREADS) || \
-		(BR2_USE_WCHAR && !BR2_STATIC_LIBS)
+		(BR2_USE_WCHAR && !BR2_STATIC_LIBS && !BR2_OPTIMIZE_FAST)
 	select BR2_PACKAGE_ZLIB
 	select BR2_PACKAGE_LIBEVENT
 
-- 
2.42.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [Buildroot] [PATCH 1/1] package/zabbix: add missing BR2_OPTIMIZE_FAST
  2023-10-15 21:22 [Buildroot] [PATCH 1/1] package/zabbix: add missing BR2_OPTIMIZE_FAST Fabrice Fontaine
@ 2023-11-02 18:05 ` Thomas Petazzoni via buildroot
  2023-11-08 13:41 ` Peter Korsgaard
  1 sibling, 0 replies; 3+ messages in thread
From: Thomas Petazzoni via buildroot @ 2023-11-02 18:05 UTC (permalink / raw)
  To: Fabrice Fontaine; +Cc: Alexey Lukyanchuk, buildroot

On Sun, 15 Oct 2023 23:22:42 +0200
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> Add missing BR2_OPTIMIZE_FAST dependency to BR2_PACKAGE_ZABBIX_SERVER
> to avoid the following build failure raised since commit
> e702a05d8998a1f2416225eb62b43b6585738fe9:
> 
> checking for Zabbix server/proxy database selection... error
> configure: error: No database selected for Zabbix server/proxy. Use --with-mysql or --with-oracle or --with-postgresql or --with-sqlite3.
> 
> Fixes:
>  - http://autobuild.buildroot.org/results/ab403b45761c82f49a9380564bf10d3e7ae935f2
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  package/zabbix/Config.in | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Good catch, applied to master. I must say I really hate the fact that
these dependencies must be duplicated between the main
BR2_PACKAGE_ZABBIX_SERVER option and the sub-options to select
mysql/postgresql backends.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [Buildroot] [PATCH 1/1] package/zabbix: add missing BR2_OPTIMIZE_FAST
  2023-10-15 21:22 [Buildroot] [PATCH 1/1] package/zabbix: add missing BR2_OPTIMIZE_FAST Fabrice Fontaine
  2023-11-02 18:05 ` Thomas Petazzoni via buildroot
@ 2023-11-08 13:41 ` Peter Korsgaard
  1 sibling, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2023-11-08 13:41 UTC (permalink / raw)
  To: Fabrice Fontaine; +Cc: Alexey Lukyanchuk, buildroot

>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:

 > Add missing BR2_OPTIMIZE_FAST dependency to BR2_PACKAGE_ZABBIX_SERVER
 > to avoid the following build failure raised since commit
 > e702a05d8998a1f2416225eb62b43b6585738fe9:

 > checking for Zabbix server/proxy database selection... error
 > configure: error: No database selected for Zabbix server/proxy. Use
 > --with-mysql or --with-oracle or --with-postgresql or --with-sqlite3.

 > Fixes:
 >  - http://autobuild.buildroot.org/results/ab403b45761c82f49a9380564bf10d3e7ae935f2

 > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

Committed to 2023.02.x and 2023.08.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-11-08 13:41 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-15 21:22 [Buildroot] [PATCH 1/1] package/zabbix: add missing BR2_OPTIMIZE_FAST Fabrice Fontaine
2023-11-02 18:05 ` Thomas Petazzoni via buildroot
2023-11-08 13:41 ` Peter Korsgaard

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox