* [Buildroot] [PATCH 1/2] package/zlib-ng: drop unrecognized CC variable
@ 2020-10-11 19:43 Fabrice Fontaine
2020-10-11 19:43 ` [Buildroot] [PATCH 2/2] package/zlib-ng: disable tests Fabrice Fontaine
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Fabrice Fontaine @ 2020-10-11 19:43 UTC (permalink / raw)
To: buildroot
Drop unneeded CC variable which is not recognized by cmake:
CMake Warning:
Manually-specified variables were not used by the project:
BUILD_DOC
BUILD_DOCS
BUILD_EXAMPLE
BUILD_EXAMPLES
BUILD_TEST
BUILD_TESTING
BUILD_TESTS
CC
Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
package/zlib-ng/zlib-ng.mk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/package/zlib-ng/zlib-ng.mk b/package/zlib-ng/zlib-ng.mk
index 098dfcb28a..3b27574a79 100644
--- a/package/zlib-ng/zlib-ng.mk
+++ b/package/zlib-ng/zlib-ng.mk
@@ -12,7 +12,7 @@ ZLIB_NG_INSTALL_STAGING = YES
ZLIB_NG_PROVIDES = zlib
# Build with zlib compatible API, gzFile support and optimizations on
-ZLIB_NG_CONF_OPTS += -DZLIB_COMPAT=1 -DWITH_GZFILEOP=1 -DWITH_OPTIM=1 -DCC=$(TARGET_CC)
+ZLIB_NG_CONF_OPTS += -DZLIB_COMPAT=1 -DWITH_GZFILEOP=1 -DWITH_OPTIM=1
# Enable NEON and ACLE on ARM
ifeq ($(BR2_arm),y)
--
2.28.0
^ permalink raw reply related [flat|nested] 5+ messages in thread* [Buildroot] [PATCH 2/2] package/zlib-ng: disable tests
2020-10-11 19:43 [Buildroot] [PATCH 1/2] package/zlib-ng: drop unrecognized CC variable Fabrice Fontaine
@ 2020-10-11 19:43 ` Fabrice Fontaine
2020-10-12 8:09 ` Peter Korsgaard
2020-10-11 20:57 ` [Buildroot] [PATCH 1/2] package/zlib-ng: drop unrecognized CC variable Thomas Petazzoni
2020-10-12 8:09 ` Peter Korsgaard
2 siblings, 1 reply; 5+ messages in thread
From: Fabrice Fontaine @ 2020-10-11 19:43 UTC (permalink / raw)
To: buildroot
Tests are enabled by default and can be disabled since
https://github.com/zlib-ng/zlib-ng/commit/b0730d030a9ce5c53faa88bd8259c9afccce6881
Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
package/zlib-ng/zlib-ng.mk | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/package/zlib-ng/zlib-ng.mk b/package/zlib-ng/zlib-ng.mk
index 3b27574a79..1cb00d075b 100644
--- a/package/zlib-ng/zlib-ng.mk
+++ b/package/zlib-ng/zlib-ng.mk
@@ -12,7 +12,11 @@ ZLIB_NG_INSTALL_STAGING = YES
ZLIB_NG_PROVIDES = zlib
# Build with zlib compatible API, gzFile support and optimizations on
-ZLIB_NG_CONF_OPTS += -DZLIB_COMPAT=1 -DWITH_GZFILEOP=1 -DWITH_OPTIM=1
+ZLIB_NG_CONF_OPTS += \
+ -DWITH_GZFILEOP=1 \
+ -DWITH_OPTIM=1 \
+ -DZLIB_COMPAT=1 \
+ -DZLIB_ENABLE_TESTS=OFF
# Enable NEON and ACLE on ARM
ifeq ($(BR2_arm),y)
--
2.28.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH 1/2] package/zlib-ng: drop unrecognized CC variable
2020-10-11 19:43 [Buildroot] [PATCH 1/2] package/zlib-ng: drop unrecognized CC variable Fabrice Fontaine
2020-10-11 19:43 ` [Buildroot] [PATCH 2/2] package/zlib-ng: disable tests Fabrice Fontaine
@ 2020-10-11 20:57 ` Thomas Petazzoni
2020-10-12 8:09 ` Peter Korsgaard
2 siblings, 0 replies; 5+ messages in thread
From: Thomas Petazzoni @ 2020-10-11 20:57 UTC (permalink / raw)
To: buildroot
On Sun, 11 Oct 2020 21:43:56 +0200
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
> Drop unneeded CC variable which is not recognized by cmake:
>
> CMake Warning:
> Manually-specified variables were not used by the project:
>
> BUILD_DOC
> BUILD_DOCS
> BUILD_EXAMPLE
> BUILD_EXAMPLES
> BUILD_TEST
> BUILD_TESTING
> BUILD_TESTS
> CC
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> package/zlib-ng/zlib-ng.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Both applied to master. Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH 1/2] package/zlib-ng: drop unrecognized CC variable
2020-10-11 19:43 [Buildroot] [PATCH 1/2] package/zlib-ng: drop unrecognized CC variable Fabrice Fontaine
2020-10-11 19:43 ` [Buildroot] [PATCH 2/2] package/zlib-ng: disable tests Fabrice Fontaine
2020-10-11 20:57 ` [Buildroot] [PATCH 1/2] package/zlib-ng: drop unrecognized CC variable Thomas Petazzoni
@ 2020-10-12 8:09 ` Peter Korsgaard
2 siblings, 0 replies; 5+ messages in thread
From: Peter Korsgaard @ 2020-10-12 8:09 UTC (permalink / raw)
To: buildroot
>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:
> Drop unneeded CC variable which is not recognized by cmake:
> CMake Warning:
> Manually-specified variables were not used by the project:
> BUILD_DOC
> BUILD_DOCS
> BUILD_EXAMPLE
> BUILD_EXAMPLES
> BUILD_TEST
> BUILD_TESTING
> BUILD_TESTS
> CC
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Committed to 2020.08.x, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-10-12 8:09 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-10-11 19:43 [Buildroot] [PATCH 1/2] package/zlib-ng: drop unrecognized CC variable Fabrice Fontaine
2020-10-11 19:43 ` [Buildroot] [PATCH 2/2] package/zlib-ng: disable tests Fabrice Fontaine
2020-10-12 8:09 ` Peter Korsgaard
2020-10-11 20:57 ` [Buildroot] [PATCH 1/2] package/zlib-ng: drop unrecognized CC variable Thomas Petazzoni
2020-10-12 8:09 ` Peter Korsgaard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox