[Buildroot] [PATCH 0/2] i2c-tools: license and staging installation fixes

[Buildroot] [PATCH 0/2] i2c-tools: license and staging installation fixes

[Brad Love]

Patch 1/2 updates i2c-tools.mk to include the LGPL-2.1+ license which
applies to the library libi2c.

Patch 2/2 enables staging installation, using make targets to install
the header and dynamic or static library for use by external packages.


Brad Love (2):
  i2c-tools: include LGPL-2.1+ license for libi2c
  i2c-tools: install library and header to staging

 package/i2c-tools/i2c-tools.mk | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

-- 
2.7.4

[Buildroot] [PATCH 1/2] i2c-tools: include LGPL-2.1+ license for libi2c

[Brad Love]

Extend i2c-tools SPDX identifiers to include the library license.

The ic2-tools readme states:

LICENSE

Check the documentation of individual tools for licensing information.
The library is released under the LGPL version 2.1 or later, while most
tools are released under the GPL version 2 or later, but there are a few
exceptions.


Signed-off-by: Brad Love <brad@nextdimension.cc>
---
 package/i2c-tools/i2c-tools.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/i2c-tools/i2c-tools.mk b/package/i2c-tools/i2c-tools.mk
index db26647..a346698 100644
--- a/package/i2c-tools/i2c-tools.mk
+++ b/package/i2c-tools/i2c-tools.mk
@@ -7,7 +7,7 @@
 I2C_TOOLS_VERSION = 4.0
 I2C_TOOLS_SOURCE = i2c-tools-$(I2C_TOOLS_VERSION).tar.xz
 I2C_TOOLS_SITE = https://www.kernel.org/pub/software/utils/i2c-tools
-I2C_TOOLS_LICENSE = GPL-2.0+, GPL-2.0 (py-smbus)
+I2C_TOOLS_LICENSE = GPL-2.0+, GPL-2.0 (py-smbus), LGPL-2.1+ (libi2c)
 I2C_TOOLS_LICENSE_FILES = COPYING
 I2C_TOOLS_MAKE_OPTS = EXTRA=eeprog
 
-- 
2.7.4

[Buildroot] [PATCH 1/2] i2c-tools: include LGPL-2.1+ license for libi2c

[Yann E. MORIN]

Brad, All,

On 2018-08-23 15:20 -0500, Brad Love spake thusly:
> Extend i2c-tools SPDX identifiers to include the library license.
> 
> The ic2-tools readme states:
> 
> LICENSE
> 
> Check the documentation of individual tools for licensing information.
> The library is released under the LGPL version 2.1 or later, while most
> tools are released under the GPL version 2 or later, but there are a few
> exceptions.
> 
> 
> Signed-off-by: Brad Love <brad@nextdimension.cc>

Acked-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

Regards,
Yann E. MORIN.

> ---
>  package/i2c-tools/i2c-tools.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/package/i2c-tools/i2c-tools.mk b/package/i2c-tools/i2c-tools.mk
> index db26647..a346698 100644
> --- a/package/i2c-tools/i2c-tools.mk
> +++ b/package/i2c-tools/i2c-tools.mk
> @@ -7,7 +7,7 @@
>  I2C_TOOLS_VERSION = 4.0
>  I2C_TOOLS_SOURCE = i2c-tools-$(I2C_TOOLS_VERSION).tar.xz
>  I2C_TOOLS_SITE = https://www.kernel.org/pub/software/utils/i2c-tools
> -I2C_TOOLS_LICENSE = GPL-2.0+, GPL-2.0 (py-smbus)
> +I2C_TOOLS_LICENSE = GPL-2.0+, GPL-2.0 (py-smbus), LGPL-2.1+ (libi2c)
>  I2C_TOOLS_LICENSE_FILES = COPYING
>  I2C_TOOLS_MAKE_OPTS = EXTRA=eeprog
>  
> -- 
> 2.7.4
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

[Buildroot] [PATCH 1/2] i2c-tools: include LGPL-2.1+ license for libi2c

[Baruch Siach]

Hi Brad,

Brad Love writes:
> Extend i2c-tools SPDX identifiers to include the library license.
>
> The ic2-tools readme states:
>
> LICENSE
>
> Check the documentation of individual tools for licensing information.
> The library is released under the LGPL version 2.1 or later, while most
> tools are released under the GPL version 2 or later, but there are a few
> exceptions.
>
>
> Signed-off-by: Brad Love <brad@nextdimension.cc>
> ---
>  package/i2c-tools/i2c-tools.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/package/i2c-tools/i2c-tools.mk b/package/i2c-tools/i2c-tools.mk
> index db26647..a346698 100644
> --- a/package/i2c-tools/i2c-tools.mk
> +++ b/package/i2c-tools/i2c-tools.mk
> @@ -7,7 +7,7 @@
>  I2C_TOOLS_VERSION = 4.0
>  I2C_TOOLS_SOURCE = i2c-tools-$(I2C_TOOLS_VERSION).tar.xz
>  I2C_TOOLS_SITE = https://www.kernel.org/pub/software/utils/i2c-tools
> -I2C_TOOLS_LICENSE = GPL-2.0+, GPL-2.0 (py-smbus)
> +I2C_TOOLS_LICENSE = GPL-2.0+, GPL-2.0 (py-smbus), LGPL-2.1+ (libi2c)
>  I2C_TOOLS_LICENSE_FILES = COPYING

Please add COPYING.LGPL here as well. And while you are at it, I think
adding README would also be good.

>  I2C_TOOLS_MAKE_OPTS = EXTRA=eeprog

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -

[Buildroot] [PATCH 1/2] i2c-tools: include LGPL-2.1+ license for libi2c

[Brad Love]

Hi Baruch,


On 2018-08-23 23:25, Baruch Siach wrote:
> Hi Brad,
>
> Brad Love writes:
>> Extend i2c-tools SPDX identifiers to include the library license.
>>
>> The ic2-tools readme states:
>>
>> LICENSE
>>
>> Check the documentation of individual tools for licensing information.
>> The library is released under the LGPL version 2.1 or later, while most
>> tools are released under the GPL version 2 or later, but there are a few
>> exceptions.
>>
>>
>> Signed-off-by: Brad Love <brad@nextdimension.cc>
>> ---
>>  package/i2c-tools/i2c-tools.mk | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/package/i2c-tools/i2c-tools.mk b/package/i2c-tools/i2c-tools.mk
>> index db26647..a346698 100644
>> --- a/package/i2c-tools/i2c-tools.mk
>> +++ b/package/i2c-tools/i2c-tools.mk
>> @@ -7,7 +7,7 @@
>>  I2C_TOOLS_VERSION = 4.0
>>  I2C_TOOLS_SOURCE = i2c-tools-$(I2C_TOOLS_VERSION).tar.xz
>>  I2C_TOOLS_SITE = https://www.kernel.org/pub/software/utils/i2c-tools
>> -I2C_TOOLS_LICENSE = GPL-2.0+, GPL-2.0 (py-smbus)
>> +I2C_TOOLS_LICENSE = GPL-2.0+, GPL-2.0 (py-smbus), LGPL-2.1+ (libi2c)
>>  I2C_TOOLS_LICENSE_FILES = COPYING
> Please add COPYING.LGPL here as well. And while you are at it, I think
> adding README would also be good.

Done, v3 has been submitted. Apologies for the omission.

Cheers,

Brad


>>  I2C_TOOLS_MAKE_OPTS = EXTRA=eeprog
> baruch
>

[Buildroot] [PATCH 2/2] i2c-tools: install library and header to staging

[Brad Love]

When the dynamic/static library of i2c-tools is enabled it is installed
to the target destination. However, in order for external packages to
link against it, it must also be installed to staging.

Here, the flag is set to install the package to staging. The
INSTALL_STAGING command is included to only install the library
and header file in order to utilize libi2c externally. The make
targets are used for the installation to accomodate whether static
or dynamic library was selected during configuration.


Signed-off-by: Brad Love <brad@nextdimension.cc>
---
 package/i2c-tools/i2c-tools.mk | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/package/i2c-tools/i2c-tools.mk b/package/i2c-tools/i2c-tools.mk
index a346698..c571056 100644
--- a/package/i2c-tools/i2c-tools.mk
+++ b/package/i2c-tools/i2c-tools.mk
@@ -10,6 +10,7 @@ I2C_TOOLS_SITE = https://www.kernel.org/pub/software/utils/i2c-tools
 I2C_TOOLS_LICENSE = GPL-2.0+, GPL-2.0 (py-smbus), LGPL-2.1+ (library)
 I2C_TOOLS_LICENSE_FILES = COPYING
 I2C_TOOLS_MAKE_OPTS = EXTRA=eeprog
+I2C_TOOLS_INSTALL_STAGING = YES
 
 ifeq ($(BR2_PACKAGE_PYTHON),y)
 I2C_TOOLS_DEPENDENCIES += python
@@ -62,4 +63,11 @@ define I2C_TOOLS_INSTALL_TARGET_CMDS
 	$(I2C_TOOLS_INSTALL_PYSMBUS)
 endef
 
+define I2C_TOOLS_INSTALL_STAGING_CMDS
+	$(MAKE) $(TARGET_CONFIGURE_OPTS) $(I2C_TOOLS_MAKE_OPTS) \
+		DESTDIR="$(STAGING_DIR)" prefix=/usr -C $(@D) install-lib
+	$(MAKE) $(TARGET_CONFIGURE_OPTS) $(I2C_TOOLS_MAKE_OPTS) \
+		DESTDIR="$(STAGING_DIR)" prefix=/usr -C $(@D) install-include
+endef
+
 $(eval $(generic-package))
-- 
2.7.4

[Buildroot] [PATCH 2/2] i2c-tools: install library and header to staging

[Yann E. MORIN]

Brad, All,

On 2018-08-23 15:20 -0500, Brad Love spake thusly:
> When the dynamic/static library of i2c-tools is enabled it is installed
> to the target destination. However, in order for external packages to
> link against it, it must also be installed to staging.
> 
> Here, the flag is set to install the package to staging. The
> INSTALL_STAGING command is included to only install the library
> and header file in order to utilize libi2c externally. The make
> targets are used for the installation to accomodate whether static
> or dynamic library was selected during configuration.
> 
> Signed-off-by: Brad Love <brad@nextdimension.cc>
> ---
>  package/i2c-tools/i2c-tools.mk | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/package/i2c-tools/i2c-tools.mk b/package/i2c-tools/i2c-tools.mk
> index a346698..c571056 100644
> --- a/package/i2c-tools/i2c-tools.mk
> +++ b/package/i2c-tools/i2c-tools.mk
> @@ -10,6 +10,7 @@ I2C_TOOLS_SITE = https://www.kernel.org/pub/software/utils/i2c-tools
>  I2C_TOOLS_LICENSE = GPL-2.0+, GPL-2.0 (py-smbus), LGPL-2.1+ (library)
>  I2C_TOOLS_LICENSE_FILES = COPYING
>  I2C_TOOLS_MAKE_OPTS = EXTRA=eeprog
> +I2C_TOOLS_INSTALL_STAGING = YES
>  
>  ifeq ($(BR2_PACKAGE_PYTHON),y)
>  I2C_TOOLS_DEPENDENCIES += python
> @@ -62,4 +63,11 @@ define I2C_TOOLS_INSTALL_TARGET_CMDS
>  	$(I2C_TOOLS_INSTALL_PYSMBUS)
>  endef
>  
> +define I2C_TOOLS_INSTALL_STAGING_CMDS
> +	$(MAKE) $(TARGET_CONFIGURE_OPTS) $(I2C_TOOLS_MAKE_OPTS) \
> +		DESTDIR="$(STAGING_DIR)" prefix=/usr -C $(@D) install-lib
> +	$(MAKE) $(TARGET_CONFIGURE_OPTS) $(I2C_TOOLS_MAKE_OPTS) \
> +		DESTDIR="$(STAGING_DIR)" prefix=/usr -C $(@D) install-include
> +endef

I guess that 'make install' also installs the lib and headers, right? If
so, I'd prefer we use that; it is not a problem that programs are also
instaleld in staging.

Regards,
Yann E. MORIN.

>  $(eval $(generic-package))
> -- 
> 2.7.4
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

[Buildroot] [PATCH 2/2] i2c-tools: install library and header to staging

[Brad Love]

Hi Yann,


On 2018-08-23 15:51, Yann E. MORIN wrote:
> Brad, All,
>
> On 2018-08-23 15:20 -0500, Brad Love spake thusly:
>> When the dynamic/static library of i2c-tools is enabled it is installed
>> to the target destination. However, in order for external packages to
>> link against it, it must also be installed to staging.
>>
>> Here, the flag is set to install the package to staging. The
>> INSTALL_STAGING command is included to only install the library
>> and header file in order to utilize libi2c externally. The make
>> targets are used for the installation to accomodate whether static
>> or dynamic library was selected during configuration.
>>
>> Signed-off-by: Brad Love <brad@nextdimension.cc>
>> ---
>>  package/i2c-tools/i2c-tools.mk | 8 ++++++++
>>  1 file changed, 8 insertions(+)
>>
>> diff --git a/package/i2c-tools/i2c-tools.mk b/package/i2c-tools/i2c-tools.mk
>> index a346698..c571056 100644
>> --- a/package/i2c-tools/i2c-tools.mk
>> +++ b/package/i2c-tools/i2c-tools.mk
>> @@ -10,6 +10,7 @@ I2C_TOOLS_SITE = https://www.kernel.org/pub/software/utils/i2c-tools
>>  I2C_TOOLS_LICENSE = GPL-2.0+, GPL-2.0 (py-smbus), LGPL-2.1+ (library)
>>  I2C_TOOLS_LICENSE_FILES = COPYING
>>  I2C_TOOLS_MAKE_OPTS = EXTRA=eeprog
>> +I2C_TOOLS_INSTALL_STAGING = YES
>>  
>>  ifeq ($(BR2_PACKAGE_PYTHON),y)
>>  I2C_TOOLS_DEPENDENCIES += python
>> @@ -62,4 +63,11 @@ define I2C_TOOLS_INSTALL_TARGET_CMDS
>>  	$(I2C_TOOLS_INSTALL_PYSMBUS)
>>  endef
>>  
>> +define I2C_TOOLS_INSTALL_STAGING_CMDS
>> +	$(MAKE) $(TARGET_CONFIGURE_OPTS) $(I2C_TOOLS_MAKE_OPTS) \
>> +		DESTDIR="$(STAGING_DIR)" prefix=/usr -C $(@D) install-lib
>> +	$(MAKE) $(TARGET_CONFIGURE_OPTS) $(I2C_TOOLS_MAKE_OPTS) \
>> +		DESTDIR="$(STAGING_DIR)" prefix=/usr -C $(@D) install-include
>> +endef
> I guess that 'make install' also installs the lib and headers, right? If
> so, I'd prefer we use that; it is not a problem that programs are also
> instaleld in staging.
>
> Regards,
> Yann E. MORIN.

Just tested, you are correct, make install does everything.
A v2 is incoming. The v2 fixes another issue as well.

Cheers,

Brad


>>  $(eval $(generic-package))
>> -- 
>> 2.7.4
>>
>> _______________________________________________
>> buildroot mailing list
>> buildroot at busybox.net
>> http://lists.busybox.net/mailman/listinfo/buildroot

[Buildroot] [PATCH v2 2/2] i2c-tools: install library and header to staging

[Brad Love]

When the dynamic/static library of i2c-tools is enabled it is installed
to the target destination. However, in order for external packages to
link against it, it must also be installed to staging.

Here, the flag is set to install the package to staging. The
INSTALL_STAGING command is included to complete the operation.

Signed-off-by: Brad Love <brad@nextdimension.cc>
---
since v1:
- condensed make install-lib and make install-include to make install
- Updated commit message
- fixed patch typo (library to libi2c)

 package/i2c-tools/i2c-tools.mk | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/package/i2c-tools/i2c-tools.mk b/package/i2c-tools/i2c-tools.mk
index 2d28166..2082c52 100644
--- a/package/i2c-tools/i2c-tools.mk
+++ b/package/i2c-tools/i2c-tools.mk
@@ -10,6 +10,7 @@ I2C_TOOLS_SITE = https://www.kernel.org/pub/software/utils/i2c-tools
 I2C_TOOLS_LICENSE = GPL-2.0+, GPL-2.0 (py-smbus), LGPL-2.1+ (libi2c)
 I2C_TOOLS_LICENSE_FILES = COPYING
 I2C_TOOLS_MAKE_OPTS = EXTRA=eeprog
+I2C_TOOLS_INSTALL_STAGING = YES
 
 ifeq ($(BR2_PACKAGE_PYTHON),y)
 I2C_TOOLS_DEPENDENCIES += python
@@ -62,4 +63,9 @@ define I2C_TOOLS_INSTALL_TARGET_CMDS
 	$(I2C_TOOLS_INSTALL_PYSMBUS)
 endef
 
+define I2C_TOOLS_INSTALL_STAGING_CMDS
+	$(MAKE) $(TARGET_CONFIGURE_OPTS) $(I2C_TOOLS_MAKE_OPTS) \
+		DESTDIR="$(STAGING_DIR)" prefix=/usr -C $(@D) install
+endef
+
 $(eval $(generic-package))
-- 
2.7.4

[Buildroot] [PATCH 0/2] i2c-tools: license and staging installation fixes

[Brad Love]

Patch 1/2 updates i2c-tools.mk to include the LGPL-2.1+ license which
applies to the library libi2c.

Patch 2/2 enables staging installation, using make targets to install
the header and dynamic or static library for use by external packages.


Brad Love (2):
  i2c-tools: include LGPL-2.1+ license for libi2c
  i2c-tools: install library and header to staging

 package/i2c-tools/i2c-tools.mk | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

-- 
2.7.4

[Buildroot] [PATCH 1/2] i2c-tools: include LGPL-2.1+ license for libi2c

[Brad Love]

Extend i2c-tools SPDX identifiers to include the library license.

The ic2-tools readme states:

LICENSE

Check the documentation of individual tools for licensing information.
The library is released under the LGPL version 2.1 or later, while most
tools are released under the GPL version 2 or later, but there are a few
exceptions.


Signed-off-by: Brad Love <brad@nextdimension.cc>
---
 package/i2c-tools/i2c-tools.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/i2c-tools/i2c-tools.mk b/package/i2c-tools/i2c-tools.mk
index db26647..a346698 100644
--- a/package/i2c-tools/i2c-tools.mk
+++ b/package/i2c-tools/i2c-tools.mk
@@ -7,7 +7,7 @@
 I2C_TOOLS_VERSION = 4.0
 I2C_TOOLS_SOURCE = i2c-tools-$(I2C_TOOLS_VERSION).tar.xz
 I2C_TOOLS_SITE = https://www.kernel.org/pub/software/utils/i2c-tools
-I2C_TOOLS_LICENSE = GPL-2.0+, GPL-2.0 (py-smbus)
+I2C_TOOLS_LICENSE = GPL-2.0+, GPL-2.0 (py-smbus), LGPL-2.1+ (libi2c)
 I2C_TOOLS_LICENSE_FILES = COPYING
 I2C_TOOLS_MAKE_OPTS = EXTRA=eeprog
 
-- 
2.7.4