From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2 of 2] infra: remove usage of pkgparentdir in favor of pkgdir
Date: Tue, 12 Nov 2013 23:06:57 +0100 [thread overview]
Message-ID: <877gcd46m6.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <52824AB9.6070907@mind.be> (Arnout Vandecappelle's message of "Tue, 12 Nov 2013 16:35:21 +0100")
>>>>> "Arnout" == Arnout Vandecappelle <arnout@mind.be> writes:
>>> As I mentioned before, I would prefer to not reuse the same name with a
>>> different meaning, because it may confuse users who have custom
>>> modifications that rely on that variable. So instead I'd remove the
>>> <foo>_DIR completely (so that it's pretty clear that this variable is empty
>>> if anybody still uses it), and instead use e.g. <foo>_BR_DIR for this
>>> purpose.
>>
>> In that case I would prefer something like <foo>_PKG_DIR, instead of BR.
> OK.
> But for consistency with BUILDDIR and SRCDIR, I'd prefer PKGDIR.
Or <foo>_BUILD_DIR / _SRC_DIR.
</bikeshed>
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2013-11-12 22:06 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-11 11:53 [Buildroot] [PATCH 0 of 2] infra: remove pkgparentdir Thomas De Schampheleire
2013-11-11 11:53 ` [Buildroot] [PATCH 1 of 2] dhrystone: remove usage of FOO_DIR_PREFIX Thomas De Schampheleire
2014-02-04 13:18 ` Peter Korsgaard
2013-11-11 11:53 ` [Buildroot] [PATCH 2 of 2] infra: remove usage of pkgparentdir in favor of pkgdir Thomas De Schampheleire
2013-11-11 23:15 ` Arnout Vandecappelle
2013-11-12 8:56 ` Thomas De Schampheleire
2013-11-12 11:09 ` Thomas Petazzoni
2013-11-12 11:32 ` Thomas De Schampheleire
2013-11-12 13:42 ` Arnout Vandecappelle
2013-11-12 13:49 ` Thomas De Schampheleire
2013-11-12 15:35 ` Arnout Vandecappelle
2013-11-12 22:06 ` Peter Korsgaard [this message]
2013-11-12 22:05 ` Peter Korsgaard
2013-12-05 14:53 ` Thomas De Schampheleire
2013-12-15 13:14 ` Thomas De Schampheleire
2013-11-12 13:46 ` Arnout Vandecappelle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877gcd46m6.fsf@dell.be.48ers.dk \
--to=jacmet@uclibc.org \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox