Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2 of 2] infra: remove usage of pkgparentdir in favor of pkgdir
Date: Tue, 12 Nov 2013 23:05:59 +0100	[thread overview]
Message-ID: <87bo1p46ns.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <5282302C.7000005@mind.be> (Arnout Vandecappelle's message of "Tue, 12 Nov 2013 14:42:04 +0100")

>>>>> "Arnout" == Arnout Vandecappelle <arnout@mind.be> writes:

Hi,

>  How is that hard?

>  I would do what we usually do for new policy: enforce it for new
> packages, but leave it alone for existing packages until someone grows
> tired of the inconsistency and sends a global fixup patch. That also
> has the advantage that we can still change our mind on the short term
> without needing to change things all over the place again.

>  That said, I think that using package/foo in the .mk file is a lot
> clearer than $(FOO_XXXDIR).

Agreed. We already have a bunch of magic variable names in BR, so lets
not enforce more than needed.

>>> <foo>_DL_DIR => same as before.
>> 
>> In general, I think the new variable names make sense.

>  +1.

+1

-- 
Bye, Peter Korsgaard

  parent reply	other threads:[~2013-11-12 22:05 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-11 11:53 [Buildroot] [PATCH 0 of 2] infra: remove pkgparentdir Thomas De Schampheleire
2013-11-11 11:53 ` [Buildroot] [PATCH 1 of 2] dhrystone: remove usage of FOO_DIR_PREFIX Thomas De Schampheleire
2014-02-04 13:18   ` Peter Korsgaard
2013-11-11 11:53 ` [Buildroot] [PATCH 2 of 2] infra: remove usage of pkgparentdir in favor of pkgdir Thomas De Schampheleire
2013-11-11 23:15   ` Arnout Vandecappelle
2013-11-12  8:56     ` Thomas De Schampheleire
2013-11-12 11:09       ` Thomas Petazzoni
2013-11-12 11:32         ` Thomas De Schampheleire
2013-11-12 13:42           ` Arnout Vandecappelle
2013-11-12 13:49             ` Thomas De Schampheleire
2013-11-12 15:35               ` Arnout Vandecappelle
2013-11-12 22:06                 ` Peter Korsgaard
2013-11-12 22:05             ` Peter Korsgaard [this message]
2013-12-05 14:53             ` Thomas De Schampheleire
2013-12-15 13:14               ` Thomas De Schampheleire
2013-11-12 13:46       ` Arnout Vandecappelle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bo1p46ns.fsf@dell.be.48ers.dk \
    --to=jacmet@uclibc.org \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox