* [Buildroot] [PATCH] hostcc/hostcxx: fix noccache variant setting
@ 2010-12-14 19:00 Mike Frysinger
0 siblings, 0 replies; 3+ messages in thread
From: Mike Frysinger @ 2010-12-14 19:00 UTC (permalink / raw)
To: buildroot
The current code accidentally sets up HOSTCC_NOCCACHE and HOSTCXX_NOCCACHE
only when the respective HOSTCC or HOSTCXX values are not set. So if you
do something like:
make HOSTCC=gcc menuconfig
The build fails because HOSTCC_NOCCACHE is not set anywhere.
Signed-off-by: Mike Frysinger <vapier@gentoo.org>
---
Makefile | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/Makefile b/Makefile
index f6ab07e..34d28a3 100644
--- a/Makefile
+++ b/Makefile
@@ -126,13 +126,13 @@ endif
ifndef HOSTCC
HOSTCC:=gcc
HOSTCC:=$(shell which $(HOSTCC) || type -p $(HOSTCC) || echo gcc)
-HOSTCC_NOCCACHE:=$(HOSTCC)
endif
+HOSTCC_NOCCACHE:=$(HOSTCC)
ifndef HOSTCXX
HOSTCXX:=g++
HOSTCXX:=$(shell which $(HOSTCXX) || type -p $(HOSTCXX) || echo g++)
-HOSTCXX_NOCCACHE:=$(HOSTCXX)
endif
+HOSTCXX_NOCCACHE:=$(HOSTCXX)
ifndef HOSTFC
HOSTFC:=gfortran
endif
--
1.7.3.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH] hostcc/hostcxx: fix noccache variant setting
@ 2011-03-28 7:18 Mike Frysinger
2011-03-28 8:55 ` Peter Korsgaard
0 siblings, 1 reply; 3+ messages in thread
From: Mike Frysinger @ 2011-03-28 7:18 UTC (permalink / raw)
To: buildroot
The current code accidentally sets up HOSTCC_NOCCACHE and HOSTCXX_NOCCACHE
only when the respective HOSTCC or HOSTCXX values are not set. So if you
do something like:
make HOSTCC=gcc menuconfig
The build fails because HOSTCC_NOCCACHE is not set anywhere.
Signed-off-by: Mike Frysinger <vapier@gentoo.org>
---
Makefile | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/Makefile b/Makefile
index 7ae3787..9aa7399 100644
--- a/Makefile
+++ b/Makefile
@@ -126,13 +126,13 @@ endif
ifndef HOSTCC
HOSTCC:=gcc
HOSTCC:=$(shell which $(HOSTCC) || type -p $(HOSTCC) || echo gcc)
-HOSTCC_NOCCACHE:=$(HOSTCC)
endif
+HOSTCC_NOCCACHE:=$(HOSTCC)
ifndef HOSTCXX
HOSTCXX:=g++
HOSTCXX:=$(shell which $(HOSTCXX) || type -p $(HOSTCXX) || echo g++)
-HOSTCXX_NOCCACHE:=$(HOSTCXX)
endif
+HOSTCXX_NOCCACHE:=$(HOSTCXX)
ifndef HOSTFC
HOSTFC:=gfortran
endif
--
1.7.4.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH] hostcc/hostcxx: fix noccache variant setting
2011-03-28 7:18 [Buildroot] [PATCH] hostcc/hostcxx: fix noccache variant setting Mike Frysinger
@ 2011-03-28 8:55 ` Peter Korsgaard
0 siblings, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2011-03-28 8:55 UTC (permalink / raw)
To: buildroot
>>>>> "Mike" == Mike Frysinger <vapier@gentoo.org> writes:
Mike> The current code accidentally sets up HOSTCC_NOCCACHE and HOSTCXX_NOCCACHE
Mike> only when the respective HOSTCC or HOSTCXX values are not set. So if you
Mike> do something like:
Mike> make HOSTCC=gcc menuconfig
Mike> The build fails because HOSTCC_NOCCACHE is not set anywhere.
Committed, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-03-28 8:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-03-28 7:18 [Buildroot] [PATCH] hostcc/hostcxx: fix noccache variant setting Mike Frysinger
2011-03-28 8:55 ` Peter Korsgaard
-- strict thread matches above, loose matches on Subject: below --
2010-12-14 19:00 Mike Frysinger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox