* [Buildroot] [PATCH] pciutils: SHARED make opt goes for install too
@ 2011-01-10 13:47 Gustavo Zacarias
2011-01-10 13:57 ` Peter Korsgaard
0 siblings, 1 reply; 2+ messages in thread
From: Gustavo Zacarias @ 2011-01-10 13:47 UTC (permalink / raw)
To: buildroot
If we don't pass SHARED when installing we miss the shared library
symlinks (libpci.so & libpci.so.3)
On internal and external toolchains that have a proper cross ldconfig
this isn't a problem but it breaks on toolchains that lack a cross ldconfig to
automagically make the symlinks.
Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
---
package/pciutils/pciutils.mk | 6 ++++--
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/package/pciutils/pciutils.mk b/package/pciutils/pciutils.mk
index 6e16300..782d348 100644
--- a/package/pciutils/pciutils.mk
+++ b/package/pciutils/pciutils.mk
@@ -39,8 +39,10 @@ endef
# Ditch install-lib if SHARED is an option in the future
define PCIUTILS_INSTALL_TARGET_CMDS
- $(MAKE) BUILDDIR=$(@D) -C $(@D) PREFIX=$(TARGET_DIR)/usr install
- $(MAKE) BUILDDIR=$(@D) -C $(@D) PREFIX=$(TARGET_DIR)/usr install-lib
+ $(MAKE) BUILDDIR=$(@D) -C $(@D) PREFIX=$(TARGET_DIR)/usr \
+ SHARED=$(PCIUTILS_SHARED) install
+ $(MAKE) BUILDDIR=$(@D) -C $(@D) PREFIX=$(TARGET_DIR)/usr \
+ SHARED=$(PCIUTILS_SHARED) install-lib
endef
$(eval $(call GENTARGETS,package,pciutils))
--
1.7.3.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [Buildroot] [PATCH] pciutils: SHARED make opt goes for install too
2011-01-10 13:47 [Buildroot] [PATCH] pciutils: SHARED make opt goes for install too Gustavo Zacarias
@ 2011-01-10 13:57 ` Peter Korsgaard
0 siblings, 0 replies; 2+ messages in thread
From: Peter Korsgaard @ 2011-01-10 13:57 UTC (permalink / raw)
To: buildroot
>>>>> "Gustavo" == Gustavo Zacarias <gustavo@zacarias.com.ar> writes:
Gustavo> If we don't pass SHARED when installing we miss the shared library
Gustavo> symlinks (libpci.so & libpci.so.3)
Gustavo> On internal and external toolchains that have a proper cross ldconfig
Gustavo> this isn't a problem but it breaks on toolchains that lack a cross ldconfig to
Gustavo> automagically make the symlinks.
Committed, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-01-10 13:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-01-10 13:47 [Buildroot] [PATCH] pciutils: SHARED make opt goes for install too Gustavo Zacarias
2011-01-10 13:57 ` Peter Korsgaard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox