Re: [Buildroot] [PATCH v1 1/4] package/libcamera: pipeline option 'raspberrypi' changed to 'rpi/vc4'

[Peter Korsgaard <peter@korsgaard.com>]

>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:

 > Peter, All,
 > On 2023-11-09 22:28 +0100, Peter Seiderer spake thusly:
 >> With upstram commit [1] (since version v0.1.0) the pipeline option 'raspberrypi'
 >> was renamed to 'rpi/vc4'.
 >> 
 >> Change the buildroot option name from BR2_PACKAGE_LIBCAMERA_PIPELINE_RASPBERRYPI
 >> to BR2_PACKAGE_LIBCAMERA_PIPELINE_RPI_VC4 (and add Config.in.legacy entry
 >> accordingly) and move handling in Config.in/libcamer.mk to follow alphabetic
 >> ordering.
 >> 
 >> Fixes:
 >> 
 >> .../build/libcamera-v0.1.0/meson.build:3:0: ERROR: Options
 >> "raspberrypi" are not in allowed choices: "all, auto, imx8-isi,
 >> ipu3, rkisp1, rpi/vc4, simple, uvcvideo, vimc"
 >> 
 >> [1] https://git.libcamera.org/libcamera/libcamera.git/commit/?id=726e9274ea95fa46352556d340c5793a8da51fcd
 >> 
 >> Signed-off-by: Peter Seiderer <ps.report@gmx.net>

 > Applied to master, thanks.

 > Regards,
 > Yann E. MORIN.

 >> ---
 >> Config.in.legacy               | 10 ++++++++++
 >> package/libcamera/Config.in    | 16 ++++++++--------
 >> package/libcamera/libcamera.mk |  6 +++---
 >> 3 files changed, 21 insertions(+), 11 deletions(-)
 >> 
 >> diff --git a/Config.in.legacy b/Config.in.legacy
 >> index 6fef2318b0..06a40f0b38 100644
 >> --- a/Config.in.legacy
 >> +++ b/Config.in.legacy
 >> @@ -146,6 +146,16 @@ endif
 >> 
 >> comment "Legacy options removed in 2023.11"
 >> 
 >> +config BR2_PACKAGE_LIBCAMERA_PIPELINE_RASPBERRYPI
 >> +	bool "libcamera pipeline 'raspberrypi' was renamed to 'rpi/vc4'"
 >> +	depends on BR2_arm || BR2_aarch64
 >> +	depends on BR2_USE_WCHAR
 >> +	select BR2_LEGACY
 >> +	select BR2_PACKAGE_LIBCAMERA_PIPELINE_RPI_VC4
 >> +	help
 >> +	  Since version ... the libcamera pipeline option 'raspberrypi' was

I guess ... should have been 0.1.0:

git describe --contains 726e9274e
v0.1.0~78

check-package also complains about too long help line:

Config.in.legacy:156: help text: <tab><2 spaces><62 chars> (http://nightly.buildroot.org/#writing-rules-config-in)

Committed to 2023.11.x after fixing those issues, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot