Re: [Buildroot] [PATCH v1 1/4] package/libcamera: pipeline option 'raspberrypi' changed to 'rpi/vc4'

["Yann E. MORIN" <yann.morin.1998@free.fr>]

Peter, All,

On 2023-12-27 23:16 +0100, Yann E. MORIN spake thusly:
> On 2023-11-09 22:28 +0100, Peter Seiderer spake thusly:
> > With upstram commit [1] (since version v0.1.0) the pipeline option 'raspberrypi'
> > was renamed to 'rpi/vc4'.
> > 
> > Change the buildroot option name from BR2_PACKAGE_LIBCAMERA_PIPELINE_RASPBERRYPI
> > to BR2_PACKAGE_LIBCAMERA_PIPELINE_RPI_VC4 (and add Config.in.legacy entry
> > accordingly) and move handling in Config.in/libcamer.mk to follow alphabetic
> > ordering.
> > 
> > Fixes:
> > 
> >   .../build/libcamera-v0.1.0/meson.build:3:0: ERROR: Options "raspberrypi" are not in allowed choices: "all, auto, imx8-isi, ipu3, rkisp1, rpi/vc4, simple, uvcvideo, vimc"
> > 
> > [1] https://git.libcamera.org/libcamera/libcamera.git/commit/?id=726e9274ea95fa46352556d340c5793a8da51fcd
> > 
> > Signed-off-by: Peter Seiderer <ps.report@gmx.net>
> Applied to master, thanks.
[--SNIP--]
> > diff --git a/Config.in.legacy b/Config.in.legacy
> > index 6fef2318b0..06a40f0b38 100644
> > --- a/Config.in.legacy
> > +++ b/Config.in.legacy
> > @@ -146,6 +146,16 @@ endif
> >  
> >  comment "Legacy options removed in 2023.11"
> >  
> > +config BR2_PACKAGE_LIBCAMERA_PIPELINE_RASPBERRYPI
> > +	bool "libcamera pipeline 'raspberrypi' was renamed to 'rpi/vc4'"
> > +	depends on BR2_arm || BR2_aarch64
> > +	depends on BR2_USE_WCHAR
> > +	select BR2_LEGACY
> > +	select BR2_PACKAGE_LIBCAMERA_PIPELINE_RPI_VC4
> > +	help
> > +	  Since version ... the libcamera pipeline option 'raspberrypi' was

    $ ./utils/docker-run make check-pacakge
    Config.in.legacy:156: help text: <tab><2 spaces><62 chars> (http://nightly.buildroot.org/#writing-rules-config-in)

I had it fixed locally, but forgot to commit before pushing, so I pushed
a follow-up fix.

I also replaced the '...' with the actual version you talked about ion
the commit log: 0.1.0.

Regards,
Yann E. MORIN.

> > +	  renamed to 'rpi/vc4'.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot