* [Buildroot] [PATCH 1/1] package/libusb-compat: fix hash
@ 2023-11-30 8:33 Sébastien Szymanski
2023-11-30 22:15 ` Peter Korsgaard
0 siblings, 1 reply; 2+ messages in thread
From: Sébastien Szymanski @ 2023-11-30 8:33 UTC (permalink / raw)
To: buildroot; +Cc: Zoltan Gyarmati
Upstream re-released the v0.1.8 tarballs with autotools related stuff. [1]
That makes the hash test to fail:
ERROR: while checking hashes from package/libusb-compat//libusb-compat.hash
ERROR: libusb-compat-0.1.8.tar.bz2 has wrong sha256 hash:
ERROR: expected: 698c76484f3dec1e0175067cbd1556c3021e94e7f2313ae3ea6a66d900e00827
ERROR: got : b692dcf674c070c8c0bee3c8230ce4ee5903f926d77dc8b968a4dd1b70f9b05c
ERROR: Incomplete download, or man-in-the-middle (MITM) attack
Update the hash and drop LIBUSB_COMPAT_AUTORECONF.
[1] https://github.com/libusb/libusb-compat-0.1/issues/28#issuecomment-1759400548
Signed-off-by: Sébastien Szymanski <sebastien.szymanski@armadeus.com>
---
package/libusb-compat/libusb-compat.hash | 2 +-
package/libusb-compat/libusb-compat.mk | 3 ---
2 files changed, 1 insertion(+), 4 deletions(-)
diff --git a/package/libusb-compat/libusb-compat.hash b/package/libusb-compat/libusb-compat.hash
index a198e76058b9..78f1dbdcf89d 100644
--- a/package/libusb-compat/libusb-compat.hash
+++ b/package/libusb-compat/libusb-compat.hash
@@ -1,3 +1,3 @@
# Locally computed:
-sha256 698c76484f3dec1e0175067cbd1556c3021e94e7f2313ae3ea6a66d900e00827 libusb-compat-0.1.8.tar.bz2
+sha256 b692dcf674c070c8c0bee3c8230ce4ee5903f926d77dc8b968a4dd1b70f9b05c libusb-compat-0.1.8.tar.bz2
sha256 5df07007198989c622f5d41de8d703e7bef3d0e79d62e24332ee739a452af62a COPYING
diff --git a/package/libusb-compat/libusb-compat.mk b/package/libusb-compat/libusb-compat.mk
index d49b75367036..e9f845180e7b 100644
--- a/package/libusb-compat/libusb-compat.mk
+++ b/package/libusb-compat/libusb-compat.mk
@@ -14,9 +14,6 @@ LIBUSB_COMPAT_INSTALL_STAGING = YES
LIBUSB_COMPAT_CONFIG_SCRIPTS = libusb-config
LIBUSB_COMPAT_LICENSE = LGPL-2.1+
LIBUSB_COMPAT_LICENSE_FILES = COPYING
-# 0.1.8 tarball was released without configure script by upstream
-# discussed here: https://github.com/libusb/libusb-compat-0.1/issues/28
-LIBUSB_COMPAT_AUTORECONF = YES
ifeq ($(BR2_STATIC_LIBS),)
LIBUSB_COMPAT_CONF_ENV += \
--
2.41.0
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/libusb-compat: fix hash
2023-11-30 8:33 [Buildroot] [PATCH 1/1] package/libusb-compat: fix hash Sébastien Szymanski
@ 2023-11-30 22:15 ` Peter Korsgaard
0 siblings, 0 replies; 2+ messages in thread
From: Peter Korsgaard @ 2023-11-30 22:15 UTC (permalink / raw)
To: Sébastien Szymanski; +Cc: Zoltan Gyarmati, buildroot
>>>>> "Sébastien" == Sébastien Szymanski <sebastien.szymanski@armadeus.com> writes:
> Upstream re-released the v0.1.8 tarballs with autotools related stuff. [1]
> That makes the hash test to fail:
> ERROR: while checking hashes from package/libusb-compat//libusb-compat.hash
> ERROR: libusb-compat-0.1.8.tar.bz2 has wrong sha256 hash:
> ERROR: expected: 698c76484f3dec1e0175067cbd1556c3021e94e7f2313ae3ea6a66d900e00827
> ERROR: got : b692dcf674c070c8c0bee3c8230ce4ee5903f926d77dc8b968a4dd1b70f9b05c
> ERROR: Incomplete download, or man-in-the-middle (MITM) attack
> Update the hash and drop LIBUSB_COMPAT_AUTORECONF.
> [1] https://github.com/libusb/libusb-compat-0.1/issues/28#issuecomment-1759400548
> Signed-off-by: Sébastien Szymanski <sebastien.szymanski@armadeus.com>
Argh, that is a annoying, as then our cached copy on
sources.buildroot.org will not have the correct hash :/
I've changed it to use .tar.gz instead to not conflict with the cached
.tar.bz2 and committed, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-11-30 22:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-11-30 8:33 [Buildroot] [PATCH 1/1] package/libusb-compat: fix hash Sébastien Szymanski
2023-11-30 22:15 ` Peter Korsgaard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox