[Buildroot] [PATCH 1/1] docs/website: fix favicon

[Buildroot] [PATCH 1/1] docs/website: fix favicon

[Brandon Maier via buildroot]

When the favicon image was added in f26e61319f3f (docs/website: add
favicon.png), it was added to a different directory then where the header's
icon link points. This causes the favicon to fail to load with 404.

While we are here, remove the "shortcut" rel attribute as it is non-standard
and it's recommended not to use it[1].

[1] https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes/rel#sect4

Signed-off-by: Brandon Maier <brandon.maier@collins.com>
---
 docs/website/header.html | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/docs/website/header.html b/docs/website/header.html
index e1909291f6..548ed7ad53 100644
--- a/docs/website/header.html
+++ b/docs/website/header.html
@@ -6,7 +6,7 @@
 	<meta name="viewport" content="width=device-width, initial-scale=1.0">
 	<meta name="Buildroot" content="">
 	<meta name="angelo.compagnucci@gmail.com" content="">
-	<link rel="shortcut icon" href="images/favicon.png">
+	<link rel="icon" href="favicon.png">
 
 	<title>Buildroot - Making Embedded Linux Easy</title>
 
-- 
2.43.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] docs/website: fix favicon

[Peter Korsgaard]

>>>>> "Brandon" == Brandon Maier <brandon.maier@collins.com> writes:

 > When the favicon image was added in f26e61319f3f (docs/website: add
 > favicon.png), it was added to a different directory then where the header's
 > icon link points. This causes the favicon to fail to load with 404.

 > While we are here, remove the "shortcut" rel attribute as it is non-standard
 > and it's recommended not to use it[1].

 > [1] https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes/rel#sect4

 > Signed-off-by: Brandon Maier <brandon.maier@collins.com>

Committed, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] docs/website: fix favicon

[Peter Korsgaard]

>>>>> "Peter" == Peter Korsgaard <peter@korsgaard.com> writes:

>>>>> "Brandon" == Brandon Maier <brandon.maier@collins.com> writes:
 >> When the favicon image was added in f26e61319f3f (docs/website: add
 >> favicon.png), it was added to a different directory then where the header's
 >> icon link points. This causes the favicon to fail to load with 404.

 >> While we are here, remove the "shortcut" rel attribute as it is non-standard
 >> and it's recommended not to use it[1].

 >> [1] https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes/rel#sect4

 >> Signed-off-by: Brandon Maier <brandon.maier@collins.com>

 > Committed, thanks.

Committed to 2023.02.x and 2023.08.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot