[Buildroot] [PATCH] package/ne10: install shared libraries only when built

[Buildroot] [PATCH] package/ne10: install shared libraries only when built

[Thomas Petazzoni via buildroot]

The install to staging commands of the ne10 package are careful to
install the shared libraries only if they are built, but we forgot to
use the same care for the install to target commands, causing a build
failure on BR2_STATIC_LIBS=y configurations as no shared library was
built:

cp: cannot stat '/home/autobuild/autobuild/instance-15/output-1/build/ne10-1.2.1/modules/libNE10*.so*': No such file or directory

This commit fixes this by guarding the target installation commands to
BR2_STATIC_LIBS being empty.

The problem exists since the package was introduced in commit
318f3db0dcc052aa770ca57c143b5f7bc40cdaf3 ("ne10: new package"), a good
10 years ago. Most likely it was not seen for many years as this
package is only available for ARM with NEON and AArch64, and we were
not testing fully static builds, except for ARMv5 that don't have
NEON. Now that we are doing more random testing, the problem started
being visible.

Fixes:

  http://autobuild.buildroot.net/results/45b2c1af052271bc2f1bb96544f138d29e4f7dfd/

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
---
 package/ne10/ne10.mk | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/package/ne10/ne10.mk b/package/ne10/ne10.mk
index 3946605556..ce0f7e7b77 100644
--- a/package/ne10/ne10.mk
+++ b/package/ne10/ne10.mk
@@ -42,8 +42,10 @@ define NE10_INSTALL_STAGING_CMDS
 	$(NE10_INSTALL_STAGING_SHARED_LIB)
 endef
 
+ifeq ($(BR2_STATIC_LIBS),)
 define NE10_INSTALL_TARGET_CMDS
 	cp -dpf $(@D)/modules/libNE10*.so* $(TARGET_DIR)/usr/lib/
 endef
+endif
 
 $(eval $(cmake-package))
-- 
2.41.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] package/ne10: install shared libraries only when built

[Arnout Vandecappelle via buildroot]

On 21/09/2023 12:28, Thomas Petazzoni via buildroot wrote:
> The install to staging commands of the ne10 package are careful to
> install the shared libraries only if they are built, but we forgot to
> use the same care for the install to target commands, causing a build
> failure on BR2_STATIC_LIBS=y configurations as no shared library was
> built:
> 
> cp: cannot stat '/home/autobuild/autobuild/instance-15/output-1/build/ne10-1.2.1/modules/libNE10*.so*': No such file or directory
> 
> This commit fixes this by guarding the target installation commands to
> BR2_STATIC_LIBS being empty.
> 
> The problem exists since the package was introduced in commit
> 318f3db0dcc052aa770ca57c143b5f7bc40cdaf3 ("ne10: new package"), a good
> 10 years ago. Most likely it was not seen for many years as this
> package is only available for ARM with NEON and AArch64, and we were
> not testing fully static builds, except for ARMv5 that don't have
> NEON. Now that we are doing more random testing, the problem started
> being visible.
> 
> Fixes:
> 
>    http://autobuild.buildroot.net/results/45b2c1af052271bc2f1bb96544f138d29e4f7dfd/ >
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>

  Applied to master, thanks.

  Regards,
  Arnout

> ---
>   package/ne10/ne10.mk | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/package/ne10/ne10.mk b/package/ne10/ne10.mk
> index 3946605556..ce0f7e7b77 100644
> --- a/package/ne10/ne10.mk
> +++ b/package/ne10/ne10.mk
> @@ -42,8 +42,10 @@ define NE10_INSTALL_STAGING_CMDS
>   	$(NE10_INSTALL_STAGING_SHARED_LIB)
>   endef
>   
> +ifeq ($(BR2_STATIC_LIBS),)
>   define NE10_INSTALL_TARGET_CMDS
>   	cp -dpf $(@D)/modules/libNE10*.so* $(TARGET_DIR)/usr/lib/
>   endef
> +endif
>   
>   $(eval $(cmake-package))
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] package/ne10: install shared libraries only when built

[Peter Korsgaard]

>>>>> "Thomas" == Thomas Petazzoni via buildroot <buildroot@buildroot.org> writes:

 > The install to staging commands of the ne10 package are careful to
 > install the shared libraries only if they are built, but we forgot to
 > use the same care for the install to target commands, causing a build
 > failure on BR2_STATIC_LIBS=y configurations as no shared library was
 > built:

 > cp: cannot stat '/home/autobuild/autobuild/instance-15/output-1/build/ne10-1.2.1/modules/libNE10*.so*': No such file or directory

 > This commit fixes this by guarding the target installation commands to
 > BR2_STATIC_LIBS being empty.

 > The problem exists since the package was introduced in commit
 > 318f3db0dcc052aa770ca57c143b5f7bc40cdaf3 ("ne10: new package"), a good
 > 10 years ago. Most likely it was not seen for many years as this
 > package is only available for ARM with NEON and AArch64, and we were
 > not testing fully static builds, except for ARMv5 that don't have
 > NEON. Now that we are doing more random testing, the problem started
 > being visible.

 > Fixes:

 >   http://autobuild.buildroot.net/results/45b2c1af052271bc2f1bb96544f138d29e4f7dfd/

 > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>

Committed to 2023.02.x, 2023.05.x and 2023.08.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot