[Buildroot] [PATCH] package/pkg-golang: disable version control information

[Buildroot] [PATCH] package/pkg-golang: disable version control information

[Stefan Agner]

By default go tries to include version control (VCS) information in
binaries. Since Buildroot separates version control from the build
process it is sensible to disable this behavior.

This avoids build errors when building with a git repository higher
up in the tree owned by root. In this case the go build system
calls `git status --porcelain` which returns with an error:
fatal: detected dubious ownership in repository at '/build'

Signed-off-by: Stefan Agner <stefan@agner.ch>
---
 package/pkg-golang.mk | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/package/pkg-golang.mk b/package/pkg-golang.mk
index cdc67b32c0..da9c9a21ac 100644
--- a/package/pkg-golang.mk
+++ b/package/pkg-golang.mk
@@ -45,7 +45,8 @@ $(2)_BUILD_OPTS += \
 	-modcacherw \
 	-tags "$$($(2)_TAGS)" \
 	-trimpath \
-	-p $$(PARALLEL_JOBS)
+	-p $$(PARALLEL_JOBS) \
+	-buildvcs=false
 
 # Target packages need the Go compiler on the host at download time (for
 # vendoring), and at build and install time.
-- 
2.39.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] package/pkg-golang: disable version control information

[Christian Stewart via buildroot]

Hi Stefan,

On Mon, Feb 13, 2023 at 6:16 AM Stefan Agner <stefan@agner.ch> wrote:
>
> By default go tries to include version control (VCS) information in
> binaries. Since Buildroot separates version control from the build
> process it is sensible to disable this behavior.
>
> This avoids build errors when building with a git repository higher
> up in the tree owned by root. In this case the go build system
> calls `git status --porcelain` which returns with an error:
> fatal: detected dubious ownership in repository at '/build'
>
> Signed-off-by: Stefan Agner <stefan@agner.ch>
> ---
>  package/pkg-golang.mk | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/package/pkg-golang.mk b/package/pkg-golang.mk
> index cdc67b32c0..da9c9a21ac 100644
> --- a/package/pkg-golang.mk
> +++ b/package/pkg-golang.mk
> @@ -45,7 +45,8 @@ $(2)_BUILD_OPTS += \
>         -modcacherw \
>         -tags "$$($(2)_TAGS)" \
>         -trimpath \
> -       -p $$(PARALLEL_JOBS)
> +       -p $$(PARALLEL_JOBS) \
> +       -buildvcs=false

Lgtm & tested

Reviewed-by: Christian Stewart <christian@paral.in>
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] package/pkg-golang: disable version control information

[Arnout Vandecappelle]

On 13/02/2023 15:15, Stefan Agner wrote:
> By default go tries to include version control (VCS) information in
> binaries. Since Buildroot separates version control from the build
> process it is sensible to disable this behavior.
> 
> This avoids build errors when building with a git repository higher
> up in the tree owned by root. In this case the go build system
> calls `git status --porcelain` which returns with an error:
> fatal: detected dubious ownership in repository at '/build'
> 
> Signed-off-by: Stefan Agner <stefan@agner.ch>

  Applied to master, thanks.

  Regards,
  Arnout

> ---
>   package/pkg-golang.mk | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/package/pkg-golang.mk b/package/pkg-golang.mk
> index cdc67b32c0..da9c9a21ac 100644
> --- a/package/pkg-golang.mk
> +++ b/package/pkg-golang.mk
> @@ -45,7 +45,8 @@ $(2)_BUILD_OPTS += \
>   	-modcacherw \
>   	-tags "$$($(2)_TAGS)" \
>   	-trimpath \
> -	-p $$(PARALLEL_JOBS)
> +	-p $$(PARALLEL_JOBS) \
> +	-buildvcs=false
>   
>   # Target packages need the Go compiler on the host at download time (for
>   # vendoring), and at build and install time.
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] package/pkg-golang: disable version control information

[Peter Korsgaard]

>>>>> "Stefan" == Stefan Agner <stefan@agner.ch> writes:

 > By default go tries to include version control (VCS) information in
 > binaries. Since Buildroot separates version control from the build
 > process it is sensible to disable this behavior.

 > This avoids build errors when building with a git repository higher
 > up in the tree owned by root. In this case the go build system
 > calls `git status --porcelain` which returns with an error:
 > fatal: detected dubious ownership in repository at '/build'

 > Signed-off-by: Stefan Agner <stefan@agner.ch>

Committed to 2022.11.x and 2022.02.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot