Re: [Buildroot] [PATCH] package/cmake: bump version to 3.22.3

From: Baruch Siach via buildroot <buildroot@buildroot.org>
To: Andrey Nechypurenko <andreynech@gmail.com>
Cc: Alsey Miller <alseycmiller@gmail.com>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] package/cmake: bump version to 3.22.3
Date: Wed, 11 May 2022 13:06:16 +0300	[thread overview]
Message-ID: <878rr88joi.fsf@tarshish> (raw)
In-Reply-To: <CAOiXNkDBgP=sjS5WEKR58VSgfikBmSV8FmcaQygAPHi-E_Lptw@mail.gmail.com>

Hi Andrey,

On Wed, May 11 2022, Andrey Nechypurenko wrote:
>> On 10/05/2022 17:20, Andrey Nechypurenko wrote:
>> >>> I am just curious if the following patch will be accepted for the
>> >>> upcoming release?
>> >>
>> >> What about bumping it to 3.23.1?
>> >
>> > At the time I submitted the patch (29.03), v.3.22 was the latest one. It
>> > also fixes the bug I was facing. So it is good enough for me and definitely
>> > better than v.3.18 currently used by Buildroot. If you would like to submit
>> > another one for v. 3.23.1 it would be great.
>>
>>   Up to now, we've always kept the cmake version in sync with the value of
>> BR2_CMAKE_VERSION_MIN (defined in support/dependencies/check-host-cmake.mk and
>> updated every time there is a package that requires a specific newer version -
>> like swift would, as mentioned by Alsey.
>
> In addition to the Swift package mentioned by Alsey, there could be custom
> packages added by Buildroot users with external trees. This is what I am
> currently doing.
>
>>   What is the bug you were facing?
>
> Our custom package uses a feature which was buggy:
> https://gitlab.kitware.com/cmake/cmake/-/issues/18299 (it is also mentioned
> in the submitted patch). This bug was fixed in CMake 3.20.
>
>> Perhaps backporting its fix is appropriate?
>
> If the proposed patch with v.3.22 does not introduce any regression, then I
> personally do not see any reasons for backporting. 3.18 is two years old and
> it might be beneficial to switch to a newer one.

Backporting the cmake fix alone would not help hosts with cmake version
3.18 installed. With current BR2_CMAKE_VERSION_MIN set to 3.18 Buildroot
will not build the fixed cmake host package, but rely instead on the
buggy host installed cmake.

baruch

-- 
                                                     ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot