Re: [Buildroot] [PATCH] package/cmake: bump version to 3.22.3

From: Baruch Siach via buildroot <buildroot@buildroot.org>
To: Andrey Nechypurenko <andreynech@gmail.com>
Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] package/cmake: bump version to 3.22.3
Date: Mon, 30 May 2022 16:04:14 +0300	[thread overview]
Message-ID: <87r14bdv6a.fsf@tarshish> (raw)
In-Reply-To: <CAOiXNkCfAQ-jBTrxT2dCZw9AR6uuFJ7WxEsYWXdhfm_iF4DLPg@mail.gmail.com>

Hi Andrey,

On Mon, May 30 2022, Andrey Nechypurenko wrote:
> This is a little bit strange. The patch file located in outgoing
> directory and generated with
> # git format-patch -M -n -s -o outgoing origin/master
> do contains Signed-off-by: tag. However, the command
> # git send-email --to buildroot@buildroot.org --cc-cmd
> './utils/get-developers -e' origin/master
> leads to what could be seen in my previous mail - no Signed-off-by: tag.
>
> Am I doing something wrong or are there some configuration options I am missing?

The 'origin/master' parameter goes to 'git format-patch'. Which means
that you are sending commits between origin/master..HEAD.

If you want git send-email to send you patch file, put that file as last
parameter.

One more comment below.

> On Mon, 30 May 2022 at 14:44, Andrey Nechypurenko <andreynech@gmail.com> wrote:
>> Version 3.20 is the first one where the following issue is fixed:
>> https://gitlab.kitware.com/cmake/cmake/-/issues/18299
>> Was affected by this bug and decide to bump the version to the
>> latest stable

This bump by itself does not fix the issue for hosts that have buggy
cmake installed. To fix them you also need a separate patch to bump
BR2_CMAKE_VERSION_MIN to a fixed version.

baruch

>> ---
>>  package/cmake/cmake.hash | 4 ++--
>>  package/cmake/cmake.mk   | 4 ++--
>>  2 files changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/package/cmake/cmake.hash b/package/cmake/cmake.hash
>> index da514a6d6b..1749db8c27 100644
>> --- a/package/cmake/cmake.hash
>> +++ b/package/cmake/cmake.hash
>> @@ -1,5 +1,5 @@
>> -# From https://cmake.org/files/v3.18/cmake-3.18.6-SHA-256.txt
>> -sha256  124f571ab70332da97a173cb794dfa09a5b20ccbb80a08e56570a500f47b6600  cmake-3.18.6.tar.gz
>> +# From https://cmake.org/files/v3.22/cmake-3.22.3-SHA-256.txt
>> +sha256  9f8469166f94553b6978a16ee29227ec49a2eb5ceb608275dec40d8ae0d1b5a0  cmake-3.22.3.tar.gz
>>
>>  # Locally calculated
>>  sha256  131b9ff756b64a25b7461c3c1382e70b16c70a5b4833a1577897fa3ea6d88f8d  Copyright.txt
>> diff --git a/package/cmake/cmake.mk b/package/cmake/cmake.mk
>> index 4177b119ab..053658fad6 100644
>> --- a/package/cmake/cmake.mk
>> +++ b/package/cmake/cmake.mk
>> @@ -4,8 +4,8 @@
>>  #
>>  ################################################################################
>>
>> -CMAKE_VERSION_MAJOR = 3.18
>> -CMAKE_VERSION = $(CMAKE_VERSION_MAJOR).6
>> +CMAKE_VERSION_MAJOR = 3.22
>> +CMAKE_VERSION = $(CMAKE_VERSION_MAJOR).3
>>  CMAKE_SITE = https://cmake.org/files/v$(CMAKE_VERSION_MAJOR)
>>  CMAKE_LICENSE = BSD-3-Clause
>>  CMAKE_LICENSE_FILES = Copyright.txt
>> --
>> 2.32.0
>>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
                                                     ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot