* [Buildroot] [PATCH] br2-external: make it available to post-{build, image} scripts
@ 2015-02-07 18:28 Yann E. MORIN
2015-02-07 19:46 ` Peter Korsgaard
0 siblings, 1 reply; 2+ messages in thread
From: Yann E. MORIN @ 2015-02-07 18:28 UTC (permalink / raw)
To: buildroot
Currently, BR2_EXTERNAL is not always exported to sub-processes that we
spawn, like post-build or post-image scripts. This all depends on how
the user passes BR2_EXTERNAL; consider the following:
- make BR2_EXTERNAL=/path/to/br2-ext
- BR2_EXTERNAL=/path/to/br2-ext make
In the first case, it is just a make variable, not an environment
variable, and thus not exported, while in the second case it is an
environment variable and gets exported to all sub-processes make may
spawn.
Explicitly export it using EXTRA_ENV.
Reported-by: Julian Scheel <julian@jusst.de>
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Julian Scheel <julian@jusst.de>
---
package/Makefile.in | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/package/Makefile.in b/package/Makefile.in
index 70529f8..803b162 100644
--- a/package/Makefile.in
+++ b/package/Makefile.in
@@ -326,7 +326,8 @@ HOST_MAKE_ENV = \
EXTRA_ENV = \
PATH=$(BR_PATH) \
BR2_DL_DIR=$(BR2_DL_DIR) \
- BUILD_DIR=$(BUILD_DIR)
+ BUILD_DIR=$(BUILD_DIR) \
+ BR2_EXTERNAL=$(BR2_EXTERNAL)
################################################################################
# settings we need to pass to configure
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [Buildroot] [PATCH] br2-external: make it available to post-{build, image} scripts
2015-02-07 18:28 [Buildroot] [PATCH] br2-external: make it available to post-{build, image} scripts Yann E. MORIN
@ 2015-02-07 19:46 ` Peter Korsgaard
0 siblings, 0 replies; 2+ messages in thread
From: Peter Korsgaard @ 2015-02-07 19:46 UTC (permalink / raw)
To: buildroot
>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:
> Currently, BR2_EXTERNAL is not always exported to sub-processes that we
> spawn, like post-build or post-image scripts. This all depends on how
> the user passes BR2_EXTERNAL; consider the following:
> - make BR2_EXTERNAL=/path/to/br2-ext
> - BR2_EXTERNAL=/path/to/br2-ext make
> In the first case, it is just a make variable, not an environment
> variable, and thus not exported, while in the second case it is an
> environment variable and gets exported to all sub-processes make may
> spawn.
> Explicitly export it using EXTRA_ENV.
> Reported-by: Julian Scheel <julian@jusst.de>
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Cc: Julian Scheel <julian@jusst.de>
Committed, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-02-07 19:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-02-07 18:28 [Buildroot] [PATCH] br2-external: make it available to post-{build, image} scripts Yann E. MORIN
2015-02-07 19:46 ` Peter Korsgaard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox