Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH resend] Added protobuf package
@ 2012-03-15  8:51 Simon Dawson
  2012-04-05 17:50 ` Peter Korsgaard
  0 siblings, 1 reply; 2+ messages in thread
From: Simon Dawson @ 2012-03-15  8:51 UTC (permalink / raw)
  To: buildroot

Signed-off-by: Simon Dawson <spdawson@gmail.com>

---
 package/Config.in            |    1 +
 package/protobuf/Config.in   |    7 +++++++
 package/protobuf/protobuf.mk |   17 +++++++++++++++++
 3 files changed, 25 insertions(+), 0 deletions(-)
 create mode 100644 package/protobuf/Config.in
 create mode 100644 package/protobuf/protobuf.mk

diff --git a/package/Config.in b/package/Config.in
index 36a221c..575373a 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -388,6 +388,7 @@ source "package/liburcu/Config.in"
 source "package/lttng-libust/Config.in"
 source "package/orc/Config.in"
 source "package/poco/Config.in"
+source "package/protobuf/Config.in"
 source "package/startup-notification/Config.in"
 endmenu

diff --git a/package/protobuf/Config.in b/package/protobuf/Config.in
new file mode 100644
index 0000000..1b0085b
--- /dev/null
+++ b/package/protobuf/Config.in
@@ -0,0 +1,7 @@
+config BR2_PACKAGE_PROTOBUF
+       bool "protobuf"
+       help
+         Protocol buffers are Google's language-neutral, platform-neutral,
+         extensible mechanism for serializing structured data.
+
+         http://code.google.com/p/protobuf/
diff --git a/package/protobuf/protobuf.mk b/package/protobuf/protobuf.mk
new file mode 100644
index 0000000..b810795
--- /dev/null
+++ b/package/protobuf/protobuf.mk
@@ -0,0 +1,17 @@
+#############################################################
+#
+# protobuf
+#
+#############################################################
+PROTOBUF_VERSION = 2.4.1
+PROTOBUF_SOURCE = protobuf-$(PROTOBUF_VERSION).tar.gz
+PROTOBUF_SITE = http://protobuf.googlecode.com/files/
+
+# N.B. Need to use host protoc during cross compilation.
+PROTOBUF_DEPENDENCIES = host-protobuf
+PROTOBUF_CONF_OPT = --with-protoc=$(HOST_DIR)/usr/bin/protoc
+
+PROTOBUF_INSTALL_STAGING = YES
+
+$(eval $(call AUTOTARGETS))
+$(eval $(call AUTOTARGETS,host))

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [Buildroot] [PATCH resend] Added protobuf package
  2012-03-15  8:51 [Buildroot] [PATCH resend] Added protobuf package Simon Dawson
@ 2012-04-05 17:50 ` Peter Korsgaard
  0 siblings, 0 replies; 2+ messages in thread
From: Peter Korsgaard @ 2012-04-05 17:50 UTC (permalink / raw)
  To: buildroot

>>>>> "Simon" == Simon Dawson <spdawson@gmail.com> writes:

 Simon> Signed-off-by: Simon Dawson <spdawson@gmail.com>
 Simon> ---
 Simon>  package/Config.in            |    1 +
 Simon>  package/protobuf/Config.in   |    7 +++++++
 Simon>  package/protobuf/protobuf.mk |   17 +++++++++++++++++
 Simon>  3 files changed, 25 insertions(+), 0 deletions(-)
 Simon>  create mode 100644 package/protobuf/Config.in
 Simon>  create mode 100644 package/protobuf/protobuf.mk

 Simon> diff --git a/package/Config.in b/package/Config.in
 Simon> index 36a221c..575373a 100644
 Simon> --- a/package/Config.in
 Simon> +++ b/package/Config.in
 Simon> @@ -388,6 +388,7 @@ source "package/liburcu/Config.in"
 Simon>  source "package/lttng-libust/Config.in"
 Simon>  source "package/orc/Config.in"
 Simon>  source "package/poco/Config.in"
 Simon> +source "package/protobuf/Config.in"
 Simon>  source "package/startup-notification/Config.in"
 Simon>  endmenu

 Simon> diff --git a/package/protobuf/Config.in b/package/protobuf/Config.in
 Simon> new file mode 100644
 Simon> index 0000000..1b0085b
 Simon> --- /dev/null
 Simon> +++ b/package/protobuf/Config.in
 Simon> @@ -0,0 +1,7 @@
 Simon> +config BR2_PACKAGE_PROTOBUF
 Simon> +       bool "protobuf"
 Simon> +       help
 Simon> +         Protocol buffers are Google's language-neutral, platform-neutral,

These lines should be indented with <tab> and not spaces (help lines
with <tab><space><space>)

Protobuf is implemented in C++, so it should depend on
BR2_INSTALL_LIBSTDCPP.

 Simon> +# N.B. Need to use host protoc during cross compilation.
 Simon> +PROTOBUF_DEPENDENCIES = host-protobuf
 Simon> +PROTOBUF_CONF_OPT = --with-protoc=$(HOST_DIR)/usr/bin/protoc
 Simon> +
 Simon> +PROTOBUF_INSTALL_STAGING = YES
 Simon> +

protobuf can use zlib, so we need to ensure it gets built after it if
enabled.

Committed with those fixes, thanks.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-04-05 17:50 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-03-15  8:51 [Buildroot] [PATCH resend] Added protobuf package Simon Dawson
2012-04-05 17:50 ` Peter Korsgaard

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox