Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] Make the MESSAGE Macro work
@ 2008-11-05 17:16 hartleys
  2008-11-05 19:15 ` Peter Korsgaard
  2008-11-07  8:58 ` Peter Korsgaard
  0 siblings, 2 replies; 3+ messages in thread
From: hartleys @ 2008-11-05 17:16 UTC (permalink / raw)
  To: buildroot

Hello all,

The following patch makes the MESSAGE Macro in Makefile.autotools.in
work.

I think it was originally intended to print the messages in bold type
but it doesn't appear to work correctly. This patch should work on all
platforms.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>

---

--- package/Makefile.autotools.in.orig	2008-11-05 10:01:49.000000000
-0700
+++ package/Makefile.autotools.in	2008-11-05 10:08:25.000000000
-0700
@@ -114,8 +114,8 @@
 
 # MESSAGE Macro -- display a message in bold type
 MESSAGE = @echo "$(TERM_BOLD)>>> $($(PKG)_NAME) $($(PKG)_VERSION)
$(1)$(TERM_RESET)"
-TERM_BOLD = #$(shell tput bold)
-TERM_RESET = #$(shell tput rmso)
+TERM_BOLD = $(shell tput smso)
+TERM_RESET = $(shell tput rmso)
 
 # Utility programs used to build packages
 TAR ?= tar 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH] Make the MESSAGE Macro work
  2008-11-05 17:16 [Buildroot] [PATCH] Make the MESSAGE Macro work hartleys
@ 2008-11-05 19:15 ` Peter Korsgaard
  2008-11-07  8:58 ` Peter Korsgaard
  1 sibling, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2008-11-05 19:15 UTC (permalink / raw)
  To: buildroot

>>>>> "hartleys" == hartleys  <hartleys@visionengravers.com> writes:

 hartleys> Hello all,
 hartleys> The following patch makes the MESSAGE Macro in Makefile.autotools.in
 hartleys> work.

 hartleys> I think it was originally intended to print the messages in bold type
 hartleys> but it doesn't appear to work correctly. This patch should work on all
 hartleys> platforms.
 
 hartleys>  # MESSAGE Macro -- display a message in bold type
 hartleys>  MESSAGE = @echo "$(TERM_BOLD)>>> $($(PKG)_NAME) $($(PKG)_VERSION)
 hartleys> $(1)$(TERM_RESET)"
 hartleys> -TERM_BOLD = #$(shell tput bold)
 hartleys> -TERM_RESET = #$(shell tput rmso)
 hartleys> +TERM_BOLD = $(shell tput smso)
 hartleys> +TERM_RESET = $(shell tput rmso)

These should probably be := so we don't end up with tons of tput
calls.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH] Make the MESSAGE Macro work
  2008-11-05 17:16 [Buildroot] [PATCH] Make the MESSAGE Macro work hartleys
  2008-11-05 19:15 ` Peter Korsgaard
@ 2008-11-07  8:58 ` Peter Korsgaard
  1 sibling, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2008-11-07  8:58 UTC (permalink / raw)
  To: buildroot

>>>>> "hartleys" == hartleys  <hartleys@visionengravers.com> writes:

 hartleys> Hello all,
 hartleys> The following patch makes the MESSAGE Macro in Makefile.autotools.in
 hartleys> work.

 hartleys> I think it was originally intended to print the messages in bold type
 hartleys> but it doesn't appear to work correctly. This patch should work on all

Thanks, committed (with :=) as r23955.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2008-11-07  8:58 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-11-05 17:16 [Buildroot] [PATCH] Make the MESSAGE Macro work hartleys
2008-11-05 19:15 ` Peter Korsgaard
2008-11-07  8:58 ` Peter Korsgaard

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox