Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] package/kvm-unit-tests: Fix build on big endian aarch64 targets
@ 2022-05-29 16:56 Thomas Huth
  2022-05-30  8:43 ` Cornelia Huck
  2022-05-30 21:44 ` Thomas Petazzoni via buildroot
  0 siblings, 2 replies; 3+ messages in thread
From: Thomas Huth @ 2022-05-29 16:56 UTC (permalink / raw)
  To: buildroot; +Cc: Cornelia Huck, Cyril Bur, Matt Weber

When building with BR2_cortex_a76 in big endian mode, the build of
the kvm-unit-tests is currently failing since the "--arch" option
of the configure script is not set right. We also have to look at
BR2_aarch64_be in this case to get this initialized properly.

Fixes: f7228dadd371 ("package/kvm-unit-tests: add more arm support")
Signed-off-by: Thomas Huth <huth@tuxfamily.org>
---
 A failing build log can be seen here, for example:
 http://autobuild.buildroot.net/results/760f43a2780b78c753e6b5d631cb744db896f575/build-end.log

 package/kvm-unit-tests/kvm-unit-tests.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/kvm-unit-tests/kvm-unit-tests.mk b/package/kvm-unit-tests/kvm-unit-tests.mk
index fd07ca85c3..dd8f153710 100644
--- a/package/kvm-unit-tests/kvm-unit-tests.mk
+++ b/package/kvm-unit-tests/kvm-unit-tests.mk
@@ -10,7 +10,7 @@ KVM_UNIT_TESTS_SITE = https://gitlab.com/kvm-unit-tests/kvm-unit-tests/-/archive
 KVM_UNIT_TESTS_LICENSE = GPL-2.0, LGPL-2.0
 KVM_UNIT_TESTS_LICENSE_FILES = COPYRIGHT
 
-ifeq ($(BR2_aarch64),y)
+ifeq ($(BR2_aarch64)$(BR2_aarch64_be),y)
 KVM_UNIT_TESTS_ARCH = aarch64
 else ifeq ($(BR2_arm),y)
 KVM_UNIT_TESTS_ARCH = arm
-- 
2.36.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [Buildroot] [PATCH] package/kvm-unit-tests: Fix build on big endian aarch64 targets
  2022-05-29 16:56 [Buildroot] [PATCH] package/kvm-unit-tests: Fix build on big endian aarch64 targets Thomas Huth
@ 2022-05-30  8:43 ` Cornelia Huck
  2022-05-30 21:44 ` Thomas Petazzoni via buildroot
  1 sibling, 0 replies; 3+ messages in thread
From: Cornelia Huck @ 2022-05-30  8:43 UTC (permalink / raw)
  To: Thomas Huth, buildroot; +Cc: Cyril Bur, Matt Weber

On Sun, May 29 2022, Thomas Huth <huth@tuxfamily.org> wrote:

> When building with BR2_cortex_a76 in big endian mode, the build of
> the kvm-unit-tests is currently failing since the "--arch" option
> of the configure script is not set right. We also have to look at
> BR2_aarch64_be in this case to get this initialized properly.
>
> Fixes: f7228dadd371 ("package/kvm-unit-tests: add more arm support")
> Signed-off-by: Thomas Huth <huth@tuxfamily.org>
> ---
>  A failing build log can be seen here, for example:
>  http://autobuild.buildroot.net/results/760f43a2780b78c753e6b5d631cb744db896f575/build-end.log
>
>  package/kvm-unit-tests/kvm-unit-tests.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Ah, I had only tested LE, sorry about that.

Reviewed-by: Cornelia Huck <cohuck@redhat.com>

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [Buildroot] [PATCH] package/kvm-unit-tests: Fix build on big endian aarch64 targets
  2022-05-29 16:56 [Buildroot] [PATCH] package/kvm-unit-tests: Fix build on big endian aarch64 targets Thomas Huth
  2022-05-30  8:43 ` Cornelia Huck
@ 2022-05-30 21:44 ` Thomas Petazzoni via buildroot
  1 sibling, 0 replies; 3+ messages in thread
From: Thomas Petazzoni via buildroot @ 2022-05-30 21:44 UTC (permalink / raw)
  To: Thomas Huth; +Cc: Cornelia Huck, Matt Weber, Cyril Bur, buildroot

On Sun, 29 May 2022 18:56:16 +0200
Thomas Huth <huth@tuxfamily.org> wrote:

> When building with BR2_cortex_a76 in big endian mode, the build of
> the kvm-unit-tests is currently failing since the "--arch" option
> of the configure script is not set right. We also have to look at
> BR2_aarch64_be in this case to get this initialized properly.
> 
> Fixes: f7228dadd371 ("package/kvm-unit-tests: add more arm support")
> Signed-off-by: Thomas Huth <huth@tuxfamily.org>
> ---
>  A failing build log can be seen here, for example:
>  http://autobuild.buildroot.net/results/760f43a2780b78c753e6b5d631cb744db896f575/build-end.log

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-05-30 21:44 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-05-29 16:56 [Buildroot] [PATCH] package/kvm-unit-tests: Fix build on big endian aarch64 targets Thomas Huth
2022-05-30  8:43 ` Cornelia Huck
2022-05-30 21:44 ` Thomas Petazzoni via buildroot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox