Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH v2 1/2] e2fsprogs: fix missing fallocate64() on nios2
@ 2014-02-20 21:59 Frank Bergmann
  2014-02-20 21:59 ` [Buildroot] [PATCH v2 2/2] e2fsprogs: disable e4defrag for nios Frank Bergmann
  2014-02-27 13:36 ` [Buildroot] [PATCH v2 1/2] e2fsprogs: fix missing fallocate64() on nios2 Peter Korsgaard
  0 siblings, 2 replies; 4+ messages in thread
From: Frank Bergmann @ 2014-02-20 21:59 UTC (permalink / raw)
  To: buildroot

(external) nios2 toolchain is currently missing the fallocate64 system
call. Because of compiling the e2fsprogs package with _FILE_OFFSET_BITS=64,
_LARGEFILE_SOURCE and _LARGEFILE64_SOURCE the fallocate call is replaced
by fallocate64 by the glibc. Therefore fallocate is entirely disabled while
configuring the package.

Fixes http://autobuild.buildroot.org/results/70a/70a47bd7392560cbc1c64769c8357c0b4c91ca3b/

Signed-off-by: Frank Bergmann <frank@frajasalo.de>
---
 package/e2fsprogs/e2fsprogs.mk |    4 ++++
 1 file changed, 4 insertions(+)

diff --git a/package/e2fsprogs/e2fsprogs.mk b/package/e2fsprogs/e2fsprogs.mk
index 2eb59f5..76e2d4e 100644
--- a/package/e2fsprogs/e2fsprogs.mk
+++ b/package/e2fsprogs/e2fsprogs.mk
@@ -25,6 +25,10 @@ E2FSPROGS_CONF_OPT = \
 	--disable-e2initrd-helper \
 	--disable-testio-debug
 
+ifeq ($(BR2_nios2),y)
+E2FSPROGS_CONF_ENV += ac_cv_func_fallocate=no
+endif
+
 E2FSPROGS_DEPENDENCIES = host-pkgconf util-linux
 
 E2FSPROGS_MAKE_OPT = \
-- 
1.7.10.4

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [Buildroot] [PATCH v2 2/2] e2fsprogs: disable e4defrag for nios
  2014-02-20 21:59 [Buildroot] [PATCH v2 1/2] e2fsprogs: fix missing fallocate64() on nios2 Frank Bergmann
@ 2014-02-20 21:59 ` Frank Bergmann
  2014-02-27 13:36   ` Peter Korsgaard
  2014-02-27 13:36 ` [Buildroot] [PATCH v2 1/2] e2fsprogs: fix missing fallocate64() on nios2 Peter Korsgaard
  1 sibling, 1 reply; 4+ messages in thread
From: Frank Bergmann @ 2014-02-20 21:59 UTC (permalink / raw)
  To: buildroot

e4defrag has to be disabled because of the (external) toolchain declares
the fallocate64 call in the header files but don't implement it in the
library. e4defrag defines its own fallocate64 function that throws an
error because of the previous declaration in the toolchain header.

Signed-off-by: Frank Bergmann <frank@frajasalo.de>
---
 package/e2fsprogs/Config.in |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/e2fsprogs/Config.in b/package/e2fsprogs/Config.in
index 7775e94..1e87aef 100644
--- a/package/e2fsprogs/Config.in
+++ b/package/e2fsprogs/Config.in
@@ -49,7 +49,7 @@ config BR2_PACKAGE_E2FSPROGS_E2UNDO
 
 config BR2_PACKAGE_E2FSPROGS_E4DEFRAG
 	bool "e4defrag"
-	depends on !BR2_avr32 # fallocate not implemented
+	depends on !BR2_avr32 && !BR2_nios2 # fallocate not implemented
 
 config BR2_PACKAGE_E2FSPROGS_FILEFRAG
 	bool "filefrag"
-- 
1.7.10.4

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [Buildroot] [PATCH v2 1/2] e2fsprogs: fix missing fallocate64() on nios2
  2014-02-20 21:59 [Buildroot] [PATCH v2 1/2] e2fsprogs: fix missing fallocate64() on nios2 Frank Bergmann
  2014-02-20 21:59 ` [Buildroot] [PATCH v2 2/2] e2fsprogs: disable e4defrag for nios Frank Bergmann
@ 2014-02-27 13:36 ` Peter Korsgaard
  1 sibling, 0 replies; 4+ messages in thread
From: Peter Korsgaard @ 2014-02-27 13:36 UTC (permalink / raw)
  To: buildroot

>>>>> "Frank" == Frank Bergmann <frank@frajasalo.de> writes:

 > (external) nios2 toolchain is currently missing the fallocate64 system
 > call. Because of compiling the e2fsprogs package with _FILE_OFFSET_BITS=64,
 > _LARGEFILE_SOURCE and _LARGEFILE64_SOURCE the fallocate call is replaced
 > by fallocate64 by the glibc. Therefore fallocate is entirely disabled while
 > configuring the package.

 > Fixes http://autobuild.buildroot.org/results/70a/70a47bd7392560cbc1c64769c8357c0b4c91ca3b/

Ups, this was the one I committed, not v1.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Buildroot] [PATCH v2 2/2] e2fsprogs: disable e4defrag for nios
  2014-02-20 21:59 ` [Buildroot] [PATCH v2 2/2] e2fsprogs: disable e4defrag for nios Frank Bergmann
@ 2014-02-27 13:36   ` Peter Korsgaard
  0 siblings, 0 replies; 4+ messages in thread
From: Peter Korsgaard @ 2014-02-27 13:36 UTC (permalink / raw)
  To: buildroot

>>>>> "Frank" == Frank Bergmann <frank@frajasalo.de> writes:

 > e4defrag has to be disabled because of the (external) toolchain declares
 > the fallocate64 call in the header files but don't implement it in the
 > library. e4defrag defines its own fallocate64 function that throws an
 > error because of the previous declaration in the toolchain header.

 > Signed-off-by: Frank Bergmann <frank@frajasalo.de>

Committed, thanks.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2014-02-27 13:36 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-02-20 21:59 [Buildroot] [PATCH v2 1/2] e2fsprogs: fix missing fallocate64() on nios2 Frank Bergmann
2014-02-20 21:59 ` [Buildroot] [PATCH v2 2/2] e2fsprogs: disable e4defrag for nios Frank Bergmann
2014-02-27 13:36   ` Peter Korsgaard
2014-02-27 13:36 ` [Buildroot] [PATCH v2 1/2] e2fsprogs: fix missing fallocate64() on nios2 Peter Korsgaard

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox