Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 13/14] libelementary: Add new package
Date: Sun, 29 Jan 2012 22:36:36 +0100	[thread overview]
Message-ID: <87aa56i42j.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <CAFbHwiTeF+Q5AT5hPws9M=S2cdtc6_Vq2mNcf+u8vu_7UksOBg@mail.gmail.com> (Will Newton's message of "Thu, 26 Jan 2012 17:42:56 +0000")

>>>>> "Will" == Will Newton <will.newton@gmail.com> writes:

 Will> Signed-off-by: Will Newton <will.newton@imgtec.com>
 Will> Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>

Committed with minor tweak, thanks.

 Will> diff --git a/package/efl/libelementary/Config.in
 Will> b/package/efl/libelementary/Config.in
 Will> new file mode 100644
 Will> index 0000000..507f142
 Will> --- /dev/null
 Will> +++ b/package/efl/libelementary/Config.in
 Will> @@ -0,0 +1,19 @@
 Will> +config BR2_PACKAGE_LIBELEMENTARY
 Will> +	bool "libelementary"
 Will> +	select BR2_PACKAGE_LIBEINA
 Will> +	select BR2_PACKAGE_LIBEVAS
 Will> +	select BR2_PACKAGE_LIBECORE
 Will> +	select BR2_PACKAGE_LIBEDJE
 Will> +	help
 Will> +	  Elementary is a widget toolkit and EFL wrapper and convenience
 Will> +	  library to make it easy to build applications and tools with UIs
 Will> +	  with less code.
 Will> +

Missing upstream URL.


 Will> +if BR2_PACKAGE_LIBELEMENTARY
 Will> +
 Will> +config BR2_PACKAGE_LIBELEMENTARY_EXAMPLES
 Will> +	bool "libelementary examples"
 Will> +	help
 Will> +	  Build and install the elemenatry examples.
 Will> +

I agree with Arnout here, so I dropped this option. Once this is fixed
upstream we can re-add it if you like.

 Will> b/package/efl/libelementary/libelementary-0.8.0.65643-examples1.patch
 Will> new file mode 100644
 Will> index 0000000..9b81ab6
 Will> --- /dev/null
 Will> +++ b/package/efl/libelementary/libelementary-0.8.0.65643-examples1.patch
 Will> @@ -0,0 +1,10 @@
 Will> +index_example01 requires a dict.txt file containing strings that does
 Will> not seem to be
 Will> +included in the snapshot. Add a dumym file to allow it to build.

Have these been sent upstream? Please add a git-style Signed-off-by line
in the patch header in the future.

-- 
Bye, Peter Korsgaard

  reply	other threads:[~2012-01-29 21:36 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-26 17:42 [Buildroot] [PATCH 13/14] libelementary: Add new package Will Newton
2012-01-29 21:36 ` Peter Korsgaard [this message]
2012-01-31 10:43   ` Will Newton
  -- strict thread matches above, loose matches on Subject: below --
2012-01-23 16:36 Will Newton
2012-01-23 22:39 ` Arnout Vandecappelle
2012-01-29 21:34   ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87aa56i42j.fsf@macbook.be.48ers.dk \
    --to=jacmet@uclibc.org \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox