Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 13/14] libelementary: Add new package
@ 2012-01-23 16:36 Will Newton
  2012-01-23 22:39 ` Arnout Vandecappelle
  0 siblings, 1 reply; 6+ messages in thread
From: Will Newton @ 2012-01-23 16:36 UTC (permalink / raw)
  To: buildroot

Signed-off-by: Will Newton <will.newton@imgtec.com>
---
 package/efl/Config.in                              |    1 +
 package/efl/libelementary/Config.in                |   19 ++++
 .../libelementary-0.8.0.65643-examples1.patch      |   10 ++
 .../libelementary-0.8.0.65643-examples2.patch      |   96 ++++++++++++++++++++
 package/efl/libelementary/libelementary.mk         |   22 +++++
 5 files changed, 148 insertions(+), 0 deletions(-)
 create mode 100644 package/efl/libelementary/Config.in
 create mode 100644
package/efl/libelementary/libelementary-0.8.0.65643-examples1.patch
 create mode 100644
package/efl/libelementary/libelementary-0.8.0.65643-examples2.patch
 create mode 100644 package/efl/libelementary/libelementary.mk

diff --git a/package/efl/Config.in b/package/efl/Config.in
index 1632290..ec8c513 100644
--- a/package/efl/Config.in
+++ b/package/efl/Config.in
@@ -17,6 +17,7 @@ source "package/efl/libevas/Config.in"
 source "package/efl/libembryo/Config.in"
 source "package/efl/libedje/Config.in"
 source "package/efl/libethumb/Config.in"
+source "package/efl/libelementary/Config.in"

 endif # BR2_PACKAGE_EFL

diff --git a/package/efl/libelementary/Config.in
b/package/efl/libelementary/Config.in
new file mode 100644
index 0000000..507f142
--- /dev/null
+++ b/package/efl/libelementary/Config.in
@@ -0,0 +1,19 @@
+config BR2_PACKAGE_LIBELEMENTARY
+	bool "libelementary"
+	select BR2_PACKAGE_LIBEINA
+	select BR2_PACKAGE_LIBEVAS
+	select BR2_PACKAGE_LIBECORE
+	select BR2_PACKAGE_LIBEDJE
+	help
+	  Elementary is a widget toolkit and EFL wrapper and convenience
+	  library to make it easy to build applications and tools with UIs
+	  with less code.
+
+if BR2_PACKAGE_LIBELEMENTARY
+
+config BR2_PACKAGE_LIBELEMENTARY_EXAMPLES
+	bool "libelementary examples"
+	help
+	  Build and install the elemenatry examples.
+
+endif
diff --git a/package/efl/libelementary/libelementary-0.8.0.65643-examples1.patch
b/package/efl/libelementary/libelementary-0.8.0.65643-examples1.patch
new file mode 100644
index 0000000..9b81ab6
--- /dev/null
+++ b/package/efl/libelementary/libelementary-0.8.0.65643-examples1.patch
@@ -0,0 +1,10 @@
+index_example01 requires a dict.txt file containing strings that does
not seem to be
+included in the snapshot. Add a dumym file to allow it to build.
+
+--- libelementary-0.8.0.65643/src/examples/dict.txt	1970-01-01
01:00:00.000000000 +0100
++++ libelementary-0.8.0.65643.mod/src/examples/dict.txt	2012-01-19
17:37:08.321913533 +0000
+@@ -0,0 +1,4 @@
++"aardvark",
++"abnegates",
++"accordion",
++"adroitly",
diff --git a/package/efl/libelementary/libelementary-0.8.0.65643-examples2.patch
b/package/efl/libelementary/libelementary-0.8.0.65643-examples2.patch
new file mode 100644
index 0000000..5e40224
--- /dev/null
+++ b/package/efl/libelementary/libelementary-0.8.0.65643-examples2.patch
@@ -0,0 +1,96 @@
+win_example requires X11 support in EFL, so disable building it. The
.edj files also appear
+to be missing from the snapshot so remove them from the build.
+
+--- libelementary-0.8.0.65643/src/examples/Makefile.in	2011-11-28
11:06:20.000000000 +0000
++++ libelementary-0.8.0.65643.mod/src/examples/Makefile.in	2012-01-19
17:51:53.761924528 +0000
+@@ -39,8 +39,6 @@
+ @EFL_INSTALL_EXAMPLES_TRUE@	dict.txt
+
+ @EFL_BUILD_EXAMPLES_TRUE at am__append_2 = \
+- at EFL_BUILD_EXAMPLES_TRUE@	theme_example.edj \
+- at EFL_BUILD_EXAMPLES_TRUE@	layout_example.edj
+
+ @EFL_BUILD_EXAMPLES_TRUE at am__append_3 = \
+ @EFL_BUILD_EXAMPLES_TRUE@	actionslider_example_01 \
+@@ -125,7 +123,6 @@
+ @EFL_BUILD_EXAMPLES_TRUE@	menu_example_01 \
+ @EFL_BUILD_EXAMPLES_TRUE@	thumb_example_01 \
+ @EFL_BUILD_EXAMPLES_TRUE@	web_example \
+- at EFL_BUILD_EXAMPLES_TRUE@	win_example \
+ @EFL_BUILD_EXAMPLES_TRUE@        efl_thread_1 \
+ @EFL_BUILD_EXAMPLES_TRUE@        efl_thread_2 \
+ @EFL_BUILD_EXAMPLES_TRUE@        efl_thread_3 \
+@@ -239,7 +236,6 @@
+ @EFL_BUILD_EXAMPLES_TRUE@	menu_example_01$(EXEEXT) \
+ @EFL_BUILD_EXAMPLES_TRUE@	thumb_example_01$(EXEEXT) \
+ @EFL_BUILD_EXAMPLES_TRUE@	web_example$(EXEEXT) \
+- at EFL_BUILD_EXAMPLES_TRUE@	win_example$(EXEEXT) \
+ @EFL_BUILD_EXAMPLES_TRUE@	efl_thread_1$(EXEEXT) \
+ @EFL_BUILD_EXAMPLES_TRUE@	efl_thread_2$(EXEEXT) \
+ @EFL_BUILD_EXAMPLES_TRUE@	efl_thread_3$(EXEEXT) \
+@@ -679,10 +675,6 @@
+ web_example_OBJECTS = web_example.$(OBJEXT)
+ web_example_LDADD = $(LDADD)
+ web_example_DEPENDENCIES = $(top_builddir)/src/lib/libelementary.la
+-win_example_SOURCES = win_example.c
+-win_example_OBJECTS = win_example.$(OBJEXT)
+-win_example_LDADD = $(LDADD)
+-win_example_DEPENDENCIES = $(top_builddir)/src/lib/libelementary.la
+ DEFAULT_INCLUDES = -I. at am__isrc@ -I$(top_builddir)
+ depcomp = $(SHELL) $(top_srcdir)/depcomp
+ am__depfiles_maybe = depfiles
+@@ -740,8 +732,7 @@
+ 	theme_example_01.c theme_example_02.c thumb_example_01.c \
+ 	toggle_example_01.c toolbar_example_01.c toolbar_example_02.c \
+ 	toolbar_example_03.c transit_example_01.c transit_example_02.c \
+-	transit_example_03.c transit_example_04.c web_example.c \
+-	win_example.c
++	transit_example_03.c transit_example_04.c web_example.c
+ DIST_SOURCES = actionslider_example_01.c anchorblock_example_01.c \
+ 	bg_example_01.c bg_example_02.c bg_example_03.c \
+ 	box_example_02.c bubble_example_01.c button_example_01.c \
+@@ -773,8 +764,7 @@
+ 	theme_example_01.c theme_example_02.c thumb_example_01.c \
+ 	toggle_example_01.c toolbar_example_01.c toolbar_example_02.c \
+ 	toolbar_example_03.c transit_example_01.c transit_example_02.c \
+-	transit_example_03.c transit_example_04.c web_example.c \
+-	win_example.c
++	transit_example_03.c transit_example_04.c web_example.c
+ am__vpath_adj_setup = srcdirstrip=`echo "$(srcdir)" | sed 's|.|.|g'`;
+ am__vpath_adj = case $$p in \
+     $(srcdir)/*) f=`echo "$$p" | sed "s|^$$srcdirstrip/||"`;; \
+@@ -1097,8 +1087,6 @@
+ 	genlist_example_03.c \
+ 	genlist_example_04.c \
+ 	genlist_example_05.c \
+-	theme_example.edc \
+-	layout_example.edc \
+ 	slider_example.c \
+ 	panes_example.c \
+ 	ctxpopup_example_01.c \
+@@ -1119,7 +1107,6 @@
+ 	menu_example_01.c \
+ 	thumb_example_01.c \
+ 	web_example.c \
+-	win_example.c \
+         efl_thread_1.c \
+         efl_thread_2.c \
+         efl_thread_3.c \
+@@ -1550,9 +1537,6 @@
+ web_example$(EXEEXT): $(web_example_OBJECTS) $(web_example_DEPENDENCIES)
+ 	@rm -f web_example$(EXEEXT)
+ 	$(AM_V_CCLD)$(LINK) $(web_example_OBJECTS) $(web_example_LDADD) $(LIBS)
+-win_example$(EXEEXT): $(win_example_OBJECTS) $(win_example_DEPENDENCIES)
+-	@rm -f win_example$(EXEEXT)
+-	$(AM_V_CCLD)$(LINK) $(win_example_OBJECTS) $(win_example_LDADD) $(LIBS)
+
+ mostlyclean-compile:
+ 	-rm -f *.$(OBJEXT)
+@@ -1648,7 +1632,6 @@
+ @AMDEP_TRUE@@am__include@
@am__quote at ./$(DEPDIR)/transit_example_03.Po at am__quote@
+ @AMDEP_TRUE@@am__include@
@am__quote at ./$(DEPDIR)/transit_example_04.Po at am__quote@
+ @AMDEP_TRUE@@am__include@ @am__quote at ./$(DEPDIR)/web_example.Po at am__quote@
+- at AMDEP_TRUE@@am__include@ @am__quote at ./$(DEPDIR)/win_example.Po at am__quote@
+
+ .c.o:
+ @am__fastdepCC_TRUE@	$(AM_V_CC)$(COMPILE) -MT $@ -MD -MP -MF
$(DEPDIR)/$*.Tpo -c -o $@ $<
diff --git a/package/efl/libelementary/libelementary.mk
b/package/efl/libelementary/libelementary.mk
new file mode 100644
index 0000000..e0bd759
--- /dev/null
+++ b/package/efl/libelementary/libelementary.mk
@@ -0,0 +1,22 @@
+################################################################################
+#
+# libelementary
+#
+################################################################################
+
+LIBELEMENTARY_VERSION = 0.8.0.65643
+LIBELEMENTARY_SOURCE = elementary-$(LIBELEMENTARY_VERSION).tar.bz2
+LIBELEMENTARY_SITE = http://download.enlightenment.org/snapshots/2011-11-28
+LIBELEMENTARY_INSTALL_STAGING = YES
+
+LIBELEMENTARY_DEPENDENCIES = libeina libevas libecore libedje host-libedje \
+				host-libeet
+
+LIBELEMENTARY_CONF_OPT = --with-edje-cc=$(HOST_DIR)/usr/bin/edje_cc \
+			 --with-eet-eet=$(HOST_DIR)/usr/bin/eet
+
+ifeq ($(BR2_PACKAGE_LIBELEMENTARY_EXAMPLES),y)
+LIBELEMENTARY_CONF_OPT += --enable-build-examples --enable-install-examples
+endif
+
+$(eval $(call AUTOTARGETS))
-- 
1.7.1
-------------- next part --------------

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [Buildroot] [PATCH 13/14] libelementary: Add new package
  2012-01-23 16:36 Will Newton
@ 2012-01-23 22:39 ` Arnout Vandecappelle
  2012-01-29 21:34   ` Peter Korsgaard
  0 siblings, 1 reply; 6+ messages in thread
From: Arnout Vandecappelle @ 2012-01-23 22:39 UTC (permalink / raw)
  To: buildroot

On Monday 23 January 2012 17:36:21 Will Newton wrote:
> Signed-off-by: Will Newton <will.newton@imgtec.com>
Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>

[snip]
> +config BR2_PACKAGE_LIBELEMENTARY_EXAMPLES
> +       bool "libelementary examples"
> +       help
> +         Build and install the elemenatry examples.

 Are the examples so interesting that they warrant installation on the 
target?  I mean, I would expect the typical user to experiment with EFL
on the host, and just compile the final application for the target.
If building the example requires two patches (which will have to be
ported when upgrading libelementary), I'm not sure if the benefit is
worth the effort.

 Regards,
 Arnout

-- 
Arnout Vandecappelle                               arnout at mind be
Senior Embedded Software Architect                 +32-16-286540
Essensium/Mind                                     http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium                BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Buildroot] [PATCH 13/14] libelementary: Add new package
@ 2012-01-26 17:42 Will Newton
  2012-01-29 21:36 ` Peter Korsgaard
  0 siblings, 1 reply; 6+ messages in thread
From: Will Newton @ 2012-01-26 17:42 UTC (permalink / raw)
  To: buildroot

Signed-off-by: Will Newton <will.newton@imgtec.com>
Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
---
 package/efl/Config.in                              |    1 +
 package/efl/libelementary/Config.in                |   19 ++++
 .../libelementary-0.8.0.65643-examples1.patch      |   10 ++
 .../libelementary-0.8.0.65643-examples2.patch      |   96 ++++++++++++++++++++
 package/efl/libelementary/libelementary.mk         |   22 +++++
 5 files changed, 148 insertions(+), 0 deletions(-)
 create mode 100644 package/efl/libelementary/Config.in
 create mode 100644
package/efl/libelementary/libelementary-0.8.0.65643-examples1.patch
 create mode 100644
package/efl/libelementary/libelementary-0.8.0.65643-examples2.patch
 create mode 100644 package/efl/libelementary/libelementary.mk

diff --git a/package/efl/Config.in b/package/efl/Config.in
index 1632290..ec8c513 100644
--- a/package/efl/Config.in
+++ b/package/efl/Config.in
@@ -17,6 +17,7 @@ source "package/efl/libevas/Config.in"
 source "package/efl/libembryo/Config.in"
 source "package/efl/libedje/Config.in"
 source "package/efl/libethumb/Config.in"
+source "package/efl/libelementary/Config.in"

 endif # BR2_PACKAGE_EFL

diff --git a/package/efl/libelementary/Config.in
b/package/efl/libelementary/Config.in
new file mode 100644
index 0000000..507f142
--- /dev/null
+++ b/package/efl/libelementary/Config.in
@@ -0,0 +1,19 @@
+config BR2_PACKAGE_LIBELEMENTARY
+	bool "libelementary"
+	select BR2_PACKAGE_LIBEINA
+	select BR2_PACKAGE_LIBEVAS
+	select BR2_PACKAGE_LIBECORE
+	select BR2_PACKAGE_LIBEDJE
+	help
+	  Elementary is a widget toolkit and EFL wrapper and convenience
+	  library to make it easy to build applications and tools with UIs
+	  with less code.
+
+if BR2_PACKAGE_LIBELEMENTARY
+
+config BR2_PACKAGE_LIBELEMENTARY_EXAMPLES
+	bool "libelementary examples"
+	help
+	  Build and install the elemenatry examples.
+
+endif
diff --git a/package/efl/libelementary/libelementary-0.8.0.65643-examples1.patch
b/package/efl/libelementary/libelementary-0.8.0.65643-examples1.patch
new file mode 100644
index 0000000..9b81ab6
--- /dev/null
+++ b/package/efl/libelementary/libelementary-0.8.0.65643-examples1.patch
@@ -0,0 +1,10 @@
+index_example01 requires a dict.txt file containing strings that does
not seem to be
+included in the snapshot. Add a dumym file to allow it to build.
+
+--- libelementary-0.8.0.65643/src/examples/dict.txt	1970-01-01
01:00:00.000000000 +0100
++++ libelementary-0.8.0.65643.mod/src/examples/dict.txt	2012-01-19
17:37:08.321913533 +0000
+@@ -0,0 +1,4 @@
++"aardvark",
++"abnegates",
++"accordion",
++"adroitly",
diff --git a/package/efl/libelementary/libelementary-0.8.0.65643-examples2.patch
b/package/efl/libelementary/libelementary-0.8.0.65643-examples2.patch
new file mode 100644
index 0000000..5e40224
--- /dev/null
+++ b/package/efl/libelementary/libelementary-0.8.0.65643-examples2.patch
@@ -0,0 +1,96 @@
+win_example requires X11 support in EFL, so disable building it. The
.edj files also appear
+to be missing from the snapshot so remove them from the build.
+
+--- libelementary-0.8.0.65643/src/examples/Makefile.in	2011-11-28
11:06:20.000000000 +0000
++++ libelementary-0.8.0.65643.mod/src/examples/Makefile.in	2012-01-19
17:51:53.761924528 +0000
+@@ -39,8 +39,6 @@
+ @EFL_INSTALL_EXAMPLES_TRUE@	dict.txt
+
+ @EFL_BUILD_EXAMPLES_TRUE at am__append_2 = \
+- at EFL_BUILD_EXAMPLES_TRUE@	theme_example.edj \
+- at EFL_BUILD_EXAMPLES_TRUE@	layout_example.edj
+
+ @EFL_BUILD_EXAMPLES_TRUE at am__append_3 = \
+ @EFL_BUILD_EXAMPLES_TRUE@	actionslider_example_01 \
+@@ -125,7 +123,6 @@
+ @EFL_BUILD_EXAMPLES_TRUE@	menu_example_01 \
+ @EFL_BUILD_EXAMPLES_TRUE@	thumb_example_01 \
+ @EFL_BUILD_EXAMPLES_TRUE@	web_example \
+- at EFL_BUILD_EXAMPLES_TRUE@	win_example \
+ @EFL_BUILD_EXAMPLES_TRUE@        efl_thread_1 \
+ @EFL_BUILD_EXAMPLES_TRUE@        efl_thread_2 \
+ @EFL_BUILD_EXAMPLES_TRUE@        efl_thread_3 \
+@@ -239,7 +236,6 @@
+ @EFL_BUILD_EXAMPLES_TRUE@	menu_example_01$(EXEEXT) \
+ @EFL_BUILD_EXAMPLES_TRUE@	thumb_example_01$(EXEEXT) \
+ @EFL_BUILD_EXAMPLES_TRUE@	web_example$(EXEEXT) \
+- at EFL_BUILD_EXAMPLES_TRUE@	win_example$(EXEEXT) \
+ @EFL_BUILD_EXAMPLES_TRUE@	efl_thread_1$(EXEEXT) \
+ @EFL_BUILD_EXAMPLES_TRUE@	efl_thread_2$(EXEEXT) \
+ @EFL_BUILD_EXAMPLES_TRUE@	efl_thread_3$(EXEEXT) \
+@@ -679,10 +675,6 @@
+ web_example_OBJECTS = web_example.$(OBJEXT)
+ web_example_LDADD = $(LDADD)
+ web_example_DEPENDENCIES = $(top_builddir)/src/lib/libelementary.la
+-win_example_SOURCES = win_example.c
+-win_example_OBJECTS = win_example.$(OBJEXT)
+-win_example_LDADD = $(LDADD)
+-win_example_DEPENDENCIES = $(top_builddir)/src/lib/libelementary.la
+ DEFAULT_INCLUDES = -I. at am__isrc@ -I$(top_builddir)
+ depcomp = $(SHELL) $(top_srcdir)/depcomp
+ am__depfiles_maybe = depfiles
+@@ -740,8 +732,7 @@
+ 	theme_example_01.c theme_example_02.c thumb_example_01.c \
+ 	toggle_example_01.c toolbar_example_01.c toolbar_example_02.c \
+ 	toolbar_example_03.c transit_example_01.c transit_example_02.c \
+-	transit_example_03.c transit_example_04.c web_example.c \
+-	win_example.c
++	transit_example_03.c transit_example_04.c web_example.c
+ DIST_SOURCES = actionslider_example_01.c anchorblock_example_01.c \
+ 	bg_example_01.c bg_example_02.c bg_example_03.c \
+ 	box_example_02.c bubble_example_01.c button_example_01.c \
+@@ -773,8 +764,7 @@
+ 	theme_example_01.c theme_example_02.c thumb_example_01.c \
+ 	toggle_example_01.c toolbar_example_01.c toolbar_example_02.c \
+ 	toolbar_example_03.c transit_example_01.c transit_example_02.c \
+-	transit_example_03.c transit_example_04.c web_example.c \
+-	win_example.c
++	transit_example_03.c transit_example_04.c web_example.c
+ am__vpath_adj_setup = srcdirstrip=`echo "$(srcdir)" | sed 's|.|.|g'`;
+ am__vpath_adj = case $$p in \
+     $(srcdir)/*) f=`echo "$$p" | sed "s|^$$srcdirstrip/||"`;; \
+@@ -1097,8 +1087,6 @@
+ 	genlist_example_03.c \
+ 	genlist_example_04.c \
+ 	genlist_example_05.c \
+-	theme_example.edc \
+-	layout_example.edc \
+ 	slider_example.c \
+ 	panes_example.c \
+ 	ctxpopup_example_01.c \
+@@ -1119,7 +1107,6 @@
+ 	menu_example_01.c \
+ 	thumb_example_01.c \
+ 	web_example.c \
+-	win_example.c \
+         efl_thread_1.c \
+         efl_thread_2.c \
+         efl_thread_3.c \
+@@ -1550,9 +1537,6 @@
+ web_example$(EXEEXT): $(web_example_OBJECTS) $(web_example_DEPENDENCIES)
+ 	@rm -f web_example$(EXEEXT)
+ 	$(AM_V_CCLD)$(LINK) $(web_example_OBJECTS) $(web_example_LDADD) $(LIBS)
+-win_example$(EXEEXT): $(win_example_OBJECTS) $(win_example_DEPENDENCIES)
+-	@rm -f win_example$(EXEEXT)
+-	$(AM_V_CCLD)$(LINK) $(win_example_OBJECTS) $(win_example_LDADD) $(LIBS)
+
+ mostlyclean-compile:
+ 	-rm -f *.$(OBJEXT)
+@@ -1648,7 +1632,6 @@
+ @AMDEP_TRUE@@am__include@
@am__quote at ./$(DEPDIR)/transit_example_03.Po at am__quote@
+ @AMDEP_TRUE@@am__include@
@am__quote at ./$(DEPDIR)/transit_example_04.Po at am__quote@
+ @AMDEP_TRUE@@am__include@ @am__quote at ./$(DEPDIR)/web_example.Po at am__quote@
+- at AMDEP_TRUE@@am__include@ @am__quote at ./$(DEPDIR)/win_example.Po at am__quote@
+
+ .c.o:
+ @am__fastdepCC_TRUE@	$(AM_V_CC)$(COMPILE) -MT $@ -MD -MP -MF
$(DEPDIR)/$*.Tpo -c -o $@ $<
diff --git a/package/efl/libelementary/libelementary.mk
b/package/efl/libelementary/libelementary.mk
new file mode 100644
index 0000000..e0bd759
--- /dev/null
+++ b/package/efl/libelementary/libelementary.mk
@@ -0,0 +1,22 @@
+################################################################################
+#
+# libelementary
+#
+################################################################################
+
+LIBELEMENTARY_VERSION = 0.8.0.65643
+LIBELEMENTARY_SOURCE = elementary-$(LIBELEMENTARY_VERSION).tar.bz2
+LIBELEMENTARY_SITE = http://download.enlightenment.org/snapshots/2011-11-28
+LIBELEMENTARY_INSTALL_STAGING = YES
+
+LIBELEMENTARY_DEPENDENCIES = libeina libevas libecore libedje host-libedje \
+				host-libeet
+
+LIBELEMENTARY_CONF_OPT = --with-edje-cc=$(HOST_DIR)/usr/bin/edje_cc \
+			 --with-eet-eet=$(HOST_DIR)/usr/bin/eet
+
+ifeq ($(BR2_PACKAGE_LIBELEMENTARY_EXAMPLES),y)
+LIBELEMENTARY_CONF_OPT += --enable-build-examples --enable-install-examples
+endif
+
+$(eval $(call AUTOTARGETS))
-- 
1.7.1
-------------- next part --------------

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [Buildroot] [PATCH 13/14] libelementary: Add new package
  2012-01-23 22:39 ` Arnout Vandecappelle
@ 2012-01-29 21:34   ` Peter Korsgaard
  0 siblings, 0 replies; 6+ messages in thread
From: Peter Korsgaard @ 2012-01-29 21:34 UTC (permalink / raw)
  To: buildroot

>>>>> "Arnout" == Arnout Vandecappelle <arnout@mind.be> writes:

Hi,

 >> +config BR2_PACKAGE_LIBELEMENTARY_EXAMPLES
 >> +       bool "libelementary examples"
 >> +       help
 >> +         Build and install the elemenatry examples.

 Arnout>  Are the examples so interesting that they warrant installation
 Arnout> on the target?  I mean, I would expect the typical user to
 Arnout> experiment with EFL on the host, and just compile the final
 Arnout> application for the target.  If building the example requires
 Arnout> two patches (which will have to be ported when upgrading
 Arnout> libelementary), I'm not sure if the benefit is worth the
 Arnout> effort.

I agree.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Buildroot] [PATCH 13/14] libelementary: Add new package
  2012-01-26 17:42 [Buildroot] [PATCH 13/14] libelementary: Add new package Will Newton
@ 2012-01-29 21:36 ` Peter Korsgaard
  2012-01-31 10:43   ` Will Newton
  0 siblings, 1 reply; 6+ messages in thread
From: Peter Korsgaard @ 2012-01-29 21:36 UTC (permalink / raw)
  To: buildroot

>>>>> "Will" == Will Newton <will.newton@gmail.com> writes:

 Will> Signed-off-by: Will Newton <will.newton@imgtec.com>
 Will> Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>

Committed with minor tweak, thanks.

 Will> diff --git a/package/efl/libelementary/Config.in
 Will> b/package/efl/libelementary/Config.in
 Will> new file mode 100644
 Will> index 0000000..507f142
 Will> --- /dev/null
 Will> +++ b/package/efl/libelementary/Config.in
 Will> @@ -0,0 +1,19 @@
 Will> +config BR2_PACKAGE_LIBELEMENTARY
 Will> +	bool "libelementary"
 Will> +	select BR2_PACKAGE_LIBEINA
 Will> +	select BR2_PACKAGE_LIBEVAS
 Will> +	select BR2_PACKAGE_LIBECORE
 Will> +	select BR2_PACKAGE_LIBEDJE
 Will> +	help
 Will> +	  Elementary is a widget toolkit and EFL wrapper and convenience
 Will> +	  library to make it easy to build applications and tools with UIs
 Will> +	  with less code.
 Will> +

Missing upstream URL.


 Will> +if BR2_PACKAGE_LIBELEMENTARY
 Will> +
 Will> +config BR2_PACKAGE_LIBELEMENTARY_EXAMPLES
 Will> +	bool "libelementary examples"
 Will> +	help
 Will> +	  Build and install the elemenatry examples.
 Will> +

I agree with Arnout here, so I dropped this option. Once this is fixed
upstream we can re-add it if you like.

 Will> b/package/efl/libelementary/libelementary-0.8.0.65643-examples1.patch
 Will> new file mode 100644
 Will> index 0000000..9b81ab6
 Will> --- /dev/null
 Will> +++ b/package/efl/libelementary/libelementary-0.8.0.65643-examples1.patch
 Will> @@ -0,0 +1,10 @@
 Will> +index_example01 requires a dict.txt file containing strings that does
 Will> not seem to be
 Will> +included in the snapshot. Add a dumym file to allow it to build.

Have these been sent upstream? Please add a git-style Signed-off-by line
in the patch header in the future.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Buildroot] [PATCH 13/14] libelementary: Add new package
  2012-01-29 21:36 ` Peter Korsgaard
@ 2012-01-31 10:43   ` Will Newton
  0 siblings, 0 replies; 6+ messages in thread
From: Will Newton @ 2012-01-31 10:43 UTC (permalink / raw)
  To: buildroot

On Sun, Jan 29, 2012 at 9:36 PM, Peter Korsgaard <jacmet@uclibc.org> wrote:

> ?Will> b/package/efl/libelementary/libelementary-0.8.0.65643-examples1.patch
> ?Will> new file mode 100644
> ?Will> index 0000000..9b81ab6
> ?Will> --- /dev/null
> ?Will> +++ b/package/efl/libelementary/libelementary-0.8.0.65643-examples1.patch
> ?Will> @@ -0,0 +1,10 @@
> ?Will> +index_example01 requires a dict.txt file containing strings that does
> ?Will> not seem to be
> ?Will> +included in the snapshot. Add a dumym file to allow it to build.
>
> Have these been sent upstream? Please add a git-style Signed-off-by line
> in the patch header in the future.

I believe it is fixed in upstream svn. The snapshots seem quite rarely
made (annually?) so it may be some time before a fix is available in a
tarball. There is the option of switching to an svn release but that
can be a slippery slope when you have a number of interconnected
packages like this.

Thanks for your fixes to my patches!

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2012-01-31 10:43 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-01-26 17:42 [Buildroot] [PATCH 13/14] libelementary: Add new package Will Newton
2012-01-29 21:36 ` Peter Korsgaard
2012-01-31 10:43   ` Will Newton
  -- strict thread matches above, loose matches on Subject: below --
2012-01-23 16:36 Will Newton
2012-01-23 22:39 ` Arnout Vandecappelle
2012-01-29 21:34   ` Peter Korsgaard

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox