[Buildroot] [PATCH 3/5] By default, put the output in an output/ directory

[Peter Korsgaard <jacmet@uclibc.org>]

>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:

 Thomas> Instead of putting all the build-related stuff as a mess in the
 Thomas> Buildroot sources, group them in an output/ directory.

 Thomas>  # Buildroot supports building out of tree similarly to the Linux kernel.
 Thomas>  # To use, add O= to the make command line (make O=/tmp/build)
 Thomas> -BASE_DIR:=$(shell pwd)
 Thomas> -ifdef O
 Thomas>  ifeq ("$(origin O)", "command line")
 Thomas>  BASE_DIR := $(shell mkdir -p $(O) && cd $(O) && pwd)
 Thomas>  $(if $(BASE_DIR),, $(error output directory "$(O)" does not exist))
 Thomas> @@ -228,7 +226,8 @@ $(if $(BASE_DIR),, $(error output directory "$(O)" does not exist))
 Thomas>  # forwards command line variable definitions those packages get very
 Thomas>  # confused. Fix this by telling make to not do so
 Thomas>  MAKEOVERRIDES =
 Thomas> -endif
 Thomas> +else
 Thomas> +BASE_DIR := $(shell mkdir -p output && cd output && pwd)
 Thomas>  endif

Wouldn't it be simpler to just pretend we were passed O=output by
default? E.G:

ifneq ("$(origin O)", "command line")
O:=output
endif

BASE_DIR := $(shell mkdir -p $(O) && cd $(O) && pwd)
...

-- 
Bye, Peter Korsgaard