Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/5] Remove the "project" feature
Date: Tue, 08 Sep 2009 09:06:12 +0200	[thread overview]
Message-ID: <87ljkp5317.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <a57f463ae7b50d932282ded660a431251e1de379.1252361088.git.thomas.petazzoni@free-electrons.com> (Thomas Petazzoni's message of "Tue\, 8 Sep 2009 00\:09\:49 +0200")

>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:

Hi,

 Thomas> The "project" feature was designed to allow to several projects
 Thomas> to be built inside the same Buildroot source tree and allowing
 Thomas> the toolchain and non-configurable packages to be shared
 Thomas> between the different projects on the same architecture. While
 Thomas> being interesting in theory, this feature adds a level of
 Thomas> complexity to Buildroot, both from an user perspective and from
 Thomas> a developer perspective, while one of the main Buildroot
 Thomas> strengh is to be simple. Moreover, this feature is only
 Thomas> seldomly used by our users.

I agree, I also don't like the complexity it added.

 Thomas>     - Don't make world depends on target-host-info. This target was
 Thomas>       defined by project/project.mk to customize /etc/issue,
 Thomas>       /etc/hostname and create /etc/br-version depending on the
 Thomas>       project definitions. We can of course imagine re-adding such a
 Thomas>       feature later.

Stuff like /etc/br-version is handy atleast. I think it would be nice to
keep all 3, as it is part of the current Kconfig interface, it makes it
easy to do minimal customization when you use the generic rootfs
skeleton and it adds only little complexity.

 Thomas>  * package/Makefile.autotools.in

 Thomas>     - Replace PROJECT_BUILD_DIR by BUILD_DIR for the location of the
 Thomas>       configure cache

 Thomas>     - Move the INSTALL_TARGET and HOOK_POST_INSTALL stamps to the same
 Thomas>       directory as the other stamps (i.e, in the package directory).

Yeah!

 Thomas>  * target/u-boot/Makefile.in

 Thomas>     - Replace PROJECT_BUILD_DIR by BUILD_DIR

 Thomas>     - Remove $(PROJECT) from the U-Boot target binary name

 Thomas>     - Remove the insertion in the configuration of the project name as
 Thomas>       the hostname

 Thomas>     - The u-boot-autoscript target now generates
 Thomas>       $(U_BOOT_AUTOSCRIPT).img instead of
 Thomas>       $(U_BOOT_AUTOSCRIPT).$(PROJECT)

The u-boot config stuff is imho way too overengineered, and could use
some cleanup/simplification.

-- 
Bye, Peter Korsgaard

  parent reply	other threads:[~2009-09-08  7:06 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-07 22:09 [Buildroot] [RFC] [PATCH 0/5] Buildroot cleanup Thomas Petazzoni
2009-09-07 22:09 ` [Buildroot] [PATCH 1/5] Remove the "project" feature Thomas Petazzoni
2009-09-08  6:27   ` Hans-Christian Egtvedt
2009-09-08  6:58     ` Sven Neumann
2009-09-08  7:07       ` Peter Korsgaard
2009-09-08  7:15         ` Sven Neumann
2009-09-08  7:23           ` Peter Korsgaard
2009-09-08  7:31             ` Thomas Petazzoni
2009-09-08  7:43               ` Peter Korsgaard
2009-09-08  7:49                 ` Thomas Petazzoni
2009-09-08  6:59     ` Peter Korsgaard
2009-09-08  7:16     ` Thomas Petazzoni
2009-09-08  7:06   ` Peter Korsgaard [this message]
     [not found]     ` <20090908092408.787e9cf7@surf>
2009-09-08  7:31       ` Peter Korsgaard
2009-09-07 22:09 ` [Buildroot] [PATCH 2/5] Remove the BOARD/LOCAL feature Thomas Petazzoni
2009-09-07 22:09 ` [Buildroot] [PATCH 3/5] By default, put the output in an output/ directory Thomas Petazzoni
2009-09-09 10:19   ` Peter Korsgaard
2009-09-09 11:28     ` Thomas Petazzoni
2009-09-07 22:09 ` [Buildroot] [PATCH 4/5] Remove BR2_TOPDIR_PREFIX and BR2_TOPDIR_SUFFIX Thomas Petazzoni
2009-09-09 17:35   ` Bernhard Reutner-Fischer
2009-09-10  6:30     ` Thomas Petazzoni
2009-09-10  7:33       ` Peter Korsgaard
2009-09-07 22:09 ` [Buildroot] [PATCH 5/5] Rename the output directories Thomas Petazzoni
2009-09-09  7:02   ` Peter Korsgaard
2009-09-09  7:22     ` Thomas Petazzoni
2009-09-09  7:37       ` Peter Korsgaard
2009-09-08 17:03 ` [Buildroot] [RFC] [PATCH 0/5] Buildroot cleanup Will Newton
2009-09-08 19:13   ` Jonathan dumaresq
2009-09-08 21:20   ` Peter Korsgaard
2009-09-09  9:36     ` Will Newton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ljkp5317.fsf@macbook.be.48ers.dk \
    --to=jacmet@uclibc.org \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox