Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/1] package/sedutil: fix build with gcc >= 13
@ 2023-10-30  8:50 Fabrice Fontaine
  2023-11-01 10:52 ` Yann E. MORIN
  0 siblings, 1 reply; 3+ messages in thread
From: Fabrice Fontaine @ 2023-10-30  8:50 UTC (permalink / raw)
  To: buildroot; +Cc: Fabrice Fontaine

Fix the following build failure with gcc >= 13:

In file included from ./Common/log.h:45,
                 from LinuxPBA/LinuxPBA.cpp:25:
./Common/DtaOptions.h:33:5: error: 'uint8_t' does not name a type
   33 |     uint8_t password;   /**< password supplied */
      |     ^~~~~~~
./Common/DtaOptions.h:1:1: note: 'uint8_t' is defined in header '<cstdint>'; did you forget to '#include <cstdint>'?

Fixes:
 - http://autobuild.buildroot.org/results/b6feb4fb33d595414b61174deb9867e8c30cd186

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 .../0002-include-missing-cstdint.patch        | 31 +++++++++++++++++++
 1 file changed, 31 insertions(+)
 create mode 100644 package/sedutil/0002-include-missing-cstdint.patch

diff --git a/package/sedutil/0002-include-missing-cstdint.patch b/package/sedutil/0002-include-missing-cstdint.patch
new file mode 100644
index 0000000000..07a617c5e7
--- /dev/null
+++ b/package/sedutil/0002-include-missing-cstdint.patch
@@ -0,0 +1,31 @@
+From 927cd88cad7bea94c2eebecc18f7881f0defaccb Mon Sep 17 00:00:00 2001
+From: Khem Raj <raj.khem@gmail.com>
+Date: Thu, 26 Jan 2023 23:36:29 -0800
+Subject: [PATCH] include missing <cstdint>
+
+gcc 13 moved some includes around and as a result <cstdint>
+is no longer transitively included [1]. Explicitly include
+it for uint{32,64}_t.
+
+[1] https://gcc.gnu.org/gcc-13/porting_to.html#header-dep-changes
+
+Signed-off-by: Khem Raj <raj.khem@gmail.com>
+
+Upstream: https://github.com/Drive-Trust-Alliance/sedutil/pull/425
+Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
+---
+ Common/DtaOptions.h | 1 +
+ 1 file changed, 1 insertion(+)
+
+diff --git a/Common/DtaOptions.h b/Common/DtaOptions.h
+index c012af1d..7530a0b7 100644
+--- a/Common/DtaOptions.h
++++ b/Common/DtaOptions.h
+@@ -21,6 +21,7 @@ along with sedutil.  If not, see <http://www.gnu.org/licenses/>.
+ #ifndef _DTAOPTIONS_H
+ #define	_DTAOPTIONS_H
+ 
++#include <cstdint>
+ /** Output modes */
+ typedef enum _sedutiloutput {
+ 	sedutilNormal,
-- 
2.42.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [Buildroot] [PATCH 1/1] package/sedutil: fix build with gcc >= 13
  2023-10-30  8:50 [Buildroot] [PATCH 1/1] package/sedutil: fix build with gcc >= 13 Fabrice Fontaine
@ 2023-11-01 10:52 ` Yann E. MORIN
  2023-11-07 19:38   ` Peter Korsgaard
  0 siblings, 1 reply; 3+ messages in thread
From: Yann E. MORIN @ 2023-11-01 10:52 UTC (permalink / raw)
  To: Fabrice Fontaine; +Cc: buildroot

Fabrice, All,

On 2023-10-30 09:50 +0100, Fabrice Fontaine spake thusly:
> Fix the following build failure with gcc >= 13:
> 
> In file included from ./Common/log.h:45,
>                  from LinuxPBA/LinuxPBA.cpp:25:
> ./Common/DtaOptions.h:33:5: error: 'uint8_t' does not name a type
>    33 |     uint8_t password;   /**< password supplied */
>       |     ^~~~~~~
> ./Common/DtaOptions.h:1:1: note: 'uint8_t' is defined in header '<cstdint>'; did you forget to '#include <cstdint>'?
> 
> Fixes:
>  - http://autobuild.buildroot.org/results/b6feb4fb33d595414b61174deb9867e8c30cd186
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

Applied to master, thanks.

Regards,
Yann E. MORIN.

> ---
>  .../0002-include-missing-cstdint.patch        | 31 +++++++++++++++++++
>  1 file changed, 31 insertions(+)
>  create mode 100644 package/sedutil/0002-include-missing-cstdint.patch
> 
> diff --git a/package/sedutil/0002-include-missing-cstdint.patch b/package/sedutil/0002-include-missing-cstdint.patch
> new file mode 100644
> index 0000000000..07a617c5e7
> --- /dev/null
> +++ b/package/sedutil/0002-include-missing-cstdint.patch
> @@ -0,0 +1,31 @@
> +From 927cd88cad7bea94c2eebecc18f7881f0defaccb Mon Sep 17 00:00:00 2001
> +From: Khem Raj <raj.khem@gmail.com>
> +Date: Thu, 26 Jan 2023 23:36:29 -0800
> +Subject: [PATCH] include missing <cstdint>
> +
> +gcc 13 moved some includes around and as a result <cstdint>
> +is no longer transitively included [1]. Explicitly include
> +it for uint{32,64}_t.
> +
> +[1] https://gcc.gnu.org/gcc-13/porting_to.html#header-dep-changes
> +
> +Signed-off-by: Khem Raj <raj.khem@gmail.com>
> +
> +Upstream: https://github.com/Drive-Trust-Alliance/sedutil/pull/425
> +Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> +---
> + Common/DtaOptions.h | 1 +
> + 1 file changed, 1 insertion(+)
> +
> +diff --git a/Common/DtaOptions.h b/Common/DtaOptions.h
> +index c012af1d..7530a0b7 100644
> +--- a/Common/DtaOptions.h
> ++++ b/Common/DtaOptions.h
> +@@ -21,6 +21,7 @@ along with sedutil.  If not, see <http://www.gnu.org/licenses/>.
> + #ifndef _DTAOPTIONS_H
> + #define	_DTAOPTIONS_H
> + 
> ++#include <cstdint>
> + /** Output modes */
> + typedef enum _sedutiloutput {
> + 	sedutilNormal,
> -- 
> 2.42.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [Buildroot] [PATCH 1/1] package/sedutil: fix build with gcc >= 13
  2023-11-01 10:52 ` Yann E. MORIN
@ 2023-11-07 19:38   ` Peter Korsgaard
  0 siblings, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2023-11-07 19:38 UTC (permalink / raw)
  To: Yann E. MORIN; +Cc: Fabrice Fontaine, buildroot

>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:

 > Fabrice, All,
 > On 2023-10-30 09:50 +0100, Fabrice Fontaine spake thusly:
 >> Fix the following build failure with gcc >= 13:
 >> 
 >> In file included from ./Common/log.h:45,
 >> from LinuxPBA/LinuxPBA.cpp:25:
 >> ./Common/DtaOptions.h:33:5: error: 'uint8_t' does not name a type
 >> 33 |     uint8_t password;   /**< password supplied */
 >> |     ^~~~~~~
 >> ./Common/DtaOptions.h:1:1: note: 'uint8_t' is defined in header '<cstdint>'; did you forget to '#include <cstdint>'?
 >> 
 >> Fixes:
 >> - http://autobuild.buildroot.org/results/b6feb4fb33d595414b61174deb9867e8c30cd186
 >> 
 >> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

 > Applied to master, thanks.

Committed to 2023.08.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-11-07 19:38 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-30  8:50 [Buildroot] [PATCH 1/1] package/sedutil: fix build with gcc >= 13 Fabrice Fontaine
2023-11-01 10:52 ` Yann E. MORIN
2023-11-07 19:38   ` Peter Korsgaard

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox