Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] dehydrated: critical bump to 0.6.5
@ 2019-08-19 16:37 Arnout Vandecappelle
  2019-08-19 17:09 ` Peter Korsgaard
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Arnout Vandecappelle @ 2019-08-19 16:37 UTC (permalink / raw)
  To: buildroot

On July 3, 2019, Let's Encrypt deployed new ACME server software that no
longer returns the 'id' field in the account information JSON.
Dehydrated relied on this field, even though it is not specified by RFC
8555. Because of this, dehydrated can no longer create a new account on
Let's Encrypt.

This was fixed by upstream commits be13dcd and 4f358e2. But the latter
broke ACMEv1 support so was fixed again in commit f60f2f8.

Cherry-picking this correctly is tricky, so instead just bump the
version. There are quite a few non-bugfix changes that are included this
way, but it's more risky to try to cherry-pick.

Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
---
Since this issue essentially breaks dehydrated for new accounts (i.e.
any new deployment), I think it's for master and it should be backported
to 2019.02.x
---
 package/dehydrated/dehydrated.hash | 4 ++--
 package/dehydrated/dehydrated.mk   | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/package/dehydrated/dehydrated.hash b/package/dehydrated/dehydrated.hash
index 1d194e5a7d..388dd24749 100644
--- a/package/dehydrated/dehydrated.hash
+++ b/package/dehydrated/dehydrated.hash
@@ -1,6 +1,6 @@
 # Locally computed after verifying
-# https://github.com/lukas2511/dehydrated/releases/download/v0.6.2/dehydrated-0.6.2.tar.gz.asc
+# https://github.com/lukas2511/dehydrated/releases/download/v0.6.5/dehydrated-0.6.5.tar.gz.asc
 # with key 3C2F2605E078A1E18F4793909C4DBE6CF438F333 from https://keybase.io/lukas2511
-sha256  163384479199f06f59382ceb6291a299567a2f4f0b963b9b61f2db65a407e80e  dehydrated-0.6.2.tar.gz
+sha256  10aabd0027450bc70a18e49acaca7a9697e0cfb92368d3e508b7a4d6d69bfa35 dehydrated-0.6.5.tar.gz
 # License, locally computed
 sha256  b4583b7dd07e3e2a08906de38e7e329d41f921ed9dcb6310b3886e013a6b8723  LICENSE
diff --git a/package/dehydrated/dehydrated.mk b/package/dehydrated/dehydrated.mk
index b7de27a407..17c67b8478 100644
--- a/package/dehydrated/dehydrated.mk
+++ b/package/dehydrated/dehydrated.mk
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-DEHYDRATED_VERSION = 0.6.2
+DEHYDRATED_VERSION = 0.6.5
 DEHYDRATED_SITE = https://github.com/lukas2511/dehydrated/releases/download/v$(DEHYDRATED_VERSION)
 
 DEHYDRATED_LICENSE = MIT
-- 
2.21.0

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [Buildroot] [PATCH] dehydrated: critical bump to 0.6.5
  2019-08-19 16:37 [Buildroot] [PATCH] dehydrated: critical bump to 0.6.5 Arnout Vandecappelle
@ 2019-08-19 17:09 ` Peter Korsgaard
  2019-08-19 19:47 ` Thomas Petazzoni
  2019-09-02 15:24 ` Peter Korsgaard
  2 siblings, 0 replies; 4+ messages in thread
From: Peter Korsgaard @ 2019-08-19 17:09 UTC (permalink / raw)
  To: buildroot

>>>>> "Arnout" == Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> writes:

 > On July 3, 2019, Let's Encrypt deployed new ACME server software that no
 > longer returns the 'id' field in the account information JSON.
 > Dehydrated relied on this field, even though it is not specified by RFC
 > 8555. Because of this, dehydrated can no longer create a new account on
 > Let's Encrypt.

 > This was fixed by upstream commits be13dcd and 4f358e2. But the latter
 > broke ACMEv1 support so was fixed again in commit f60f2f8.

 > Cherry-picking this correctly is tricky, so instead just bump the
 > version. There are quite a few non-bugfix changes that are included this
 > way, but it's more risky to try to cherry-pick.

 > Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>

Committed, thanks.

> ---
 > Since this issue essentially breaks dehydrated for new accounts (i.e.
 > any new deployment), I think it's for master and it should be backported
 > to 2019.02.x

OK, I'll cherry pick it when I sync 2019.02.x with master later this
week.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Buildroot] [PATCH] dehydrated: critical bump to 0.6.5
  2019-08-19 16:37 [Buildroot] [PATCH] dehydrated: critical bump to 0.6.5 Arnout Vandecappelle
  2019-08-19 17:09 ` Peter Korsgaard
@ 2019-08-19 19:47 ` Thomas Petazzoni
  2019-09-02 15:24 ` Peter Korsgaard
  2 siblings, 0 replies; 4+ messages in thread
From: Thomas Petazzoni @ 2019-08-19 19:47 UTC (permalink / raw)
  To: buildroot

On Mon, 19 Aug 2019 18:37:49 +0200
"Arnout Vandecappelle (Essensium/Mind)" <arnout@mind.be> wrote:

> On July 3, 2019, Let's Encrypt deployed new ACME server software that no
> longer returns the 'id' field in the account information JSON.
> Dehydrated relied on this field, even though it is not specified by RFC
> 8555. Because of this, dehydrated can no longer create a new account on
> Let's Encrypt.
> 
> This was fixed by upstream commits be13dcd and 4f358e2. But the latter
> broke ACMEv1 support so was fixed again in commit f60f2f8.
> 
> Cherry-picking this correctly is tricky, so instead just bump the
> version. There are quite a few non-bugfix changes that are included this
> way, but it's more risky to try to cherry-pick.
> 
> Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>

Commit title should have been prefixed with "package/dehydrated" :-)

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Buildroot] [PATCH] dehydrated: critical bump to 0.6.5
  2019-08-19 16:37 [Buildroot] [PATCH] dehydrated: critical bump to 0.6.5 Arnout Vandecappelle
  2019-08-19 17:09 ` Peter Korsgaard
  2019-08-19 19:47 ` Thomas Petazzoni
@ 2019-09-02 15:24 ` Peter Korsgaard
  2 siblings, 0 replies; 4+ messages in thread
From: Peter Korsgaard @ 2019-09-02 15:24 UTC (permalink / raw)
  To: buildroot

>>>>> "Arnout" == Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> writes:

 > On July 3, 2019, Let's Encrypt deployed new ACME server software that no
 > longer returns the 'id' field in the account information JSON.
 > Dehydrated relied on this field, even though it is not specified by RFC
 > 8555. Because of this, dehydrated can no longer create a new account on
 > Let's Encrypt.

 > This was fixed by upstream commits be13dcd and 4f358e2. But the latter
 > broke ACMEv1 support so was fixed again in commit f60f2f8.

 > Cherry-picking this correctly is tricky, so instead just bump the
 > version. There are quite a few non-bugfix changes that are included this
 > way, but it's more risky to try to cherry-pick.

 > Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
 > ---
 > Since this issue essentially breaks dehydrated for new accounts (i.e.
 > any new deployment), I think it's for master and it should be backported
 > to 2019.02.x

Committed to 2019.02.x and 2019.05.x, thanks.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2019-09-02 15:24 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-08-19 16:37 [Buildroot] [PATCH] dehydrated: critical bump to 0.6.5 Arnout Vandecappelle
2019-08-19 17:09 ` Peter Korsgaard
2019-08-19 19:47 ` Thomas Petazzoni
2019-09-02 15:24 ` Peter Korsgaard

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox