Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Mario Lang <mlang@blind.guru>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] brltty: fix build on mips64el
Date: Mon, 08 Oct 2018 12:09:56 +0200	[thread overview]
Message-ID: <87bm84eoln.fsf@home.blind.guru> (raw)
In-Reply-To: <CAPi7W82H5K4nsu5A6wPwwuGdnTXAJJ3Jh5wUrkGRj93==6cBhw@mail.gmail.com> (Fabrice Fontaine's message of "Mon, 8 Oct 2018 10:29:58 +0200")

Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:

> Dear Mario,
> Le lun. 8 oct. 2018 ? 10:18, Mario Lang <mlang@blind.guru> a ?crit :
>
>> Hi.
>>
>> Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:
>>
>> > Bump to version 5.6 has reintroduced the issue fixed by patch 854093 on
>> > version 5.5.
>> >
>> > Indeed, third patch was merged upstream but it was then reverted:
>> >
>> https://github.com/brltty/brltty/commit/9e7d62c869d3c1cbe12dda8b0291a4692c193416
>> >
>> > Moreover, since commit 3a2e3f6fa5ef0a210ffeba5ed05c79965d0cc3c7, MKOBJ
>> > was renamed into MKREL. So, instead of patching again brltty, overwrite
>> > LD to set the correct emulation depending on MIPS architecture as
>> > already done in linux-tool-perf.mk.in.
>>
>> Thanks Fabrice.  ack and +1.
>>
> Thanks for your review, however after the feedback from Arnout on first
> patch iteration (https://patchwork.ozlabs.org/patch/972614/), I've also
> sent a PR to brltty: https://github.com/brltty/brltty/pull/149.
> Both solutions seems good to me.

As I have mentioned previously in this thread, switching to GCC
unconditionally break compilation on OS X.
So PR 149 is likely not to be accepted.
IMO, the right way forward is to commit your patch to buildroot, as it
fixes a problem specific to mips.

-- 
CYa,
  ?????

  reply	other threads:[~2018-10-08 10:09 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-30 18:34 [Buildroot] [PATCH 1/1] brltty: fix build on mips64el Fabrice Fontaine
2018-10-08  8:18 ` Mario Lang
2018-10-08  8:29   ` Fabrice Fontaine
2018-10-08 10:09     ` Mario Lang [this message]
2018-10-08 16:07       ` Arnout Vandecappelle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bm84eoln.fsf@home.blind.guru \
    --to=mlang@blind.guru \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox