[Buildroot] [PATCH 1/1] package/python-enum34: change setup type to setuptools

[Buildroot] [PATCH 1/1] package/python-enum34: change setup type to setuptools

[Bernd Kuhls]

With version 1.1.3 the project switched to setuptools:
https://bitbucket.org/stoneleaf/enum34/commits/589b4f9d2e733a32c6e67a1e7aa50f476920d121

Fixes
http://autobuild.buildroot.net/results/cb6/cb678ca9e57382a876f3f6034a47a4e2c59bc8d0/

Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
---
 package/python-enum34/python-enum34.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/python-enum34/python-enum34.mk b/package/python-enum34/python-enum34.mk
index 1a4c6c694..c612cb65e 100644
--- a/package/python-enum34/python-enum34.mk
+++ b/package/python-enum34/python-enum34.mk
@@ -7,7 +7,7 @@
 PYTHON_ENUM34_VERSION = 1.1.6
 PYTHON_ENUM34_SOURCE = enum34-$(PYTHON_ENUM34_VERSION).tar.gz
 PYTHON_ENUM34_SITE = https://pypi.python.org/packages/bf/3e/31d502c25302814a7c2f1d3959d2a3b3f78e509002ba91aea64993936876
-PYTHON_ENUM34_SETUP_TYPE = distutils
+PYTHON_ENUM34_SETUP_TYPE = setuptools
 PYTHON_ENUM34_LICENSE = BSD-3-Clause
 PYTHON_ENUM34_LICENSE_FILES = enum/LICENSE
 
-- 
2.11.0

[Buildroot] [PATCH 1/1] package/python-enum34: change setup type to setuptools

[Peter Korsgaard]

>>>>> "Bernd" == Bernd Kuhls <bernd.kuhls@t-online.de> writes:

 > With version 1.1.3 the project switched to setuptools:
 > https://bitbucket.org/stoneleaf/enum34/commits/589b4f9d2e733a32c6e67a1e7aa50f476920d121

 > Fixes
 > http://autobuild.buildroot.net/results/cb6/cb678ca9e57382a876f3f6034a47a4e2c59bc8d0/

 > Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>

Are you sure. I don't know much about Python packaging, but it still
has:

from distutils.core import setup

..

if __name__ == '__main__':
    setup(**data)


The tarball (and not git) has a dummy setup.cfg, which afaik is related
to setuptools.

I'm not sure what the correct fix is. Yegor? Either we patch out the
'import setuptools' line or we add host-python-setuptools to the
dependencies.

-- 
Bye, Peter Korsgaard

[Buildroot] [PATCH 1/1] package/python-enum34: change setup type to setuptools

[Yegor Yefremov]

On Sun, May 21, 2017 at 11:38 PM, Peter Korsgaard <peter@korsgaard.com> wrote:
>>>>>> "Bernd" == Bernd Kuhls <bernd.kuhls@t-online.de> writes:
>
>  > With version 1.1.3 the project switched to setuptools:
>  > https://bitbucket.org/stoneleaf/enum34/commits/589b4f9d2e733a32c6e67a1e7aa50f476920d121
>
>  > Fixes
>  > http://autobuild.buildroot.net/results/cb6/cb678ca9e57382a876f3f6034a47a4e2c59bc8d0/
>
>  > Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
>
> Are you sure. I don't know much about Python packaging, but it still
> has:
>
> from distutils.core import setup
>
> ..
>
> if __name__ == '__main__':
>     setup(**data)
>
>
> The tarball (and not git) has a dummy setup.cfg, which afaik is related
> to setuptools.
>
> I'm not sure what the correct fix is. Yegor? Either we patch out the
> 'import setuptools' line or we add host-python-setuptools to the
> dependencies.

I would take Bernd's fix as it is. Defining setuptype as setuptools
adds host-python-setuptools and  distutils.core is available anyway.
This doesn't seem to hurt. I've written an e-mail to the enum34
maintainer with a request to clarify this setup situation.

Yegor

[Buildroot] [PATCH 1/1] package/python-enum34: change setup type to setuptools

[Peter Korsgaard]

>>>>> "Yegor" == Yegor Yefremov <yegorslists@googlemail.com> writes:

Hi,

 >> I'm not sure what the correct fix is. Yegor? Either we patch out the
 >> 'import setuptools' line or we add host-python-setuptools to the
 >> dependencies.

 > I would take Bernd's fix as it is. Defining setuptype as setuptools
 > adds host-python-setuptools and  distutils.core is available anyway.
 > This doesn't seem to hurt. I've written an e-mail to the enum34
 > maintainer with a request to clarify this setup situation.

Ahh, ok - I missed the fact that distutils.core is part of python
itself.

Thanks for contacting the maintainer.

Committed, thanks.

-- 
Bye, Peter Korsgaard