Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] system: add option to pass extra args to post-build and post-image scripts
Date: Wed, 10 Jul 2013 09:31:34 +0200	[thread overview]
Message-ID: <87bo6ahnvt.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <1373407231-20382-1-git-send-email-yann.morin.1998@free.fr> (Yann E. MORIN's message of "Wed, 10 Jul 2013 00:00:31 +0200")

>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:

 Yann> From: "Yann E. MORIN" <yann.morin.1998@free.fr>
 Yann> It can be useful to have different configuration use the same post-build
 Yann> and/or post-image scripts as they share a common infrastructure, but yet
 Yann> have minor differentiation.

 Yann> This option allows passing zero or more additional arguments to each
 Yann> post-build or post-image script.

 Yann> The same set of extra arguments are passed to all scripts, it is not
 Yann> possible to pass different arguments to each script.

 Yann> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
 Yann> Cc: Baruch Siach <baruch@tkos.co.il>

 Yann> ---
 Yann> Changes v1 -> v2:
 Yann>   - $(TARGET_DIR) is no longer the only argument        (Baruch)
 Yann>   - mention BR2_ROOTFS_POST_IMAGE_SCRIPT in the manual

 Yann> +config BR2_ROOTFS_POST_SCRIPT_ARGS
 Yann> +	string "Extra post-{build,image} arguments"
 Yann> +	depends on BR2_ROOTFS_POST_BUILD_SCRIPT != "" || BR2_ROOTFS_POST_IMAGE_SCRIPT != ""

 Yann> +	help
 Yann> +	  Pass these aditional arguments to each post-build or post-image
 Yann> +	  scripts.
 Yann> +
 Yann> +	  Note that all the post-build and post-image scripts will be passed
 Yann> +	  the same set of arguments, you can not pass different arguments to
 Yann> +	  each script.
 Yann> +
 Yann> +	  Note also, as stated in their respective help text, that the first
 Yann> +	  argument to each post-build or post-image script is the target/
 Yann> +	  directory $(TARGET_DIR). The arguments in this option will be
 Yann> +	  passed *after*.

The post-image script is called with the images directory, not the
target directory.

Committed with that fixed, thanks.

-- 
Bye, Peter Korsgaard

  reply	other threads:[~2013-07-10  7:31 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-09 22:00 [Buildroot] [PATCH] system: add option to pass extra args to post-build and post-image scripts Yann E. MORIN
2013-07-10  7:31 ` Peter Korsgaard [this message]
  -- strict thread matches above, loose matches on Subject: below --
2013-07-09 18:06 Yann E. MORIN
2013-07-09 18:25 ` Baruch Siach
2013-07-09 18:54   ` Yann E. MORIN
2013-07-09 18:35 ` Yann E. MORIN
2013-07-09 21:50   ` Peter Korsgaard
2013-07-10  7:16   ` Thomas Petazzoni
2013-07-10  9:29     ` Thomas Petazzoni
2013-07-10  9:53       ` Peter Korsgaard
2013-07-10 12:49         ` Thomas Petazzoni
2013-07-10 16:22           ` Yann E. MORIN
2013-07-10 16:17     ` Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bo6ahnvt.fsf@dell.be.48ers.dk \
    --to=jacmet@uclibc.org \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox