From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] system: add option to pass extra args to post-build and post-image scripts
Date: Wed, 10 Jul 2013 09:16:28 +0200 [thread overview]
Message-ID: <20130710091628.1d01d59c@skate> (raw)
In-Reply-To: <20130709183505.GB3543@free.fr>
Dear Yann E. MORIN,
On Tue, 9 Jul 2013 20:35:05 +0200, Yann E. MORIN wrote:
> This was refused (and rightfully) as that would greatly impact users
> depending on the current behaviour, and some alternate solution were
> proposed:
> - have a single script that would behave differently on how it sould
> be called, and have different symlinks pointing to that script;
> - have a script for each configuration, that 'sources' a functions
> file and call the required functions
>
> After playing a bit with both solutions, it turned out to be not
> entirely manageable, especially when the inrastructure put in place by
> the functions changes, since all scripts must be changed accordingly.
I am not quite sure to understand why the symlink solution doesn't work
in your case. Could you elaborate on that?
Regarding the patch itself, I'd say why not. I'm just wondering if it
wouldn't be better to have separate arguments for both scripts. Not
sure.
Thanks!
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2013-07-10 7:16 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-09 18:06 [Buildroot] [PATCH] system: add option to pass extra args to post-build and post-image scripts Yann E. MORIN
2013-07-09 18:25 ` Baruch Siach
2013-07-09 18:54 ` Yann E. MORIN
2013-07-09 18:35 ` Yann E. MORIN
2013-07-09 21:50 ` Peter Korsgaard
2013-07-10 7:16 ` Thomas Petazzoni [this message]
2013-07-10 9:29 ` Thomas Petazzoni
2013-07-10 9:53 ` Peter Korsgaard
2013-07-10 12:49 ` Thomas Petazzoni
2013-07-10 16:22 ` Yann E. MORIN
2013-07-10 16:17 ` Yann E. MORIN
-- strict thread matches above, loose matches on Subject: below --
2013-07-09 22:00 Yann E. MORIN
2013-07-10 7:31 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130710091628.1d01d59c@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox