Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] 'source' target should depend on 'dirs'
@ 2011-07-27  9:34 Thomas De Schampheleire
  2011-08-04 19:45 ` Peter Korsgaard
  0 siblings, 1 reply; 2+ messages in thread
From: Thomas De Schampheleire @ 2011-07-27  9:34 UTC (permalink / raw)
  To: buildroot

In the following command flow:
make distclean
make <board>_defconfig
make source

the dl directory would normally be created by the first wget download. If there are no such downloads, e.g. because you use a local download mirror (e.g. scp, file) or only use git/svn/hg/bzr repositories, the dl directory is not created automatically. This causes e.g. the 'pushd' command in the respective _DOWNLOAD commands to fail.

This patch adds a dependency to the 'dirs' target to 'source', fixing this scenario.

Signed-off-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>

diff --git a/Makefile b/Makefile
--- a/Makefile
+++ b/Makefile
@@ -486,7 +486,7 @@
 	done
 endif
 
-source: $(TARGETS_SOURCE) $(HOST_SOURCE)
+source: dirs $(TARGETS_SOURCE) $(HOST_SOURCE)
 
 external-deps:
 	@$(MAKE) -Bs DL_MODE=SHOW_EXTERNAL_DEPS $(EXTRAMAKEARGS) source | sort -u

^ permalink raw reply	[flat|nested] 2+ messages in thread

* [Buildroot] [PATCH] 'source' target should depend on 'dirs'
  2011-07-27  9:34 [Buildroot] [PATCH] 'source' target should depend on 'dirs' Thomas De Schampheleire
@ 2011-08-04 19:45 ` Peter Korsgaard
  0 siblings, 0 replies; 2+ messages in thread
From: Peter Korsgaard @ 2011-08-04 19:45 UTC (permalink / raw)
  To: buildroot

>>>>> "Thomas" == Thomas De Schampheleire <patrickdepinguin+buildroot@gmail.com> writes:

 Thomas> In the following command flow:
 Thomas> make distclean
 Thomas> make <board>_defconfig
 Thomas> make source

Committed, thanks.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2011-08-04 19:45 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-07-27  9:34 [Buildroot] [PATCH] 'source' target should depend on 'dirs' Thomas De Schampheleire
2011-08-04 19:45 ` Peter Korsgaard

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox