Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/1] libmpd: fix build with strndup
@ 2018-12-08 12:58 Fabrice Fontaine
  2018-12-08 22:38 ` Peter Korsgaard
  2018-12-16 19:43 ` Peter Korsgaard
  0 siblings, 2 replies; 3+ messages in thread
From: Fabrice Fontaine @ 2018-12-08 12:58 UTC (permalink / raw)
  To: buildroot

Retrieve a patch from upstream to include config.h otherwise build will
fail when trying to redefine strndup:
libmpd-internal.h:210:10: error: expected identifier or '(' before '__extension__'
 char *   strndup     (const char *s, size_t n);

Indeed, without an include on config.h, HAVE_STRNDUP won't be defined

Fixes:
 - http://autobuild.buildroot.org/results/a174818fa768b029d19b033139f9c5e0aaaed149

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 ...01-Fix-build-on-archlinux-missing-include.patch | 24 ++++++++++++++++++++++
 1 file changed, 24 insertions(+)
 create mode 100644 package/libmpd/0001-Fix-build-on-archlinux-missing-include.patch

diff --git a/package/libmpd/0001-Fix-build-on-archlinux-missing-include.patch b/package/libmpd/0001-Fix-build-on-archlinux-missing-include.patch
new file mode 100644
index 0000000000..be16eb9713
--- /dev/null
+++ b/package/libmpd/0001-Fix-build-on-archlinux-missing-include.patch
@@ -0,0 +1,24 @@
+From 4f946c01000fd97100e4a534b47f9c7ace0403df Mon Sep 17 00:00:00 2001
+From: QC <qball@gmpclient.org>
+Date: Thu, 9 Oct 2014 19:51:50 +0200
+Subject: [PATCH] Fix build on archlinux (missing include)
+
+Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
+[Retrieved from:
+https://github.com/DaveDavenport/libmpd/commit/4f946c01000fd97100e4a534b47f9c7ace0403df]
+---
+ src/libmpd-internal.h | 1 +
+ 1 file changed, 1 insertion(+)
+
+diff --git a/src/libmpd-internal.h b/src/libmpd-internal.h
+index c84c3a4..30cdc85 100644
+--- a/src/libmpd-internal.h
++++ b/src/libmpd-internal.h
+@@ -21,6 +21,7 @@
+ #define __MPD_INTERNAL_LIB_
+ 
+ #include "libmpdclient.h"
++#include <config.h>
+ struct _MpdData_real;
+ 
+ typedef struct _MpdData_real {
-- 
2.14.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH 1/1] libmpd: fix build with strndup
  2018-12-08 12:58 [Buildroot] [PATCH 1/1] libmpd: fix build with strndup Fabrice Fontaine
@ 2018-12-08 22:38 ` Peter Korsgaard
  2018-12-16 19:43 ` Peter Korsgaard
  1 sibling, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2018-12-08 22:38 UTC (permalink / raw)
  To: buildroot

>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:

 > Retrieve a patch from upstream to include config.h otherwise build will
 > fail when trying to redefine strndup:
 > libmpd-internal.h:210:10: error: expected identifier or '(' before '__extension__'
 >  char *   strndup     (const char *s, size_t n);

 > Indeed, without an include on config.h, HAVE_STRNDUP won't be defined

 > Fixes:
 >  - http://autobuild.buildroot.org/results/a174818fa768b029d19b033139f9c5e0aaaed149

 > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

Committed, thanks.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH 1/1] libmpd: fix build with strndup
  2018-12-08 12:58 [Buildroot] [PATCH 1/1] libmpd: fix build with strndup Fabrice Fontaine
  2018-12-08 22:38 ` Peter Korsgaard
@ 2018-12-16 19:43 ` Peter Korsgaard
  1 sibling, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2018-12-16 19:43 UTC (permalink / raw)
  To: buildroot

>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:

 > Retrieve a patch from upstream to include config.h otherwise build will
 > fail when trying to redefine strndup:
 > libmpd-internal.h:210:10: error: expected identifier or '(' before '__extension__'
 >  char *   strndup     (const char *s, size_t n);

 > Indeed, without an include on config.h, HAVE_STRNDUP won't be defined

 > Fixes:
 >  - http://autobuild.buildroot.org/results/a174818fa768b029d19b033139f9c5e0aaaed149

 > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

Committed to 2018.02.x, 2018.08.x and 2018.11.x, thanks.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-12-16 19:43 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-12-08 12:58 [Buildroot] [PATCH 1/1] libmpd: fix build with strndup Fabrice Fontaine
2018-12-08 22:38 ` Peter Korsgaard
2018-12-16 19:43 ` Peter Korsgaard

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox