Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] tcping: new package
Date: Fri, 13 Sep 2013 11:24:06 +0200	[thread overview]
Message-ID: <87d2odnkg9.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <1379057638-27970-1-git-send-email-rebillout@syscom.ch> ("Arnaud Rébillout"'s message of "Fri, 13 Sep 2013 09:33:58 +0200")

>>>>> "Arnaud" == Arnaud R?billout <rebillout@syscom.ch> writes:

Hi,

 Arnaud> tcping does a TCP connect to the given ip/port combination. The user can
 Arnaud> specify a timeout in seconds. This is useful in shell scripts running in
 Arnaud> firewalled environments. Often SYNs are just being dropped by firewalls,
 Arnaud> thus connection establishment will be retried several times (for minutes)
 Arnaud> until a TCP timeout is reached. With tcping it is possible to check first
 Arnaud> if the desired port is reachable and then start connection establishment.

 Arnaud> http://www.linuxco.de/tcping/tcping.html

 Arnaud> Signed-off-by: Arnaud R?billout <rebillout@syscom.ch>
 Arnaud> ---

Please clearly mark patch version and what you have changed to ease
review. The way to do this is to add the revision after PATCH in subject
(E.G. [PATCHv2]) and to write a small change long here under the ---
line.

 Arnaud>  package/Config.in        |  1 +
 Arnaud>  package/tcping/Config.in | 11 +++++++++++
 Arnaud>  package/tcping/tcping.mk | 20 ++++++++++++++++++++
 Arnaud>  3 files changed, 32 insertions(+)
 Arnaud>  create mode 100644 package/tcping/Config.in
 Arnaud>  create mode 100644 package/tcping/tcping.mk

 Arnaud> diff --git a/package/Config.in b/package/Config.in
 Arnaud> index 2351839..fc1ec87 100644
 Arnaud> --- a/package/Config.in
 Arnaud> +++ b/package/Config.in
 Arnaud> @@ -854,6 +854,7 @@ source "package/squid/Config.in"
 Arnaud>  source "package/strongswan/Config.in"
 Arnaud>  source "package/stunnel/Config.in"
 Arnaud>  source "package/tcpdump/Config.in"
 Arnaud> +source "package/tcping/Config.in"
 Arnaud>  source "package/tcpreplay/Config.in"
 Arnaud>  if BR2_PACKAGE_BUSYBOX_SHOW_OTHERS
 Arnaud>  source "package/tftpd/Config.in"
 Arnaud> diff --git a/package/tcping/Config.in b/package/tcping/Config.in
 Arnaud> new file mode 100644
 Arnaud> index 0000000..93cf322
 Arnaud> --- /dev/null
 Arnaud> +++ b/package/tcping/Config.in
 Arnaud> @@ -0,0 +1,11 @@
 Arnaud> +config BR2_PACKAGE_TCPING
 Arnaud> +	bool "tcping"
 Arnaud> +	help
 Arnaud> +	  tcping does a TCP connect to the given ip/port combination. The user can
 Arnaud> +	  specify a timeout in seconds. This is useful in shell scripts running in
 Arnaud> +	  firewalled environments. Often SYNs are just being dropped by firewalls,
 Arnaud> +	  thus connection establishment will be retried several times (for minutes)
 Arnaud> +	  until a TCP timeout is reached. With tcping it is possible to check first
 Arnaud> +	  if the desired port is reachable and then start connection establishment.
 Arnaud> +

The help lines are too long. Please wrap after ~column 70 so it fits
into menuconfig with a normal 80char window.

 Arnaud> +	  http://www.linuxco.de/tcping/tcping.html
 Arnaud> diff --git a/package/tcping/tcping.mk b/package/tcping/tcping.mk
 Arnaud> new file mode 100644
 Arnaud> index 0000000..1472ad4
 Arnaud> --- /dev/null
 Arnaud> +++ b/package/tcping/tcping.mk
 Arnaud> @@ -0,0 +1,20 @@
 Arnaud> +################################################################################
 Arnaud> +#
 Arnaud> +# tcping
 Arnaud> +#
 Arnaud> +################################################################################
 Arnaud> +
 Arnaud> +TCPING_VERSION = 1.3.5
 Arnaud> +TCPING_SITE = http://www.linuxco.de/tcping
 Arnaud> +TCPING_LICENSE = GPLv3+
 Arnaud> +TCPING_LICENSE_FILES = LICENSE
 Arnaud> +
 Arnaud> +define TCPING_BUILD_CMDS
 Arnaud> +	$(MAKE) CC="$(TARGET_CC)" CCFLAGS="$(TARGET_CFLAGS)" -C $(@D) tcping.linux

You should also pass TARGET_LDFLAGS. As the Makefile is really simple I
just added it to CCFLAGS.

Committed with these minor fixes, thanks.

-- 
Bye, Peter Korsgaard

  reply	other threads:[~2013-09-13  9:24 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-11 15:07 [Buildroot] [PATCH] tcping: new package Arnaud Rébillout
2013-09-12 16:44 ` Thomas Petazzoni
2013-09-13  7:29   ` Arnaud Rébillout
2013-09-13  7:31     ` Arnaud Rébillout
2013-09-13  7:33     ` Arnaud Rébillout
2013-09-13  9:24       ` Peter Korsgaard [this message]
2013-09-13  9:27         ` Arnaud Rébillout
2013-09-13  9:39           ` Yegor Yefremov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87d2odnkg9.fsf@dell.be.48ers.dk \
    --to=jacmet@uclibc.org \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox