[Buildroot] [PATCH 1/1] ti-gfx.mk typo corrected

[Buildroot] [PATCH 1/1] ti-gfx.mk typo corrected

[Martin Creutziger]

There is a simple typo in package/ti-gfx/ti-gfx.mk, which the following 
patch corrects:

Signed-off-by: Martin Creutziger <buildroot@martin.creutziger.net>
---
Index: package/ti-gfx/ti-gfx.mk
===================================================================
--- package/ti-gfx/ti-gfx.mk	(revision 14043)
+++ package/ti-gfx/ti-gfx.mk	(working copy)
@@ -29,7 +29,7 @@
  TI_GFX_PLATFORM = omap3630
  endif
  ifeq ($(BR2_PACKAGE_TI_GFX_ES6),y)
-TI_GFX_OMPAES = 6.x
+TI_GFX_OMAPES = 6.x
  TI_GFX_PLATFORM = ti81xx
  endif
  ifeq ($(BR2_PACKAGE_TI_GFX_ES8),y)
--

[Buildroot] [PATCH 1/1] ti-gfx.mk typo corrected

[Thomas Petazzoni]

Dear Martin Creutziger,

On Mon, 02 Sep 2013 17:18:48 +0200, Martin Creutziger wrote:
> There is a simple typo in package/ti-gfx/ti-gfx.mk, which the following 
> patch corrects:
> 
> Signed-off-by: Martin Creutziger <buildroot@martin.creutziger.net>

Indeed, thanks!

Acked-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>

Martin, does this mean you are successfully using the ti-gfx package?
If so, can you tell us a bit more (which hardware platform, what
software stack on top of OpenGL, etc.) ? Our Google Summer of Code
student Spenser Gilliland is still working on improving OpenGL support
in Buildroot, so we're definitely interested in getting feedback.

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

[Buildroot] [PATCH 1/1] ti-gfx.mk typo corrected

[Peter Korsgaard]

>>>>> "Martin" == Martin Creutziger <buildroot@martin.creutziger.net> writes:

 Martin> There is a simple typo in package/ti-gfx/ti-gfx.mk, which the
 Martin> following patch corrects:

 Martin> Signed-off-by: Martin Creutziger <buildroot@martin.creutziger.net>
 Martin> ---
 Martin> Index: package/ti-gfx/ti-gfx.mk
 Martin> ===================================================================
 Martin> --- package/ti-gfx/ti-gfx.mk	(revision 14043)
 Martin> +++ package/ti-gfx/ti-gfx.mk	(working copy)

Committed, thanks.

In the future, please consider creating the patch using git so it can be
directly committed with git am (or atleast add one more directory level,
as git am expects patch -p1 format).

-- 
Bye, Peter Korsgaard

[Buildroot] [PATCH 1/1] ti-gfx.mk typo corrected

[Martin Creutziger]

Peter Korsgaard wrote:
>>>>>> "Martin" == Martin Creutziger <buildroot@martin.creutziger.net> writes:
>
>   Martin> There is a simple typo in package/ti-gfx/ti-gfx.mk, which the
>   Martin> following patch corrects:
>
>   Martin> Signed-off-by: Martin Creutziger <buildroot@martin.creutziger.net>
>   Martin> ---
>   Martin> Index: package/ti-gfx/ti-gfx.mk
>   Martin> ===================================================================
>   Martin> --- package/ti-gfx/ti-gfx.mk	(revision 14043)
>   Martin> +++ package/ti-gfx/ti-gfx.mk	(working copy)
>
> Committed, thanks.
>
> In the future, please consider creating the patch using git so it can be
> directly committed with git am (or atleast add one more directory level,
> as git am expects patch -p1 format).
>

Hello Peter,

as this was my first patch here on the mailing list, I already expected 
that I won't get it 100% right ;)

I created it directly out of our SVN repository, but thanks for the 
pointers about the expected format - I'll try to get closer to it next 
time. :)

BR,
Martin

[Buildroot] [PATCH 1/1] ti-gfx.mk typo corrected

[Peter Korsgaard]

>>>>> "Martin" == Martin Creutziger <buildroot@martin.creutziger.net> writes:

Hi Martin,

 Martin> as this was my first patch here on the mailing list, I already
 Martin> expected that I won't get it 100% right ;)

 Martin> I created it directly out of our SVN repository, but thanks for the
 Martin> pointers about the expected format - I'll try to get closer to it next
 Martin> time. :)

Don't worry, and thanks for submitting the fix!

-- 
Bye, Peter Korsgaard