Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot]  [PATCH 2/2] New package: input-event-daemon
@ 2011-04-21  2:30 keguang.zhang at gmail.com
  2011-04-26  1:52 ` Kelvin Cheung
  2011-05-03 20:43 ` Peter Korsgaard
  0 siblings, 2 replies; 3+ messages in thread
From: keguang.zhang at gmail.com @ 2011-04-21  2:30 UTC (permalink / raw)
  To: buildroot

From: Kelvin Cheung <keguang.zhang@gmail.com>

Add new package: input-event-daemon

input-event-daemon -  input event handling daemon for linux.

Signed-off-by: Kelvin Cheung <keguang.zhang@gmail.com>
---
 package/Config.in                                |    1 +
 package/input-event-daemon/Config.in             |    8 ++++
 package/input-event-daemon/S99input-event-daemon |   40 +++++++++++++++++++++
 package/input-event-daemon/input-event-daemon.mk |   41 ++++++++++++++++++++++
 4 files changed, 90 insertions(+), 0 deletions(-)
 create mode 100644 package/input-event-daemon/Config.in
 create mode 100755 package/input-event-daemon/S99input-event-daemon
 create mode 100644 package/input-event-daemon/input-event-daemon.mk

diff --git a/package/Config.in b/package/Config.in
index 0db0cd6..4bd2864 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -176,6 +176,7 @@ source "package/hdparm/Config.in"
 endif
 source "package/hwdata/Config.in"
 source "package/i2c-tools/Config.in"
+source "package/input-event-daemon/Config.in"
 source "package/input-tools/Config.in"
 source "package/iostat/Config.in"
 source "package/irda-utils/Config.in"
diff --git a/package/input-event-daemon/Config.in b/package/input-event-daemon/Config.in
new file mode 100644
index 0000000..edf2886
--- /dev/null
+++ b/package/input-event-daemon/Config.in
@@ -0,0 +1,8 @@
+config BR2_PACKAGE_INPUT_EVENT_DAEMON
+	bool "input-event-daemon"
+	help
+	  input-event-daemon is a daemon which executes
+	  a user-defined command on input events, such as
+	  keys, mouse buttons and switches.
+
+	  http://github.com/gandro/input-event-daemon
diff --git a/package/input-event-daemon/S99input-event-daemon b/package/input-event-daemon/S99input-event-daemon
new file mode 100755
index 0000000..ed374f4
--- /dev/null
+++ b/package/input-event-daemon/S99input-event-daemon
@@ -0,0 +1,40 @@
+#! /bin/sh
+
+[ -f /usr/bin/input-event-daemon ] || exit 0
+
+start() {
+	echo -n "Starting input-event-daemon: "
+	input-event-daemon
+	echo "done"
+}
+
+
+stop() {
+        echo -n "Stopping input-event-daemon: "
+	echo
+        killall input-event-daemon
+	echo "done"
+}
+
+restart() {
+	stop
+	start
+}
+
+# See how we were called.
+case "$1" in
+  start)
+	start
+	;;
+  stop)
+	stop
+	;;
+  restart|reload)
+	restart
+	;;
+  *)
+	echo "Usage: $0 {start|stop|reload|restart}"
+	exit 1
+esac
+
+exit $?
diff --git a/package/input-event-daemon/input-event-daemon.mk b/package/input-event-daemon/input-event-daemon.mk
new file mode 100644
index 0000000..5cd6e72
--- /dev/null
+++ b/package/input-event-daemon/input-event-daemon.mk
@@ -0,0 +1,41 @@
+#############################################################
+#
+# input-event-daemon
+#
+#############################################################
+INPUT_EVENT_DAEMON_VERSION:=13f4d61
+INPUT_EVENT_DAEMON_SITE:=git://github.com/gandro/input-event-daemon.git
+
+define INPUT_EVENT_DAEMON_BUILD_CMDS
+	touch  $(@D)/input-event-table.h
+	$(MAKE) CFLAGS="$(TARGET_CFLAGS)" CC="$(TARGET_CC)" -C $(@D)
+endef
+
+define INPUT_EVENT_DAEMON_INSTALL_TARGET_CMDS
+	$(INSTALL) -m 755 -D $(@D)/input-event-daemon $(TARGET_DIR)/usr/bin
+	-$(STRIPCMD) $(STRIP_STRIP_UNNEEDED) $(TARGET_DIR)/usr/bin/input-event-daemon
+	cp -n $(@D)/docs/sample.conf $(TARGET_DIR)/etc/input-event-daemon.conf
+endef
+
+define INPUT_EVENT_DAEMON_CLEAN_CMDS
+	$(MAKE) -C $(@D) clean
+endef
+
+define INPUT_EVENT_DAEMON_UNINSTALL_TARGET_CMDS
+	rm -f $(TARGET_DIR)/usr/bin/input-event-daemon
+	rm -f $(TARGET_DIR)/etc/input-event-daemon.conf
+endef
+
+define INPUT_EVENT_DAEMON_COSTUM_INSTALL
+	# install start/stop script
+	$(call MESSAGE,"Installing S99input-event-daemon init script")
+	if [ ! -f $(TARGET_DIR)/etc/init.d/S99input-event-daemon ]; then \
+		$(INSTALL) -m 0755 -D package/input-event-daemon/S99input-event-daemon \
+		$(TARGET_DIR)/etc/init.d/S99input-event-daemon; \
+	fi
+	$(Q)touch $@
+endef
+
+INPUT_EVENT_DAEMON_POST_INSTALL_TARGET_HOOKS += INPUT_EVENT_DAEMON_COSTUM_INSTALL
+
+$(eval $(call GENTARGETS,package,input-event-daemon))
-- 
1.7.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH 2/2] New package: input-event-daemon
  2011-04-21  2:30 [Buildroot] [PATCH 2/2] New package: input-event-daemon keguang.zhang at gmail.com
@ 2011-04-26  1:52 ` Kelvin Cheung
  2011-05-03 20:43 ` Peter Korsgaard
  1 sibling, 0 replies; 3+ messages in thread
From: Kelvin Cheung @ 2011-04-26  1:52 UTC (permalink / raw)
  To: buildroot

2011/4/21 <keguang.zhang@gmail.com>

> From: Kelvin Cheung <keguang.zhang@gmail.com>
>
> Add new package: input-event-daemon
>
> input-event-daemon -  input event handling daemon for linux.
>
> Signed-off-by: Kelvin Cheung <keguang.zhang@gmail.com>
> ---
>  package/Config.in                                |    1 +
>  package/input-event-daemon/Config.in             |    8 ++++
>  package/input-event-daemon/S99input-event-daemon |   40
> +++++++++++++++++++++
>  package/input-event-daemon/input-event-daemon.mk |   41
> ++++++++++++++++++++++
>  4 files changed, 90 insertions(+), 0 deletions(-)
>  create mode 100644 package/input-event-daemon/Config.in
>  create mode 100755 package/input-event-daemon/S99input-event-daemon
>  create mode 100644 package/input-event-daemon/input-event-daemon.mk
>
> diff --git a/package/Config.in b/package/Config.in
> index 0db0cd6..4bd2864 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -176,6 +176,7 @@ source "package/hdparm/Config.in"
>  endif
>  source "package/hwdata/Config.in"
>  source "package/i2c-tools/Config.in"
> +source "package/input-event-daemon/Config.in"
>  source "package/input-tools/Config.in"
>  source "package/iostat/Config.in"
>  source "package/irda-utils/Config.in"
> diff --git a/package/input-event-daemon/Config.in
> b/package/input-event-daemon/Config.in
> new file mode 100644
> index 0000000..edf2886
> --- /dev/null
> +++ b/package/input-event-daemon/Config.in
> @@ -0,0 +1,8 @@
> +config BR2_PACKAGE_INPUT_EVENT_DAEMON
> +       bool "input-event-daemon"
> +       help
> +         input-event-daemon is a daemon which executes
> +         a user-defined command on input events, such as
> +         keys, mouse buttons and switches.
> +
> +         http://github.com/gandro/input-event-daemon
> diff --git a/package/input-event-daemon/S99input-event-daemon
> b/package/input-event-daemon/S99input-event-daemon
> new file mode 100755
> index 0000000..ed374f4
> --- /dev/null
> +++ b/package/input-event-daemon/S99input-event-daemon
> @@ -0,0 +1,40 @@
> +#! /bin/sh
> +
> +[ -f /usr/bin/input-event-daemon ] || exit 0
> +
> +start() {
> +       echo -n "Starting input-event-daemon: "
> +       input-event-daemon
> +       echo "done"
> +}
> +
> +
> +stop() {
> +        echo -n "Stopping input-event-daemon: "
> +       echo
> +        killall input-event-daemon
> +       echo "done"
> +}
> +
> +restart() {
> +       stop
> +       start
> +}
> +
> +# See how we were called.
> +case "$1" in
> +  start)
> +       start
> +       ;;
> +  stop)
> +       stop
> +       ;;
> +  restart|reload)
> +       restart
> +       ;;
> +  *)
> +       echo "Usage: $0 {start|stop|reload|restart}"
> +       exit 1
> +esac
> +
> +exit $?
> diff --git a/package/input-event-daemon/input-event-daemon.mkb/package/input-event-daemon/
> input-event-daemon.mk
> new file mode 100644
> index 0000000..5cd6e72
> --- /dev/null
> +++ b/package/input-event-daemon/input-event-daemon.mk
> @@ -0,0 +1,41 @@
> +#############################################################
> +#
> +# input-event-daemon
> +#
> +#############################################################
> +INPUT_EVENT_DAEMON_VERSION:=13f4d61
> +INPUT_EVENT_DAEMON_SITE:=git://github.com/gandro/input-event-daemon.git
> +
> +define INPUT_EVENT_DAEMON_BUILD_CMDS
> +       touch  $(@D)/input-event-table.h
> +       $(MAKE) CFLAGS="$(TARGET_CFLAGS)" CC="$(TARGET_CC)" -C $(@D)
> +endef
> +
> +define INPUT_EVENT_DAEMON_INSTALL_TARGET_CMDS
> +       $(INSTALL) -m 755 -D $(@D)/input-event-daemon $(TARGET_DIR)/usr/bin
> +       -$(STRIPCMD) $(STRIP_STRIP_UNNEEDED)
> $(TARGET_DIR)/usr/bin/input-event-daemon
> +       cp -n $(@D)/docs/sample.conf
> $(TARGET_DIR)/etc/input-event-daemon.conf
> +endef
> +
> +define INPUT_EVENT_DAEMON_CLEAN_CMDS
> +       $(MAKE) -C $(@D) clean
> +endef
> +
> +define INPUT_EVENT_DAEMON_UNINSTALL_TARGET_CMDS
> +       rm -f $(TARGET_DIR)/usr/bin/input-event-daemon
> +       rm -f $(TARGET_DIR)/etc/input-event-daemon.conf
> +endef
> +
> +define INPUT_EVENT_DAEMON_COSTUM_INSTALL
> +       # install start/stop script
> +       $(call MESSAGE,"Installing S99input-event-daemon init script")
> +       if [ ! -f $(TARGET_DIR)/etc/init.d/S99input-event-daemon ]; then \
> +               $(INSTALL) -m 0755 -D
> package/input-event-daemon/S99input-event-daemon \
> +               $(TARGET_DIR)/etc/init.d/S99input-event-daemon; \
> +       fi
> +       $(Q)touch $@
> +endef
> +
> +INPUT_EVENT_DAEMON_POST_INSTALL_TARGET_HOOKS +=
> INPUT_EVENT_DAEMON_COSTUM_INSTALL
> +
> +$(eval $(call GENTARGETS,package,input-event-daemon))
> --
> 1.7.1
>
>
Hi Peter,

What about this patch?
input-event-daemon is a very useful tool for non-GUI system.

-- 
Best Regards!
Kelvin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20110426/1a9683eb/attachment.html>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH 2/2] New package: input-event-daemon
  2011-04-21  2:30 [Buildroot] [PATCH 2/2] New package: input-event-daemon keguang.zhang at gmail.com
  2011-04-26  1:52 ` Kelvin Cheung
@ 2011-05-03 20:43 ` Peter Korsgaard
  1 sibling, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2011-05-03 20:43 UTC (permalink / raw)
  To: buildroot

>>>>> "keguang" == keguang zhang <keguang.zhang@gmail.com> writes:

 keguang> From: Kelvin Cheung <keguang.zhang@gmail.com>
 keguang> Add new package: input-event-daemon

 keguang> input-event-daemon -  input event handling daemon for linux.

 keguang> Signed-off-by: Kelvin Cheung <keguang.zhang@gmail.com>
 keguang> ---
 keguang>  package/Config.in                                |    1 +
 keguang>  package/input-event-daemon/Config.in             |    8 ++++
 keguang>  package/input-event-daemon/S99input-event-daemon |   40 +++++++++++++++++++++
 keguang>  package/input-event-daemon/input-event-daemon.mk |   41 ++++++++++++++++++++++
 keguang>  4 files changed, 90 insertions(+), 0 deletions(-)
 keguang>  create mode 100644 package/input-event-daemon/Config.in
 keguang>  create mode 100755 package/input-event-daemon/S99input-event-daemon
 keguang>  create mode 100644 package/input-event-daemon/input-event-daemon.mk

 keguang> diff --git a/package/Config.in b/package/Config.in
 keguang> index 0db0cd6..4bd2864 100644
 keguang> --- a/package/Config.in
 keguang> +++ b/package/Config.in
 keguang> @@ -176,6 +176,7 @@ source "package/hdparm/Config.in"
 keguang>  endif
 keguang>  source "package/hwdata/Config.in"
 keguang>  source "package/i2c-tools/Config.in"
 keguang> +source "package/input-event-daemon/Config.in"
 keguang>  source "package/input-tools/Config.in"
 keguang>  source "package/iostat/Config.in"
 keguang>  source "package/irda-utils/Config.in"
 keguang> diff --git a/package/input-event-daemon/Config.in b/package/input-event-daemon/Config.in
 keguang> new file mode 100644
 keguang> index 0000000..edf2886
 keguang> --- /dev/null
 keguang> +++ b/package/input-event-daemon/Config.in
 keguang> @@ -0,0 +1,8 @@
 keguang> +config BR2_PACKAGE_INPUT_EVENT_DAEMON
 keguang> +	bool "input-event-daemon"
 keguang> +	help
 keguang> +	  input-event-daemon is a daemon which executes
 keguang> +	  a user-defined command on input events, such as
 keguang> +	  keys, mouse buttons and switches.
 keguang> +
 keguang> +	  http://github.com/gandro/input-event-daemon
 keguang> diff --git a/package/input-event-daemon/S99input-event-daemon b/package/input-event-daemon/S99input-event-daemon
 keguang> new file mode 100755
 keguang> index 0000000..ed374f4
 keguang> --- /dev/null
 keguang> +++ b/package/input-event-daemon/S99input-event-daemon
 keguang> @@ -0,0 +1,40 @@
 keguang> +#! /bin/sh
 keguang> +
 keguang> +[ -f /usr/bin/input-event-daemon ] || exit 0
 keguang> +
 keguang> +start() {
 keguang> +	echo -n "Starting input-event-daemon: "
 keguang> +	input-event-daemon
 keguang> +	echo "done"
 keguang> +}
 keguang> +
 keguang> +
 keguang> +stop() {
 keguang> +        echo -n "Stopping input-event-daemon: "
 keguang> +	echo
 keguang> +        killall input-event-daemon
 keguang> +	echo "done"

The empty echo seems misplaced, and a mix of tabs and spaces.

 keguang> +}
 keguang> +
 keguang> +restart() {
 keguang> +	stop
 keguang> +	start
 keguang> +}
 keguang> +
 keguang> +# See how we were called.
 keguang> +case "$1" in
 keguang> +  start)
 keguang> +	start
 keguang> +	;;
 keguang> +  stop)
 keguang> +	stop
 keguang> +	;;
 keguang> +  restart|reload)
 keguang> +	restart
 keguang> +	;;
 keguang> +  *)
 keguang> +	echo "Usage: $0 {start|stop|reload|restart}"
 keguang> +	exit 1
 keguang> +esac
 keguang> +
 keguang> +exit $?
 keguang> diff --git a/package/input-event-daemon/input-event-daemon.mk b/package/input-event-daemon/input-event-daemon.mk
 keguang> new file mode 100644
 keguang> index 0000000..5cd6e72
 keguang> --- /dev/null
 keguang> +++ b/package/input-event-daemon/input-event-daemon.mk
 keguang> @@ -0,0 +1,41 @@
 keguang> +#############################################################
 keguang> +#
 keguang> +# input-event-daemon
 keguang> +#
 keguang> +#############################################################
 keguang> +INPUT_EVENT_DAEMON_VERSION:=13f4d61
 keguang> +INPUT_EVENT_DAEMON_SITE:=git://github.com/gandro/input-event-daemon.git

Any reason to not use the v0.1.3 tag instead? Github also has tarballs,
but the download system seems a bit broken.

 keguang> +
 keguang> +define INPUT_EVENT_DAEMON_BUILD_CMDS
 keguang> +	touch  $(@D)/input-event-table.h
 keguang> +	$(MAKE) CFLAGS="$(TARGET_CFLAGS)" CC="$(TARGET_CC)" -C $(@D)

You should also pass LDFLAGS even though we're not currently setting it
to anything.

 keguang> +endef
 keguang> +
 keguang> +define INPUT_EVENT_DAEMON_INSTALL_TARGET_CMDS
 keguang> +	$(INSTALL) -m 755 -D $(@D)/input-event-daemon $(TARGET_DIR)/usr/bin

You need to provide the destination filename when you use install -D

 keguang> +	-$(STRIPCMD) $(STRIP_STRIP_UNNEEDED) $(TARGET_DIR)/usr/bin/input-event-daemon

Stripping is handled automatically nowadays.

 keguang> +	cp -n $(@D)/docs/sample.conf $(TARGET_DIR)/etc/input-event-daemon.conf

Here you use cp -n and below you use [ ! -f <file> ] (which is how it's
done elsewhere in BR).

 keguang> +endef
 keguang> +
 keguang> +define INPUT_EVENT_DAEMON_CLEAN_CMDS
 keguang> +	$(MAKE) -C $(@D) clean
 keguang> +endef
 keguang> +
 keguang> +define INPUT_EVENT_DAEMON_UNINSTALL_TARGET_CMDS
 keguang> +	rm -f $(TARGET_DIR)/usr/bin/input-event-daemon
 keguang> +	rm -f $(TARGET_DIR)/etc/input-event-daemon.conf
 keguang> +endef
 keguang> +
 keguang> +define INPUT_EVENT_DAEMON_COSTUM_INSTALL
 keguang> +	# install start/stop script
 keguang> +	$(call MESSAGE,"Installing S99input-event-daemon init script")
 keguang> +	if [ ! -f $(TARGET_DIR)/etc/init.d/S99input-event-daemon ]; then \
 keguang> +		$(INSTALL) -m 0755 -D package/input-event-daemon/S99input-event-daemon \
 keguang> +		$(TARGET_DIR)/etc/init.d/S99input-event-daemon; \
 keguang> +	fi
 keguang> +	$(Q)touch $@
 keguang> +endef

This might as well be combined with the normal install step.

I've committed it with those minor issues fixed, thanks!

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2011-05-03 20:43 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-04-21  2:30 [Buildroot] [PATCH 2/2] New package: input-event-daemon keguang.zhang at gmail.com
2011-04-26  1:52 ` Kelvin Cheung
2011-05-03 20:43 ` Peter Korsgaard

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox