[Buildroot] [PATCH v2] package/haproxy: fix runtime 'FATAL ERROR: invalid code detected -- cannot go further

[Buildroot] [PATCH v2] package/haproxy: fix runtime 'FATAL ERROR: invalid code detected -- cannot go further

[Aleksandr Makarov]

This is a re-spin of v1 that was modifying haproxy's Makefile and was
rejected by upstream [1].

I made a v2 that makes changes to haproxy.mk recipe instead and dropped
the .patch to program source.

[1] https://www.mail-archive.com/haproxy@formilux.org/msg44499.html


Aleksandr Makarov (1):
  package/haproxy: fix runtime 'FATAL ERROR: invalid code detected --
    cannot go further'

 package/haproxy/haproxy.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.39.2

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH v2] package/haproxy: fix runtime 'FATAL ERROR: invalid code detected -- cannot go further'

[Aleksandr Makarov]

Setting HAPROXY_CFLAGS on the haproxy build command line overrides CFLAGS
which were internally set by the haproxy Makefile.

Among those omitted CFLAGS is -fwrapv. Compiling haproxy without it and
and then running the program results in runtime error:

$ haproxy
FATAL ERROR: invalid code detected -- cannot go further, please recompile!
...

To address this issue, include HAPROXY_CFLAGS in the DEFINE variable instead
of CFLAGS in haproxy.mk.

---
Changes v1 -> v2
  - Drop patch for haproxy program Makefile, make changes to haproxy.mk instead
---
 package/haproxy/haproxy.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/haproxy/haproxy.mk b/package/haproxy/haproxy.mk
index 63a92090f3..61a9ebebe4 100644
--- a/package/haproxy/haproxy.mk
+++ b/package/haproxy/haproxy.mk
@@ -82,7 +82,7 @@ endif
 
 define HAPROXY_BUILD_CMDS
 	$(TARGET_MAKE_ENV) $(MAKE) $(TARGET_CONFIGURE_OPTS) \
-		$(HAPROXY_MAKE_OPTS) CFLAGS="$(HAPROXY_CFLAGS)" -C $(@D)
+		$(HAPROXY_MAKE_OPTS) DEFINE="$(HAPROXY_CFLAGS)" -C $(@D)
 endef
 
 define HAPROXY_INSTALL_TARGET_CMDS
-- 
2.39.2

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v2] package/haproxy: fix runtime 'FATAL ERROR: invalid code detected -- cannot go further'

[Yann E. MORIN]

Aleksandr, All,

On 2024-02-04 22:16 +0200, Aleksandr Makarov spake thusly:
> Setting HAPROXY_CFLAGS on the haproxy build command line overrides CFLAGS
> which were internally set by the haproxy Makefile.
> 
> Among those omitted CFLAGS is -fwrapv. Compiling haproxy without it and
> and then running the program results in runtime error:
> 
> $ haproxy
> FATAL ERROR: invalid code detected -- cannot go further, please recompile!
> ...
> 
> To address this issue, include HAPROXY_CFLAGS in the DEFINE variable instead
> of CFLAGS in haproxy.mk.

You forgot to add your Signed-off-by line here, but I messed up and
applied and pushed.

/me goes fumble with his git hooks to understand why that was not
caught...

Applied to master, thanks.

Regards,
Yann E. MORIN.

> ---
> Changes v1 -> v2
>   - Drop patch for haproxy program Makefile, make changes to haproxy.mk instead
> ---
>  package/haproxy/haproxy.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/package/haproxy/haproxy.mk b/package/haproxy/haproxy.mk
> index 63a92090f3..61a9ebebe4 100644
> --- a/package/haproxy/haproxy.mk
> +++ b/package/haproxy/haproxy.mk
> @@ -82,7 +82,7 @@ endif
>  
>  define HAPROXY_BUILD_CMDS
>  	$(TARGET_MAKE_ENV) $(MAKE) $(TARGET_CONFIGURE_OPTS) \
> -		$(HAPROXY_MAKE_OPTS) CFLAGS="$(HAPROXY_CFLAGS)" -C $(@D)
> +		$(HAPROXY_MAKE_OPTS) DEFINE="$(HAPROXY_CFLAGS)" -C $(@D)
>  endef
>  
>  define HAPROXY_INSTALL_TARGET_CMDS
> -- 
> 2.39.2
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v2] package/haproxy: fix runtime 'FATAL ERROR: invalid code detected -- cannot go further'

[Peter Korsgaard]

>>>>> "Aleksandr" == Aleksandr Makarov <aleksandr.o.makarov@gmail.com> writes:

 > Setting HAPROXY_CFLAGS on the haproxy build command line overrides CFLAGS
 > which were internally set by the haproxy Makefile.

 > Among those omitted CFLAGS is -fwrapv. Compiling haproxy without it and
 > and then running the program results in runtime error:

 > $ haproxy
 > FATAL ERROR: invalid code detected -- cannot go further, please recompile!
 > ...

 > To address this issue, include HAPROXY_CFLAGS in the DEFINE variable instead
 > of CFLAGS in haproxy.mk.

 > ---
 > Changes v1 -> v2
 >   - Drop patch for haproxy program Makefile, make changes to haproxy.mk instead

Committed to 2023.02.x and 2023.11.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot