[Buildroot] [PATCH 1/1] package/opencv4-contrib: fix INSTALL_TARGET value

[Buildroot] [PATCH 1/1] package/opencv4-contrib: fix INSTALL_TARGET value

[Maximilian Senftleben]

The variable should be a YES/NO value, FALSE is not a valid value.
E.g. the yesno-to-bool cmd does not translate a FALSE value and therefore returns invalid JSON.

Signed-off-by: Maximilian Senftleben <maximilian.senftleben@frogblue-tec.com>
---
 package/opencv4-contrib/opencv4-contrib.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/opencv4-contrib/opencv4-contrib.mk b/package/opencv4-contrib/opencv4-contrib.mk
index 52d2682b26..f8c8cfd94c 100644
--- a/package/opencv4-contrib/opencv4-contrib.mk
+++ b/package/opencv4-contrib/opencv4-contrib.mk
@@ -6,7 +6,7 @@
 
 OPENCV4_CONTRIB_VERSION = 4.8.1
 OPENCV4_CONTRIB_SITE = $(call github,opencv,opencv_contrib,$(OPENCV4_CONTRIB_VERSION))
-OPENCV4_CONTRIB_INSTALL_TARGET = FALSE
+OPENCV4_CONTRIB_INSTALL_TARGET = NO
 OPENCV4_CONTRIB_LICENSE = Apache-2.0
 OPENCV4_CONTRIB_LICENSE_FILES = LICENSE
 
-- 
2.43.0


_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/opencv4-contrib: fix INSTALL_TARGET value

[Yann E. MORIN]

Maximilain, All,

On 2024-01-23 15:02 +0100, Maximilian Senftleben spake thusly:
> The variable should be a YES/NO value, FALSE is not a valid value.
> E.g. the yesno-to-bool cmd does not translate a FALSE value and therefore returns invalid JSON.

Good catch, thanks!

> Signed-off-by: Maximilian Senftleben <maximilian.senftleben@frogblue-tec.com>

Applied to master, thanks.

Regards,
Yann E. MORIN.

> ---
>  package/opencv4-contrib/opencv4-contrib.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/package/opencv4-contrib/opencv4-contrib.mk b/package/opencv4-contrib/opencv4-contrib.mk
> index 52d2682b26..f8c8cfd94c 100644
> --- a/package/opencv4-contrib/opencv4-contrib.mk
> +++ b/package/opencv4-contrib/opencv4-contrib.mk
> @@ -6,7 +6,7 @@
>  
>  OPENCV4_CONTRIB_VERSION = 4.8.1
>  OPENCV4_CONTRIB_SITE = $(call github,opencv,opencv_contrib,$(OPENCV4_CONTRIB_VERSION))
> -OPENCV4_CONTRIB_INSTALL_TARGET = FALSE
> +OPENCV4_CONTRIB_INSTALL_TARGET = NO
>  OPENCV4_CONTRIB_LICENSE = Apache-2.0
>  OPENCV4_CONTRIB_LICENSE_FILES = LICENSE
>  
> -- 
> 2.43.0
> 
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/opencv4-contrib: fix INSTALL_TARGET value

[Peter Korsgaard]

>>>>> "Maximilian" == Maximilian Senftleben <maximilian.senftleben@frogblue-tec.com> writes:

 > The variable should be a YES/NO value, FALSE is not a valid value.
 > E.g. the yesno-to-bool cmd does not translate a FALSE value and
 > therefore returns invalid JSON.

 > Signed-off-by: Maximilian Senftleben <maximilian.senftleben@frogblue-tec.com>

Committed to 2023.02.x and 2023.11.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot